You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Cai-Yao (via GitHub)" <gi...@apache.org> on 2023/04/03 17:04:27 UTC
[GitHub] [doris] Cai-Yao opened a new pull request, #18358: [Enchancement](compatable) show dateV2/datetimeV2 to date/datetime
Cai-Yao opened a new pull request, #18358:
URL: https://github.com/apache/doris/pull/18358
# Proposed changes
Issue Number: close #xxx
# Problem summary
show dateV2/datetimeV2 to date/datetime
- modify `show create table`
add real type into comment.
- modify `desc table`
replace type directly.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #18358: [Enchancement](compatible) show dateV2/datetimeV2 to date/datetime
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #18358:
URL: https://github.com/apache/doris/pull/18358#discussion_r1160583822
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/DescribeStmt.java:
##########
@@ -288,6 +301,13 @@ public List<List<String>> getResultRows() throws AnalysisException {
List<List<String>> rows = node.fetchResult().getRows();
List<List<String>> res = new ArrayList<>();
for (List<String> row : rows) {
+ // show DATEV2/DATETIMEV2 to DATE/DATETIME for compatibility
+ if (row.get(1).length() >= 6 && row.get(1).substring(0, 6).equals("DATEV2")) {
Review Comment:
why add these code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #18358: [Enchancement](compatible) show dateV2/datetimeV2 to date/datetime
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #18358:
URL: https://github.com/apache/doris/pull/18358#discussion_r1160583534
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/DescribeStmt.java:
##########
@@ -205,6 +211,7 @@ public void analyze(Analyzer analyzer) throws UserException {
"",
column.getName(),
column.getOriginType().toString(),
+ column.getOriginType().toString(),
Review Comment:
是不是跟213 行重复了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #18358: [Enchancement](compatible) show dateV2/datetimeV2 to date/datetime
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #18358:
URL: https://github.com/apache/doris/pull/18358#discussion_r1160580523
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/DescribeStmt.java:
##########
@@ -67,6 +67,7 @@ public class DescribeStmt extends ShowStmt {
.addColumn(new Column("IndexKeysType", ScalarType.createVarchar(20)))
.addColumn(new Column("Field", ScalarType.createVarchar(20)))
.addColumn(new Column("Type", ScalarType.createVarchar(20)))
+ .addColumn(new Column("ColumnType", ScalarType.createVarchar(20)))
Review Comment:
InternalType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18358: [Enchancement](compatible) show dateV2/datetimeV2 to date/datetime
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18358:
URL: https://github.com/apache/doris/pull/18358#issuecomment-1501010386
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #18358: [Enchancement](compatible) show dateV2/datetimeV2 to date/datetime
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #18358:
URL: https://github.com/apache/doris/pull/18358#issuecomment-1498623578
Do not changing `comment`. The `comment` is "user specified info", you should not modify any content specified by user.
I suggest to extent the column of `desc table all` statement, to add a new column to indicate the v2/v3 info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18358: [Enchancement](compatible) show dateV2/datetimeV2 to date/datetime
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18358:
URL: https://github.com/apache/doris/pull/18358#issuecomment-1501010395
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Cai-Yao commented on a diff in pull request #18358: [Enchancement](compatible) show dateV2/datetimeV2 to date/datetime
Posted by "Cai-Yao (via GitHub)" <gi...@apache.org>.
Cai-Yao commented on code in PR #18358:
URL: https://github.com/apache/doris/pull/18358#discussion_r1160618777
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/DescribeStmt.java:
##########
@@ -205,6 +211,7 @@ public void analyze(Analyzer analyzer) throws UserException {
"",
column.getName(),
column.getOriginType().toString(),
+ column.getOriginType().toString(),
Review Comment:
> 是不是跟213 行重复了
填充type和新加的columntype两个列
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on pull request #18358: [Enchancement](compatible) show dateV2/datetimeV2 to date/datetime
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on PR #18358:
URL: https://github.com/apache/doris/pull/18358#issuecomment-1501010310
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Cai-Yao commented on a diff in pull request #18358: [Enchancement](compatible) show dateV2/datetimeV2 to date/datetime
Posted by "Cai-Yao (via GitHub)" <gi...@apache.org>.
Cai-Yao commented on code in PR #18358:
URL: https://github.com/apache/doris/pull/18358#discussion_r1160618777
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/DescribeStmt.java:
##########
@@ -205,6 +211,7 @@ public void analyze(Analyzer analyzer) throws UserException {
"",
column.getName(),
column.getOriginType().toString(),
+ column.getOriginType().toString(),
Review Comment:
> 是不是跟213 行重复了
不是，一个是替换后的type，一个是新加的InternalYype列
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #18358: [Enchancement](compatible) show dateV2/datetimeV2 to date/datetime
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #18358:
URL: https://github.com/apache/doris/pull/18358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org