You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by de...@apache.org on 2006/11/08 22:16:19 UTC

svn commit: r472648 - in /maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle: CheckstyleReportGenerator.java CheckstyleReportListener.java

Author: dennisl
Date: Wed Nov  8 13:16:19 2006
New Revision: 472648

URL: http://svn.apache.org/viewvc?view=rev&rev=472648
Log:
o Fix the remaining Checkstyle errors.

Modified:
    maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java
    maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportListener.java

Modified: maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java?view=diff&rev=472648&r1=472647&r2=472648
==============================================================================
--- maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java (original)
+++ maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java Wed Nov  8 13:16:19 2006
@@ -33,6 +33,9 @@
 import java.util.List;
 import java.util.ResourceBundle;
 
+/**
+ * Generate a report based on CheckstyleResults.
+ */
 public class CheckstyleReportGenerator
 {
     private Log log;
@@ -424,8 +427,8 @@
                         // Read MessageFormat Javadoc about single quote:
                         // http://java.sun.com/j2se/1.4.2/docs/api/java/text/MessageFormat.html
                         String msgWithoutSingleQuote = StringUtils.replace( message, "'", "" );
-                        if ( message.equals( event.getMessage() ) ||
-                             msgWithoutSingleQuote.equals( event.getMessage() ) )
+                        if ( message.equals( event.getMessage() )
+                            || msgWithoutSingleQuote.equals( event.getMessage() ) )
                         {
                             count++;
                         }

Modified: maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportListener.java
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportListener.java?view=diff&rev=472648&r1=472647&r2=472648
==============================================================================
--- maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportListener.java (original)
+++ maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportListener.java Wed Nov  8 13:16:19 2006
@@ -102,9 +102,9 @@
      */
     public void fileStarted( AuditEvent event )
     {
-        for (Iterator it = sourceDirectories.iterator(); it.hasNext(); )
+        for ( Iterator it = sourceDirectories.iterator(); it.hasNext(); )
         {
-            File sourceDirectory = (File)it.next();
+            File sourceDirectory = (File) it.next();
 
             currentFile = StringUtils.substring( event.getFileName(), sourceDirectory.getPath().length() + 1 );
             currentFile = StringUtils.replace( currentFile, "\\", "/" );