[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #266: [ISSUE-257] RssMRUtils#getBlockId change the partitionId of int type to long

[GitBox <gi...@apache.org>]

jerqi commented on code in PR #266:
URL: https://github.com/apache/incubator-uniffle/pull/266#discussion_r998134827


##########
client-mr/src/main/java/org/apache/hadoop/mapred/SortWriteBufferManager.java:
##########
@@ -312,7 +312,7 @@ ShuffleBlockInfo createShuffleBlock(SortWriteBuffer wb) {
     final byte[] compressed = RssShuffleUtils.compressData(data);
     final long crc32 = ChecksumUtils.getCrc32(compressed);
     compressTime += System.currentTimeMillis() - start;
-    final long blockId = RssMRUtils.getBlockId(partitionId, taskAttemptId, getNextSeqNo(partitionId));
+    final long blockId = RssMRUtils.getBlockId(Long.valueOf(partitionId), taskAttemptId, getNextSeqNo(partitionId));

Review Comment:
   > Is it necessary to change this line? Pass int value to long argument should be fine.
   
   Just tell the reader of code that we're sure that we need this type cast.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org