You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/01/29 23:29:44 UTC
[GitHub] [druid] jihoonson opened a new pull request #10819: Clearer instructions to update website for release
jihoonson opened a new pull request #10819:
URL: https://github.com/apache/druid/pull/10819
### Description
Fixes a wrong branch name for `druid-website` in updating druid.staged.apache.org. Also add an explicit branch name for `druid-website-src`.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #10819: Clearer instructions to update website for release
Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #10819:
URL: https://github.com/apache/druid/pull/10819#issuecomment-773743262
Test failure is not relevant to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #10819: Clearer instructions to update website for release
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #10819:
URL: https://github.com/apache/druid/pull/10819#discussion_r570660656
##########
File path: distribution/asf-release-process-guide.md
##########
@@ -557,14 +557,18 @@ druid_versions:
date: 2019-08-15
```
-3. From druid-website-src, run `./release.sh 0.17.0 0.17.0`, replacing `0.17.0` where the first argument is the release version and 2nd argument is commit-ish. This script will:
+3. From druid-website, checkout branch `asf-site`.
+
+4. From druid-website-src, checkout the branch you created to update the staged Druid website or create a new branch from `master` if you don't have.
Review comment:
nit:
```suggestion
4. From druid-website-src, checkout the branch you created to update the staged Druid website or create a new branch from `master` if you have not.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #10819: Clearer instructions to update website for release
Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #10819:
URL: https://github.com/apache/druid/pull/10819#issuecomment-773743262
Test failure is not relevant to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #10819: Clearer instructions to update website for release
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #10819:
URL: https://github.com/apache/druid/pull/10819#discussion_r570660656
##########
File path: distribution/asf-release-process-guide.md
##########
@@ -557,14 +557,18 @@ druid_versions:
date: 2019-08-15
```
-3. From druid-website-src, run `./release.sh 0.17.0 0.17.0`, replacing `0.17.0` where the first argument is the release version and 2nd argument is commit-ish. This script will:
+3. From druid-website, checkout branch `asf-site`.
+
+4. From druid-website-src, checkout the branch you created to update the staged Druid website or create a new branch from `master` if you don't have.
Review comment:
nit:
```suggestion
4. From druid-website-src, checkout the branch you created to update the staged Druid website or create a new branch from `master` if you have not.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #10819: Clearer instructions to update website for release
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #10819:
URL: https://github.com/apache/druid/pull/10819
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #10819: Clearer instructions to update website for release
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #10819:
URL: https://github.com/apache/druid/pull/10819
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org