You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/07 08:01:03 UTC
[GitHub] [spark] sunchao opened a new pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
sunchao opened a new pull request #31081:
URL: https://github.com/apache/spark/pull/31081
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This changes `ReplaceTableExec`/`AtomicReplaceTableExec`, and uncaches the target table before it is dropped. In addition, this includes some refactoring by moving the `uncacheTable` method to `DataSourceV2Strategy` so that we don't need to pass a Spark session to the v2 exec.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Similar to SPARK-33492 (#30429). When a table is refreshed, the associated cache should be invalidated to avoid potential incorrect results.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes. Now When a data source v2 is cached (either directly or indirectly), all the relevant caches will be refreshed or invalidated if the table is replaced.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added a new unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon edited a comment on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
HyukjinKwon edited a comment on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757573869
@sunchao and @MaxGekk, can we have an umbrella ticket or epic ticket (if an umbrella ticket is not possible) to group these caching / uncaching issues? Let's block RC until we feel sure these issues are fixed then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757573869
@MaxGekk and @sunchao, can we have an umbrella ticket or epic ticket (if an umbrella ticket is not possible) to group these caching / uncaching issues? Let's block RC until we feel sure these issues are fixed then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #31081:
URL: https://github.com/apache/spark/pull/31081
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757517944
BTW some of the cache fixes are not in branch-3.0, @HyukjinKwon @dongjoon-hyun let me know if it's necessary to make the backports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757004505
Thanks @dongjoon-hyun . Did the above include this PR? There is another issue [SPARK-34052](https://issues.apache.org/jira/browse/SPARK-34052) on handling temporary view in DSv2 which could cause the above as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757004973
No~ As I wrote, I used Apache Spark 3.1.0 RC1 with Iceberg 0.10 to see the existing behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-755960731
**[Test build #133782 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133782/testReport)** for PR 31081 at commit [`d8ea7b6`](https://github.com/apache/spark/commit/d8ea7b6cf9308e53aab9d14774a6a5b8bbcd9908).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757409089
Sure, I think RC1 is failed. Thanks for letting me know @dongjoon-hyun. +1 for porting it back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757006930
I agree with you, @sunchao .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757734599
I have converted my tickets to sub-tasks of SPARK-33507
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-756019987
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38370/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757409189
BTW, do we have more issues to fix like this? I have seen similar cache/uncache fixes often lately. If we have some issues to fix already, it might be best to delay the next RC until we have the fixes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-756107148
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133782/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] aokolnychyi commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757006801
It would be great to see this fixed in 3.1.0. Thanks for the work!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757006581
Got you. Yes I think we should backport this (I'll create one soon). In addition, we may need [SPARK-34052](https://issues.apache.org/jira/browse/SPARK-34052) to completely address the issue.
In the second:
```sql
spark-sql> SELECT * FROM v;
4 5
```
IMO, the temporary view `v` should become invalid once the source table `local.db.table` is replaced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-755992506
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38370/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-756091624
**[Test build #133782 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133782/testReport)** for PR 31081 at commit [`d8ea7b6`](https://github.com/apache/spark/commit/d8ea7b6cf9308e53aab9d14774a6a5b8bbcd9908).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757517580
@HyukjinKwon I'm working on #31107 which also seems to be a bug on caching. Yes it seems there are many issues related to this area recently, and I feel we haven't identified all of them yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757004505
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-756890129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sunchao commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757574446
@HyukjinKwon yes I've tried to put all these under https://issues.apache.org/jira/browse/SPARK-33507. @MaxGekk do you mind adding yours to here too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757575820
@MaxGekk
if your goal is different from SPARK-33507, you can also file another umbrella ticket and link SPARK-33507 with `incooperates` link.
If the goal looks similar or a subset, please move and file JIRAs under that one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-756890129
@sunchao . I tested this case with Apache Spark 3.1.0 RC1 with Iceberg 0.10. This is a correctness issue. How do you think about that? If you agree, please make a backport. (Also, cc @HyukjinKwon )
```
{code}
spark-sql> SELECT * FROM local.db.table;
4 5
spark-sql> CACHE TABLE v AS SELECT * FROM local.db.table;
spark-sql> SELECT * FROM v;
4 5
spark-sql> REPLACE TABLE local.db.table AS SELECT 100 id, '100' string;
spark-sql> SELECT * FROM v;
4 5
spark-sql> SELECT * FROM local.db.table;
100 100
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-756019987
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38370/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-756107148
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133782/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-755978210
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38370/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757524097
Thanks, @sunchao . Yes. It would be great if we have it if the UT fails there in the same way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-755960731
**[Test build #133782 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133782/testReport)** for PR 31081 at commit [`d8ea7b6`](https://github.com/apache/spark/commit/d8ea7b6cf9308e53aab9d14774a6a5b8bbcd9908).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757409089
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] aokolnychyi commented on pull request #31081: [SPARK-34039][SQL] ReplaceTable should invalidate cache
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on pull request #31081:
URL: https://github.com/apache/spark/pull/31081#issuecomment-757006801
It would be great to see this fixed in 3.1.0. Thanks for the work!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org