You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <js...@apache.org> on 2016/12/08 04:39:59 UTC
Review Request 54520: Revert BUILD changes in 0c177058.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54520/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
Repository: aurora
Description
-------
The changes caused `python_tests` target to lose their sources which in
turn caused tests not to run.
src/main/python/apache/aurora/admin/BUILD | 1 +
src/main/python/apache/aurora/client/BUILD | 1 +
src/main/python/apache/aurora/common/BUILD | 1 +
src/main/python/apache/aurora/config/BUILD | 1 +
src/main/python/apache/aurora/executor/BUILD | 1 +
src/main/python/apache/aurora/kerberos/BUILD | 1 +
src/main/python/apache/aurora/tools/BUILD | 1 +
src/main/python/apache/thermos/cli/BUILD | 1 +
src/main/python/apache/thermos/common/BUILD | 1 +
src/main/python/apache/thermos/config/BUILD | 1 +
src/main/python/apache/thermos/core/BUILD | 1 +
src/main/python/apache/thermos/monitoring/BUILD | 1 +
src/main/python/apache/thermos/observer/BUILD | 1 +
src/main/python/apache/thermos/runner/BUILD | 1 +
src/main/python/apache/thermos/testing/BUILD | 1 +
src/test/python/apache/aurora/BUILD | 1 +
src/test/python/apache/aurora/admin/BUILD | 2 ++
src/test/python/apache/aurora/client/BUILD | 2 ++
src/test/python/apache/aurora/client/api/BUILD | 2 ++
src/test/python/apache/aurora/client/cli/BUILD | 2 ++
src/test/python/apache/aurora/client/docker/BUILD | 2 ++
src/test/python/apache/aurora/client/hooks/BUILD | 3 ++-
src/test/python/apache/aurora/common/BUILD | 2 ++
src/test/python/apache/aurora/common/health_check/BUILD | 2 ++
src/test/python/apache/aurora/config/BUILD | 2 ++
src/test/python/apache/aurora/executor/BUILD | 2 ++
src/test/python/apache/aurora/executor/bin/BUILD | 2 ++
src/test/python/apache/aurora/executor/common/BUILD | 2 ++
src/test/python/apache/aurora/tools/BUILD | 2 ++
src/test/python/apache/thermos/cli/BUILD | 2 ++
src/test/python/apache/thermos/cli/commands/BUILD | 2 ++
src/test/python/apache/thermos/common/BUILD | 2 ++
src/test/python/apache/thermos/config/BUILD | 2 ++
src/test/python/apache/thermos/core/BUILD | 2 ++
src/test/python/apache/thermos/monitoring/BUILD | 2 ++
src/test/python/apache/thermos/observer/BUILD | 2 ++
src/test/python/apache/thermos/observer/http/BUILD | 2 ++
37 files changed, 58 insertions(+), 1 deletion(-)
Diffs
-----
src/main/python/apache/aurora/admin/BUILD 60bfbeda8369db71099a2056c509ea1f34eadaa6
src/main/python/apache/aurora/client/BUILD 452efd45beeb61042b24cf116690221eb95d02ca
src/main/python/apache/aurora/common/BUILD 85b5b45a099556a21d090e180645f0c680d62db3
src/main/python/apache/aurora/config/BUILD 14364ef77eeaa9fe5cd8df731c7047ba18beb361
src/main/python/apache/aurora/executor/BUILD bb6d4a3e21075ee4d56615e083059d7cae2e3e99
src/main/python/apache/aurora/kerberos/BUILD d1e6ded02ad8f71e56659fa4455dbbe14b965249
src/main/python/apache/aurora/tools/BUILD c970bec2c64226b22b624f39d21b2cedcaf4d60d
src/main/python/apache/thermos/cli/BUILD 784b05c6811a86589a5a1a64bc3d15302bb22479
src/main/python/apache/thermos/common/BUILD 023b87ff4ac28c58914a1a8d3943fb0554b1a259
src/main/python/apache/thermos/config/BUILD 729c6533d3e059c0e65bb69da3af464f1dd9d49f
src/main/python/apache/thermos/core/BUILD e800ccabfb780e8962686434f18caba522f6516b
src/main/python/apache/thermos/monitoring/BUILD a1c16ac782da3df78b325f5273f76c47a6a1febf
src/main/python/apache/thermos/observer/BUILD 714955d91e97fefc30841a2dd975f63962a444df
src/main/python/apache/thermos/runner/BUILD d51587842deeadfc316072b6c7fe4a584412db0a
src/main/python/apache/thermos/testing/BUILD 0964a7ddcb6558b6e685b3fa710f25b5862c72f1
src/test/python/apache/aurora/BUILD 48ea328c51fb41e1de65673d95e0416ecd1af9c8
src/test/python/apache/aurora/admin/BUILD 8dd8b6d71a5b9e2ddd44d93843853e4271402573
src/test/python/apache/aurora/client/BUILD 2347d226c8f22009d9a2170ea554d7512a47e2ff
src/test/python/apache/aurora/client/api/BUILD 8394d4e717c6ecb6ddb19dc4f67d039347d4ba8f
src/test/python/apache/aurora/client/cli/BUILD bd74d64f9b19c77f623d7054b5253f1032f02230
src/test/python/apache/aurora/client/docker/BUILD f0cf97157c9d8b145297d164c610bf020b3e9cd1
src/test/python/apache/aurora/client/hooks/BUILD bbbeb2fb2277e0c28d67b461a5c589e6c68d9779
src/test/python/apache/aurora/common/BUILD a65a959c0c472a8af2c9c7a0daf59fc85cb0cbc8
src/test/python/apache/aurora/common/health_check/BUILD 72719f290b3e31bdba5002a8cba7039e236903c9
src/test/python/apache/aurora/config/BUILD f8e83cea9dc2b093e8af0efa2d94ffb94b3d2d95
src/test/python/apache/aurora/executor/BUILD 38ddb143dd6a755deebd8db820bf7b4ae3ba341a
src/test/python/apache/aurora/executor/bin/BUILD b8a063580ec1b08df7008a351e02546e2d89c68e
src/test/python/apache/aurora/executor/common/BUILD e337ebdc82e70a7fd6ceb8d990b42445cc8d415e
src/test/python/apache/aurora/tools/BUILD a64b3603056ebee5bc5bbd081f03a131c4f35a58
src/test/python/apache/thermos/cli/BUILD 0ad1306f23dafeb0281f9f8ce484f589f201dee0
src/test/python/apache/thermos/cli/commands/BUILD 0ad1306f23dafeb0281f9f8ce484f589f201dee0
src/test/python/apache/thermos/common/BUILD 08b008e177ad0a63e35f8ea7cf092fd3bb93533c
src/test/python/apache/thermos/config/BUILD 904453884d22d341cb76c20670d641440c4c4c4c
src/test/python/apache/thermos/core/BUILD fd2e1527c94462d952752d5a69ac17f46f3221ac
src/test/python/apache/thermos/monitoring/BUILD cf7c5f07fd51143d2d56bcc5b7f0c13dc4029c2f
src/test/python/apache/thermos/observer/BUILD 1300e61597545f322de296fa91f2d9e1ab4b3bf1
src/test/python/apache/thermos/observer/http/BUILD 1300e61597545f322de296fa91f2d9e1ab4b3bf1
Diff: https://reviews.apache.org/r/54520/diff/
Testing
-------
Now with files listed and python tests run:
```
./pants filemap src/test/python/::
./build-support/jenkins/build.sh
```
Thanks,
John Sirois
Re: Review Request 54520: Revert BUILD changes in 0c177058.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54520/#review158499
-----------------------------------------------------------
Ship it!
Master (d05ea2b) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Dec. 8, 2016, 4:51 a.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54520/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2016, 4:51 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
>
>
> Bugs: AURORA-1853
> https://issues.apache.org/jira/browse/AURORA-1853
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The changes caused `python_tests` target to lose their sources which in
> turn caused tests not to run.
>
> src/main/python/apache/aurora/admin/BUILD | 1 +
> src/main/python/apache/aurora/client/BUILD | 1 +
> src/main/python/apache/aurora/common/BUILD | 1 +
> src/main/python/apache/aurora/config/BUILD | 1 +
> src/main/python/apache/aurora/executor/BUILD | 1 +
> src/main/python/apache/aurora/kerberos/BUILD | 1 +
> src/main/python/apache/aurora/tools/BUILD | 1 +
> src/main/python/apache/thermos/cli/BUILD | 1 +
> src/main/python/apache/thermos/common/BUILD | 1 +
> src/main/python/apache/thermos/config/BUILD | 1 +
> src/main/python/apache/thermos/core/BUILD | 1 +
> src/main/python/apache/thermos/monitoring/BUILD | 1 +
> src/main/python/apache/thermos/observer/BUILD | 1 +
> src/main/python/apache/thermos/runner/BUILD | 1 +
> src/main/python/apache/thermos/testing/BUILD | 1 +
> src/test/python/apache/aurora/BUILD | 1 +
> src/test/python/apache/aurora/admin/BUILD | 2 ++
> src/test/python/apache/aurora/client/BUILD | 2 ++
> src/test/python/apache/aurora/client/api/BUILD | 2 ++
> src/test/python/apache/aurora/client/cli/BUILD | 2 ++
> src/test/python/apache/aurora/client/docker/BUILD | 2 ++
> src/test/python/apache/aurora/client/hooks/BUILD | 3 ++-
> src/test/python/apache/aurora/common/BUILD | 2 ++
> src/test/python/apache/aurora/common/health_check/BUILD | 2 ++
> src/test/python/apache/aurora/config/BUILD | 2 ++
> src/test/python/apache/aurora/executor/BUILD | 2 ++
> src/test/python/apache/aurora/executor/bin/BUILD | 2 ++
> src/test/python/apache/aurora/executor/common/BUILD | 2 ++
> src/test/python/apache/aurora/tools/BUILD | 2 ++
> src/test/python/apache/thermos/cli/BUILD | 2 ++
> src/test/python/apache/thermos/cli/commands/BUILD | 2 ++
> src/test/python/apache/thermos/common/BUILD | 2 ++
> src/test/python/apache/thermos/config/BUILD | 2 ++
> src/test/python/apache/thermos/core/BUILD | 2 ++
> src/test/python/apache/thermos/monitoring/BUILD | 2 ++
> src/test/python/apache/thermos/observer/BUILD | 2 ++
> src/test/python/apache/thermos/observer/http/BUILD | 2 ++
> 37 files changed, 58 insertions(+), 1 deletion(-)
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 60bfbeda8369db71099a2056c509ea1f34eadaa6
> src/main/python/apache/aurora/client/BUILD 452efd45beeb61042b24cf116690221eb95d02ca
> src/main/python/apache/aurora/common/BUILD 85b5b45a099556a21d090e180645f0c680d62db3
> src/main/python/apache/aurora/config/BUILD 14364ef77eeaa9fe5cd8df731c7047ba18beb361
> src/main/python/apache/aurora/executor/BUILD bb6d4a3e21075ee4d56615e083059d7cae2e3e99
> src/main/python/apache/aurora/kerberos/BUILD d1e6ded02ad8f71e56659fa4455dbbe14b965249
> src/main/python/apache/aurora/tools/BUILD c970bec2c64226b22b624f39d21b2cedcaf4d60d
> src/main/python/apache/thermos/cli/BUILD 784b05c6811a86589a5a1a64bc3d15302bb22479
> src/main/python/apache/thermos/common/BUILD 023b87ff4ac28c58914a1a8d3943fb0554b1a259
> src/main/python/apache/thermos/config/BUILD 729c6533d3e059c0e65bb69da3af464f1dd9d49f
> src/main/python/apache/thermos/core/BUILD e800ccabfb780e8962686434f18caba522f6516b
> src/main/python/apache/thermos/monitoring/BUILD a1c16ac782da3df78b325f5273f76c47a6a1febf
> src/main/python/apache/thermos/observer/BUILD 714955d91e97fefc30841a2dd975f63962a444df
> src/main/python/apache/thermos/runner/BUILD d51587842deeadfc316072b6c7fe4a584412db0a
> src/main/python/apache/thermos/testing/BUILD 0964a7ddcb6558b6e685b3fa710f25b5862c72f1
> src/test/python/apache/aurora/BUILD 48ea328c51fb41e1de65673d95e0416ecd1af9c8
> src/test/python/apache/aurora/admin/BUILD 8dd8b6d71a5b9e2ddd44d93843853e4271402573
> src/test/python/apache/aurora/client/BUILD 2347d226c8f22009d9a2170ea554d7512a47e2ff
> src/test/python/apache/aurora/client/api/BUILD 8394d4e717c6ecb6ddb19dc4f67d039347d4ba8f
> src/test/python/apache/aurora/client/cli/BUILD bd74d64f9b19c77f623d7054b5253f1032f02230
> src/test/python/apache/aurora/client/docker/BUILD f0cf97157c9d8b145297d164c610bf020b3e9cd1
> src/test/python/apache/aurora/client/hooks/BUILD bbbeb2fb2277e0c28d67b461a5c589e6c68d9779
> src/test/python/apache/aurora/common/BUILD a65a959c0c472a8af2c9c7a0daf59fc85cb0cbc8
> src/test/python/apache/aurora/common/health_check/BUILD 72719f290b3e31bdba5002a8cba7039e236903c9
> src/test/python/apache/aurora/config/BUILD f8e83cea9dc2b093e8af0efa2d94ffb94b3d2d95
> src/test/python/apache/aurora/executor/BUILD 38ddb143dd6a755deebd8db820bf7b4ae3ba341a
> src/test/python/apache/aurora/executor/bin/BUILD b8a063580ec1b08df7008a351e02546e2d89c68e
> src/test/python/apache/aurora/executor/common/BUILD e337ebdc82e70a7fd6ceb8d990b42445cc8d415e
> src/test/python/apache/aurora/tools/BUILD a64b3603056ebee5bc5bbd081f03a131c4f35a58
> src/test/python/apache/thermos/cli/BUILD 0ad1306f23dafeb0281f9f8ce484f589f201dee0
> src/test/python/apache/thermos/cli/commands/BUILD 0ad1306f23dafeb0281f9f8ce484f589f201dee0
> src/test/python/apache/thermos/common/BUILD 08b008e177ad0a63e35f8ea7cf092fd3bb93533c
> src/test/python/apache/thermos/config/BUILD 904453884d22d341cb76c20670d641440c4c4c4c
> src/test/python/apache/thermos/core/BUILD fd2e1527c94462d952752d5a69ac17f46f3221ac
> src/test/python/apache/thermos/monitoring/BUILD cf7c5f07fd51143d2d56bcc5b7f0c13dc4029c2f
> src/test/python/apache/thermos/observer/BUILD 1300e61597545f322de296fa91f2d9e1ab4b3bf1
> src/test/python/apache/thermos/observer/http/BUILD 1300e61597545f322de296fa91f2d9e1ab4b3bf1
>
> Diff: https://reviews.apache.org/r/54520/diff/
>
>
> Testing
> -------
>
> Now with files listed and python tests run:
> ```
> ./pants filemap src/test/python/::
> ./build-support/jenkins/build.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 54520: Revert BUILD changes in 0c177058.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54520/
-----------------------------------------------------------
(Updated Dec. 7, 2016, 9:51 p.m.)
Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
Bugs: AURORA-1853
https://issues.apache.org/jira/browse/AURORA-1853
Repository: aurora
Description
-------
The changes caused `python_tests` target to lose their sources which in
turn caused tests not to run.
src/main/python/apache/aurora/admin/BUILD | 1 +
src/main/python/apache/aurora/client/BUILD | 1 +
src/main/python/apache/aurora/common/BUILD | 1 +
src/main/python/apache/aurora/config/BUILD | 1 +
src/main/python/apache/aurora/executor/BUILD | 1 +
src/main/python/apache/aurora/kerberos/BUILD | 1 +
src/main/python/apache/aurora/tools/BUILD | 1 +
src/main/python/apache/thermos/cli/BUILD | 1 +
src/main/python/apache/thermos/common/BUILD | 1 +
src/main/python/apache/thermos/config/BUILD | 1 +
src/main/python/apache/thermos/core/BUILD | 1 +
src/main/python/apache/thermos/monitoring/BUILD | 1 +
src/main/python/apache/thermos/observer/BUILD | 1 +
src/main/python/apache/thermos/runner/BUILD | 1 +
src/main/python/apache/thermos/testing/BUILD | 1 +
src/test/python/apache/aurora/BUILD | 1 +
src/test/python/apache/aurora/admin/BUILD | 2 ++
src/test/python/apache/aurora/client/BUILD | 2 ++
src/test/python/apache/aurora/client/api/BUILD | 2 ++
src/test/python/apache/aurora/client/cli/BUILD | 2 ++
src/test/python/apache/aurora/client/docker/BUILD | 2 ++
src/test/python/apache/aurora/client/hooks/BUILD | 3 ++-
src/test/python/apache/aurora/common/BUILD | 2 ++
src/test/python/apache/aurora/common/health_check/BUILD | 2 ++
src/test/python/apache/aurora/config/BUILD | 2 ++
src/test/python/apache/aurora/executor/BUILD | 2 ++
src/test/python/apache/aurora/executor/bin/BUILD | 2 ++
src/test/python/apache/aurora/executor/common/BUILD | 2 ++
src/test/python/apache/aurora/tools/BUILD | 2 ++
src/test/python/apache/thermos/cli/BUILD | 2 ++
src/test/python/apache/thermos/cli/commands/BUILD | 2 ++
src/test/python/apache/thermos/common/BUILD | 2 ++
src/test/python/apache/thermos/config/BUILD | 2 ++
src/test/python/apache/thermos/core/BUILD | 2 ++
src/test/python/apache/thermos/monitoring/BUILD | 2 ++
src/test/python/apache/thermos/observer/BUILD | 2 ++
src/test/python/apache/thermos/observer/http/BUILD | 2 ++
37 files changed, 58 insertions(+), 1 deletion(-)
Diffs
-----
src/main/python/apache/aurora/admin/BUILD 60bfbeda8369db71099a2056c509ea1f34eadaa6
src/main/python/apache/aurora/client/BUILD 452efd45beeb61042b24cf116690221eb95d02ca
src/main/python/apache/aurora/common/BUILD 85b5b45a099556a21d090e180645f0c680d62db3
src/main/python/apache/aurora/config/BUILD 14364ef77eeaa9fe5cd8df731c7047ba18beb361
src/main/python/apache/aurora/executor/BUILD bb6d4a3e21075ee4d56615e083059d7cae2e3e99
src/main/python/apache/aurora/kerberos/BUILD d1e6ded02ad8f71e56659fa4455dbbe14b965249
src/main/python/apache/aurora/tools/BUILD c970bec2c64226b22b624f39d21b2cedcaf4d60d
src/main/python/apache/thermos/cli/BUILD 784b05c6811a86589a5a1a64bc3d15302bb22479
src/main/python/apache/thermos/common/BUILD 023b87ff4ac28c58914a1a8d3943fb0554b1a259
src/main/python/apache/thermos/config/BUILD 729c6533d3e059c0e65bb69da3af464f1dd9d49f
src/main/python/apache/thermos/core/BUILD e800ccabfb780e8962686434f18caba522f6516b
src/main/python/apache/thermos/monitoring/BUILD a1c16ac782da3df78b325f5273f76c47a6a1febf
src/main/python/apache/thermos/observer/BUILD 714955d91e97fefc30841a2dd975f63962a444df
src/main/python/apache/thermos/runner/BUILD d51587842deeadfc316072b6c7fe4a584412db0a
src/main/python/apache/thermos/testing/BUILD 0964a7ddcb6558b6e685b3fa710f25b5862c72f1
src/test/python/apache/aurora/BUILD 48ea328c51fb41e1de65673d95e0416ecd1af9c8
src/test/python/apache/aurora/admin/BUILD 8dd8b6d71a5b9e2ddd44d93843853e4271402573
src/test/python/apache/aurora/client/BUILD 2347d226c8f22009d9a2170ea554d7512a47e2ff
src/test/python/apache/aurora/client/api/BUILD 8394d4e717c6ecb6ddb19dc4f67d039347d4ba8f
src/test/python/apache/aurora/client/cli/BUILD bd74d64f9b19c77f623d7054b5253f1032f02230
src/test/python/apache/aurora/client/docker/BUILD f0cf97157c9d8b145297d164c610bf020b3e9cd1
src/test/python/apache/aurora/client/hooks/BUILD bbbeb2fb2277e0c28d67b461a5c589e6c68d9779
src/test/python/apache/aurora/common/BUILD a65a959c0c472a8af2c9c7a0daf59fc85cb0cbc8
src/test/python/apache/aurora/common/health_check/BUILD 72719f290b3e31bdba5002a8cba7039e236903c9
src/test/python/apache/aurora/config/BUILD f8e83cea9dc2b093e8af0efa2d94ffb94b3d2d95
src/test/python/apache/aurora/executor/BUILD 38ddb143dd6a755deebd8db820bf7b4ae3ba341a
src/test/python/apache/aurora/executor/bin/BUILD b8a063580ec1b08df7008a351e02546e2d89c68e
src/test/python/apache/aurora/executor/common/BUILD e337ebdc82e70a7fd6ceb8d990b42445cc8d415e
src/test/python/apache/aurora/tools/BUILD a64b3603056ebee5bc5bbd081f03a131c4f35a58
src/test/python/apache/thermos/cli/BUILD 0ad1306f23dafeb0281f9f8ce484f589f201dee0
src/test/python/apache/thermos/cli/commands/BUILD 0ad1306f23dafeb0281f9f8ce484f589f201dee0
src/test/python/apache/thermos/common/BUILD 08b008e177ad0a63e35f8ea7cf092fd3bb93533c
src/test/python/apache/thermos/config/BUILD 904453884d22d341cb76c20670d641440c4c4c4c
src/test/python/apache/thermos/core/BUILD fd2e1527c94462d952752d5a69ac17f46f3221ac
src/test/python/apache/thermos/monitoring/BUILD cf7c5f07fd51143d2d56bcc5b7f0c13dc4029c2f
src/test/python/apache/thermos/observer/BUILD 1300e61597545f322de296fa91f2d9e1ab4b3bf1
src/test/python/apache/thermos/observer/http/BUILD 1300e61597545f322de296fa91f2d9e1ab4b3bf1
Diff: https://reviews.apache.org/r/54520/diff/
Testing
-------
Now with files listed and python tests run:
```
./pants filemap src/test/python/::
./build-support/jenkins/build.sh
```
Thanks,
John Sirois
Re: Review Request 54520: Revert BUILD changes in 0c177058.
Posted by John Sirois <js...@apache.org>.
> On Dec. 7, 2016, 9:41 p.m., John Sirois wrote:
> > NB: When AuroraBot goes green I'll submit this TBR and file a follow-up issue in Aurora and a corresponding one in pants if needed, to restore the BUILD file changes for default targets and default globs.
Also note this was a mechanical change achieved with:
```
$ git co 0c1770581317d693f3b388c067d2ddd1dcc2b867^ -- src/{main,test}/python/
$ git reset HEAD \
src/main/python/apache/aurora/executor/aurora_executor.py \
src/main/python/apache/aurora/executor/common/health_checker.py \
src/test/python/apache/aurora/executor/common/test_health_checker.py
$ git co -- \
src/main/python/apache/aurora/executor/aurora_executor.py \
src/main/python/apache/aurora/executor/common/health_checker.py \
src/test/python/apache/aurora/executor/common/test_health_checker.py
```
The `git reset HEAD ... && git co -- ...` preserved Santhosh's changes in [d05ea2bc](https://github.com/apache/aurora/commit/d05ea2bcc4af20af0b5e0a7f3995d02ff25a1626)
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54520/#review158496
-----------------------------------------------------------
On Dec. 7, 2016, 9:39 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54520/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2016, 9:39 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The changes caused `python_tests` target to lose their sources which in
> turn caused tests not to run.
>
> src/main/python/apache/aurora/admin/BUILD | 1 +
> src/main/python/apache/aurora/client/BUILD | 1 +
> src/main/python/apache/aurora/common/BUILD | 1 +
> src/main/python/apache/aurora/config/BUILD | 1 +
> src/main/python/apache/aurora/executor/BUILD | 1 +
> src/main/python/apache/aurora/kerberos/BUILD | 1 +
> src/main/python/apache/aurora/tools/BUILD | 1 +
> src/main/python/apache/thermos/cli/BUILD | 1 +
> src/main/python/apache/thermos/common/BUILD | 1 +
> src/main/python/apache/thermos/config/BUILD | 1 +
> src/main/python/apache/thermos/core/BUILD | 1 +
> src/main/python/apache/thermos/monitoring/BUILD | 1 +
> src/main/python/apache/thermos/observer/BUILD | 1 +
> src/main/python/apache/thermos/runner/BUILD | 1 +
> src/main/python/apache/thermos/testing/BUILD | 1 +
> src/test/python/apache/aurora/BUILD | 1 +
> src/test/python/apache/aurora/admin/BUILD | 2 ++
> src/test/python/apache/aurora/client/BUILD | 2 ++
> src/test/python/apache/aurora/client/api/BUILD | 2 ++
> src/test/python/apache/aurora/client/cli/BUILD | 2 ++
> src/test/python/apache/aurora/client/docker/BUILD | 2 ++
> src/test/python/apache/aurora/client/hooks/BUILD | 3 ++-
> src/test/python/apache/aurora/common/BUILD | 2 ++
> src/test/python/apache/aurora/common/health_check/BUILD | 2 ++
> src/test/python/apache/aurora/config/BUILD | 2 ++
> src/test/python/apache/aurora/executor/BUILD | 2 ++
> src/test/python/apache/aurora/executor/bin/BUILD | 2 ++
> src/test/python/apache/aurora/executor/common/BUILD | 2 ++
> src/test/python/apache/aurora/tools/BUILD | 2 ++
> src/test/python/apache/thermos/cli/BUILD | 2 ++
> src/test/python/apache/thermos/cli/commands/BUILD | 2 ++
> src/test/python/apache/thermos/common/BUILD | 2 ++
> src/test/python/apache/thermos/config/BUILD | 2 ++
> src/test/python/apache/thermos/core/BUILD | 2 ++
> src/test/python/apache/thermos/monitoring/BUILD | 2 ++
> src/test/python/apache/thermos/observer/BUILD | 2 ++
> src/test/python/apache/thermos/observer/http/BUILD | 2 ++
> 37 files changed, 58 insertions(+), 1 deletion(-)
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 60bfbeda8369db71099a2056c509ea1f34eadaa6
> src/main/python/apache/aurora/client/BUILD 452efd45beeb61042b24cf116690221eb95d02ca
> src/main/python/apache/aurora/common/BUILD 85b5b45a099556a21d090e180645f0c680d62db3
> src/main/python/apache/aurora/config/BUILD 14364ef77eeaa9fe5cd8df731c7047ba18beb361
> src/main/python/apache/aurora/executor/BUILD bb6d4a3e21075ee4d56615e083059d7cae2e3e99
> src/main/python/apache/aurora/kerberos/BUILD d1e6ded02ad8f71e56659fa4455dbbe14b965249
> src/main/python/apache/aurora/tools/BUILD c970bec2c64226b22b624f39d21b2cedcaf4d60d
> src/main/python/apache/thermos/cli/BUILD 784b05c6811a86589a5a1a64bc3d15302bb22479
> src/main/python/apache/thermos/common/BUILD 023b87ff4ac28c58914a1a8d3943fb0554b1a259
> src/main/python/apache/thermos/config/BUILD 729c6533d3e059c0e65bb69da3af464f1dd9d49f
> src/main/python/apache/thermos/core/BUILD e800ccabfb780e8962686434f18caba522f6516b
> src/main/python/apache/thermos/monitoring/BUILD a1c16ac782da3df78b325f5273f76c47a6a1febf
> src/main/python/apache/thermos/observer/BUILD 714955d91e97fefc30841a2dd975f63962a444df
> src/main/python/apache/thermos/runner/BUILD d51587842deeadfc316072b6c7fe4a584412db0a
> src/main/python/apache/thermos/testing/BUILD 0964a7ddcb6558b6e685b3fa710f25b5862c72f1
> src/test/python/apache/aurora/BUILD 48ea328c51fb41e1de65673d95e0416ecd1af9c8
> src/test/python/apache/aurora/admin/BUILD 8dd8b6d71a5b9e2ddd44d93843853e4271402573
> src/test/python/apache/aurora/client/BUILD 2347d226c8f22009d9a2170ea554d7512a47e2ff
> src/test/python/apache/aurora/client/api/BUILD 8394d4e717c6ecb6ddb19dc4f67d039347d4ba8f
> src/test/python/apache/aurora/client/cli/BUILD bd74d64f9b19c77f623d7054b5253f1032f02230
> src/test/python/apache/aurora/client/docker/BUILD f0cf97157c9d8b145297d164c610bf020b3e9cd1
> src/test/python/apache/aurora/client/hooks/BUILD bbbeb2fb2277e0c28d67b461a5c589e6c68d9779
> src/test/python/apache/aurora/common/BUILD a65a959c0c472a8af2c9c7a0daf59fc85cb0cbc8
> src/test/python/apache/aurora/common/health_check/BUILD 72719f290b3e31bdba5002a8cba7039e236903c9
> src/test/python/apache/aurora/config/BUILD f8e83cea9dc2b093e8af0efa2d94ffb94b3d2d95
> src/test/python/apache/aurora/executor/BUILD 38ddb143dd6a755deebd8db820bf7b4ae3ba341a
> src/test/python/apache/aurora/executor/bin/BUILD b8a063580ec1b08df7008a351e02546e2d89c68e
> src/test/python/apache/aurora/executor/common/BUILD e337ebdc82e70a7fd6ceb8d990b42445cc8d415e
> src/test/python/apache/aurora/tools/BUILD a64b3603056ebee5bc5bbd081f03a131c4f35a58
> src/test/python/apache/thermos/cli/BUILD 0ad1306f23dafeb0281f9f8ce484f589f201dee0
> src/test/python/apache/thermos/cli/commands/BUILD 0ad1306f23dafeb0281f9f8ce484f589f201dee0
> src/test/python/apache/thermos/common/BUILD 08b008e177ad0a63e35f8ea7cf092fd3bb93533c
> src/test/python/apache/thermos/config/BUILD 904453884d22d341cb76c20670d641440c4c4c4c
> src/test/python/apache/thermos/core/BUILD fd2e1527c94462d952752d5a69ac17f46f3221ac
> src/test/python/apache/thermos/monitoring/BUILD cf7c5f07fd51143d2d56bcc5b7f0c13dc4029c2f
> src/test/python/apache/thermos/observer/BUILD 1300e61597545f322de296fa91f2d9e1ab4b3bf1
> src/test/python/apache/thermos/observer/http/BUILD 1300e61597545f322de296fa91f2d9e1ab4b3bf1
>
> Diff: https://reviews.apache.org/r/54520/diff/
>
>
> Testing
> -------
>
> Now with files listed and python tests run:
> ```
> ./pants filemap src/test/python/::
> ./build-support/jenkins/build.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 54520: Revert BUILD changes in 0c177058.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54520/#review158496
-----------------------------------------------------------
NB: When AuroraBot goes green I'll submit this TBR and file a follow-up issue in Aurora and a corresponding one in pants if needed, to restore the BUILD file changes for default targets and default globs.
- John Sirois
On Dec. 7, 2016, 9:39 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54520/
> -----------------------------------------------------------
>
> (Updated Dec. 7, 2016, 9:39 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The changes caused `python_tests` target to lose their sources which in
> turn caused tests not to run.
>
> src/main/python/apache/aurora/admin/BUILD | 1 +
> src/main/python/apache/aurora/client/BUILD | 1 +
> src/main/python/apache/aurora/common/BUILD | 1 +
> src/main/python/apache/aurora/config/BUILD | 1 +
> src/main/python/apache/aurora/executor/BUILD | 1 +
> src/main/python/apache/aurora/kerberos/BUILD | 1 +
> src/main/python/apache/aurora/tools/BUILD | 1 +
> src/main/python/apache/thermos/cli/BUILD | 1 +
> src/main/python/apache/thermos/common/BUILD | 1 +
> src/main/python/apache/thermos/config/BUILD | 1 +
> src/main/python/apache/thermos/core/BUILD | 1 +
> src/main/python/apache/thermos/monitoring/BUILD | 1 +
> src/main/python/apache/thermos/observer/BUILD | 1 +
> src/main/python/apache/thermos/runner/BUILD | 1 +
> src/main/python/apache/thermos/testing/BUILD | 1 +
> src/test/python/apache/aurora/BUILD | 1 +
> src/test/python/apache/aurora/admin/BUILD | 2 ++
> src/test/python/apache/aurora/client/BUILD | 2 ++
> src/test/python/apache/aurora/client/api/BUILD | 2 ++
> src/test/python/apache/aurora/client/cli/BUILD | 2 ++
> src/test/python/apache/aurora/client/docker/BUILD | 2 ++
> src/test/python/apache/aurora/client/hooks/BUILD | 3 ++-
> src/test/python/apache/aurora/common/BUILD | 2 ++
> src/test/python/apache/aurora/common/health_check/BUILD | 2 ++
> src/test/python/apache/aurora/config/BUILD | 2 ++
> src/test/python/apache/aurora/executor/BUILD | 2 ++
> src/test/python/apache/aurora/executor/bin/BUILD | 2 ++
> src/test/python/apache/aurora/executor/common/BUILD | 2 ++
> src/test/python/apache/aurora/tools/BUILD | 2 ++
> src/test/python/apache/thermos/cli/BUILD | 2 ++
> src/test/python/apache/thermos/cli/commands/BUILD | 2 ++
> src/test/python/apache/thermos/common/BUILD | 2 ++
> src/test/python/apache/thermos/config/BUILD | 2 ++
> src/test/python/apache/thermos/core/BUILD | 2 ++
> src/test/python/apache/thermos/monitoring/BUILD | 2 ++
> src/test/python/apache/thermos/observer/BUILD | 2 ++
> src/test/python/apache/thermos/observer/http/BUILD | 2 ++
> 37 files changed, 58 insertions(+), 1 deletion(-)
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 60bfbeda8369db71099a2056c509ea1f34eadaa6
> src/main/python/apache/aurora/client/BUILD 452efd45beeb61042b24cf116690221eb95d02ca
> src/main/python/apache/aurora/common/BUILD 85b5b45a099556a21d090e180645f0c680d62db3
> src/main/python/apache/aurora/config/BUILD 14364ef77eeaa9fe5cd8df731c7047ba18beb361
> src/main/python/apache/aurora/executor/BUILD bb6d4a3e21075ee4d56615e083059d7cae2e3e99
> src/main/python/apache/aurora/kerberos/BUILD d1e6ded02ad8f71e56659fa4455dbbe14b965249
> src/main/python/apache/aurora/tools/BUILD c970bec2c64226b22b624f39d21b2cedcaf4d60d
> src/main/python/apache/thermos/cli/BUILD 784b05c6811a86589a5a1a64bc3d15302bb22479
> src/main/python/apache/thermos/common/BUILD 023b87ff4ac28c58914a1a8d3943fb0554b1a259
> src/main/python/apache/thermos/config/BUILD 729c6533d3e059c0e65bb69da3af464f1dd9d49f
> src/main/python/apache/thermos/core/BUILD e800ccabfb780e8962686434f18caba522f6516b
> src/main/python/apache/thermos/monitoring/BUILD a1c16ac782da3df78b325f5273f76c47a6a1febf
> src/main/python/apache/thermos/observer/BUILD 714955d91e97fefc30841a2dd975f63962a444df
> src/main/python/apache/thermos/runner/BUILD d51587842deeadfc316072b6c7fe4a584412db0a
> src/main/python/apache/thermos/testing/BUILD 0964a7ddcb6558b6e685b3fa710f25b5862c72f1
> src/test/python/apache/aurora/BUILD 48ea328c51fb41e1de65673d95e0416ecd1af9c8
> src/test/python/apache/aurora/admin/BUILD 8dd8b6d71a5b9e2ddd44d93843853e4271402573
> src/test/python/apache/aurora/client/BUILD 2347d226c8f22009d9a2170ea554d7512a47e2ff
> src/test/python/apache/aurora/client/api/BUILD 8394d4e717c6ecb6ddb19dc4f67d039347d4ba8f
> src/test/python/apache/aurora/client/cli/BUILD bd74d64f9b19c77f623d7054b5253f1032f02230
> src/test/python/apache/aurora/client/docker/BUILD f0cf97157c9d8b145297d164c610bf020b3e9cd1
> src/test/python/apache/aurora/client/hooks/BUILD bbbeb2fb2277e0c28d67b461a5c589e6c68d9779
> src/test/python/apache/aurora/common/BUILD a65a959c0c472a8af2c9c7a0daf59fc85cb0cbc8
> src/test/python/apache/aurora/common/health_check/BUILD 72719f290b3e31bdba5002a8cba7039e236903c9
> src/test/python/apache/aurora/config/BUILD f8e83cea9dc2b093e8af0efa2d94ffb94b3d2d95
> src/test/python/apache/aurora/executor/BUILD 38ddb143dd6a755deebd8db820bf7b4ae3ba341a
> src/test/python/apache/aurora/executor/bin/BUILD b8a063580ec1b08df7008a351e02546e2d89c68e
> src/test/python/apache/aurora/executor/common/BUILD e337ebdc82e70a7fd6ceb8d990b42445cc8d415e
> src/test/python/apache/aurora/tools/BUILD a64b3603056ebee5bc5bbd081f03a131c4f35a58
> src/test/python/apache/thermos/cli/BUILD 0ad1306f23dafeb0281f9f8ce484f589f201dee0
> src/test/python/apache/thermos/cli/commands/BUILD 0ad1306f23dafeb0281f9f8ce484f589f201dee0
> src/test/python/apache/thermos/common/BUILD 08b008e177ad0a63e35f8ea7cf092fd3bb93533c
> src/test/python/apache/thermos/config/BUILD 904453884d22d341cb76c20670d641440c4c4c4c
> src/test/python/apache/thermos/core/BUILD fd2e1527c94462d952752d5a69ac17f46f3221ac
> src/test/python/apache/thermos/monitoring/BUILD cf7c5f07fd51143d2d56bcc5b7f0c13dc4029c2f
> src/test/python/apache/thermos/observer/BUILD 1300e61597545f322de296fa91f2d9e1ab4b3bf1
> src/test/python/apache/thermos/observer/http/BUILD 1300e61597545f322de296fa91f2d9e1ab4b3bf1
>
> Diff: https://reviews.apache.org/r/54520/diff/
>
>
> Testing
> -------
>
> Now with files listed and python tests run:
> ```
> ./pants filemap src/test/python/::
> ./build-support/jenkins/build.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 54520: Revert BUILD changes in 0c177058.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54520/#review158497
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Dec. 8, 2016, 4:39 a.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54520/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2016, 4:39 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The changes caused `python_tests` target to lose their sources which in
> turn caused tests not to run.
>
> src/main/python/apache/aurora/admin/BUILD | 1 +
> src/main/python/apache/aurora/client/BUILD | 1 +
> src/main/python/apache/aurora/common/BUILD | 1 +
> src/main/python/apache/aurora/config/BUILD | 1 +
> src/main/python/apache/aurora/executor/BUILD | 1 +
> src/main/python/apache/aurora/kerberos/BUILD | 1 +
> src/main/python/apache/aurora/tools/BUILD | 1 +
> src/main/python/apache/thermos/cli/BUILD | 1 +
> src/main/python/apache/thermos/common/BUILD | 1 +
> src/main/python/apache/thermos/config/BUILD | 1 +
> src/main/python/apache/thermos/core/BUILD | 1 +
> src/main/python/apache/thermos/monitoring/BUILD | 1 +
> src/main/python/apache/thermos/observer/BUILD | 1 +
> src/main/python/apache/thermos/runner/BUILD | 1 +
> src/main/python/apache/thermos/testing/BUILD | 1 +
> src/test/python/apache/aurora/BUILD | 1 +
> src/test/python/apache/aurora/admin/BUILD | 2 ++
> src/test/python/apache/aurora/client/BUILD | 2 ++
> src/test/python/apache/aurora/client/api/BUILD | 2 ++
> src/test/python/apache/aurora/client/cli/BUILD | 2 ++
> src/test/python/apache/aurora/client/docker/BUILD | 2 ++
> src/test/python/apache/aurora/client/hooks/BUILD | 3 ++-
> src/test/python/apache/aurora/common/BUILD | 2 ++
> src/test/python/apache/aurora/common/health_check/BUILD | 2 ++
> src/test/python/apache/aurora/config/BUILD | 2 ++
> src/test/python/apache/aurora/executor/BUILD | 2 ++
> src/test/python/apache/aurora/executor/bin/BUILD | 2 ++
> src/test/python/apache/aurora/executor/common/BUILD | 2 ++
> src/test/python/apache/aurora/tools/BUILD | 2 ++
> src/test/python/apache/thermos/cli/BUILD | 2 ++
> src/test/python/apache/thermos/cli/commands/BUILD | 2 ++
> src/test/python/apache/thermos/common/BUILD | 2 ++
> src/test/python/apache/thermos/config/BUILD | 2 ++
> src/test/python/apache/thermos/core/BUILD | 2 ++
> src/test/python/apache/thermos/monitoring/BUILD | 2 ++
> src/test/python/apache/thermos/observer/BUILD | 2 ++
> src/test/python/apache/thermos/observer/http/BUILD | 2 ++
> 37 files changed, 58 insertions(+), 1 deletion(-)
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/BUILD 60bfbeda8369db71099a2056c509ea1f34eadaa6
> src/main/python/apache/aurora/client/BUILD 452efd45beeb61042b24cf116690221eb95d02ca
> src/main/python/apache/aurora/common/BUILD 85b5b45a099556a21d090e180645f0c680d62db3
> src/main/python/apache/aurora/config/BUILD 14364ef77eeaa9fe5cd8df731c7047ba18beb361
> src/main/python/apache/aurora/executor/BUILD bb6d4a3e21075ee4d56615e083059d7cae2e3e99
> src/main/python/apache/aurora/kerberos/BUILD d1e6ded02ad8f71e56659fa4455dbbe14b965249
> src/main/python/apache/aurora/tools/BUILD c970bec2c64226b22b624f39d21b2cedcaf4d60d
> src/main/python/apache/thermos/cli/BUILD 784b05c6811a86589a5a1a64bc3d15302bb22479
> src/main/python/apache/thermos/common/BUILD 023b87ff4ac28c58914a1a8d3943fb0554b1a259
> src/main/python/apache/thermos/config/BUILD 729c6533d3e059c0e65bb69da3af464f1dd9d49f
> src/main/python/apache/thermos/core/BUILD e800ccabfb780e8962686434f18caba522f6516b
> src/main/python/apache/thermos/monitoring/BUILD a1c16ac782da3df78b325f5273f76c47a6a1febf
> src/main/python/apache/thermos/observer/BUILD 714955d91e97fefc30841a2dd975f63962a444df
> src/main/python/apache/thermos/runner/BUILD d51587842deeadfc316072b6c7fe4a584412db0a
> src/main/python/apache/thermos/testing/BUILD 0964a7ddcb6558b6e685b3fa710f25b5862c72f1
> src/test/python/apache/aurora/BUILD 48ea328c51fb41e1de65673d95e0416ecd1af9c8
> src/test/python/apache/aurora/admin/BUILD 8dd8b6d71a5b9e2ddd44d93843853e4271402573
> src/test/python/apache/aurora/client/BUILD 2347d226c8f22009d9a2170ea554d7512a47e2ff
> src/test/python/apache/aurora/client/api/BUILD 8394d4e717c6ecb6ddb19dc4f67d039347d4ba8f
> src/test/python/apache/aurora/client/cli/BUILD bd74d64f9b19c77f623d7054b5253f1032f02230
> src/test/python/apache/aurora/client/docker/BUILD f0cf97157c9d8b145297d164c610bf020b3e9cd1
> src/test/python/apache/aurora/client/hooks/BUILD bbbeb2fb2277e0c28d67b461a5c589e6c68d9779
> src/test/python/apache/aurora/common/BUILD a65a959c0c472a8af2c9c7a0daf59fc85cb0cbc8
> src/test/python/apache/aurora/common/health_check/BUILD 72719f290b3e31bdba5002a8cba7039e236903c9
> src/test/python/apache/aurora/config/BUILD f8e83cea9dc2b093e8af0efa2d94ffb94b3d2d95
> src/test/python/apache/aurora/executor/BUILD 38ddb143dd6a755deebd8db820bf7b4ae3ba341a
> src/test/python/apache/aurora/executor/bin/BUILD b8a063580ec1b08df7008a351e02546e2d89c68e
> src/test/python/apache/aurora/executor/common/BUILD e337ebdc82e70a7fd6ceb8d990b42445cc8d415e
> src/test/python/apache/aurora/tools/BUILD a64b3603056ebee5bc5bbd081f03a131c4f35a58
> src/test/python/apache/thermos/cli/BUILD 0ad1306f23dafeb0281f9f8ce484f589f201dee0
> src/test/python/apache/thermos/cli/commands/BUILD 0ad1306f23dafeb0281f9f8ce484f589f201dee0
> src/test/python/apache/thermos/common/BUILD 08b008e177ad0a63e35f8ea7cf092fd3bb93533c
> src/test/python/apache/thermos/config/BUILD 904453884d22d341cb76c20670d641440c4c4c4c
> src/test/python/apache/thermos/core/BUILD fd2e1527c94462d952752d5a69ac17f46f3221ac
> src/test/python/apache/thermos/monitoring/BUILD cf7c5f07fd51143d2d56bcc5b7f0c13dc4029c2f
> src/test/python/apache/thermos/observer/BUILD 1300e61597545f322de296fa91f2d9e1ab4b3bf1
> src/test/python/apache/thermos/observer/http/BUILD 1300e61597545f322de296fa91f2d9e1ab4b3bf1
>
> Diff: https://reviews.apache.org/r/54520/diff/
>
>
> Testing
> -------
>
> Now with files listed and python tests run:
> ```
> ./pants filemap src/test/python/::
> ./build-support/jenkins/build.sh
> ```
>
>
> Thanks,
>
> John Sirois
>
>