You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Ádám Bakai (Code Review)" <ge...@cloudera.org> on 2024/01/03 16:55:17 UTC
[kudu-CR] [WIP] Increase AssertEventually timeout to 60 seconds
Ádám Bakai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20846
Change subject: [WIP] Increase AssertEventually timeout to 60 seconds
......................................................................
[WIP] Increase AssertEventually timeout to 60 seconds
AssertEventually sometimes failed on dist-test, but worked well on local
development environment. After Checking the code thoroughly, it looked
like the code worked fine, it failed because of slow execution. So
AssertEventually timeout is increased to 60 seconds to avoid these kind
of failed tests in the future.
Change-Id: I84349435a0c9b3efeb4fc37b5f7fab4a0f505a1c
---
M src/kudu/util/test_util.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/20846/1
--
To view, visit http://gerrit.cloudera.org:8080/20846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84349435a0c9b3efeb4fc37b5f7fab4a0f505a1c
Gerrit-Change-Number: 20846
Gerrit-PatchSet: 1
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
[kudu-CR] [WIP] Increase AssertEventually timeout to 60 seconds
Posted by "Ádám Bakai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20846
to look at the new patch set (#3).
Change subject: [WIP] Increase AssertEventually timeout to 60 seconds
......................................................................
[WIP] Increase AssertEventually timeout to 60 seconds
AssertEventually sometimes failed on dist-test, but worked well on local
development environment. After Checking the code thoroughly, it looked
like the code worked fine, it failed because of slow execution. So
AssertEventually timeout is increased to 60 seconds to avoid these kind
of failed tests in the future.
Change-Id: I84349435a0c9b3efeb4fc37b5f7fab4a0f505a1c
---
M src/kudu/util/test_util.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/20846/3
--
To view, visit http://gerrit.cloudera.org:8080/20846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84349435a0c9b3efeb4fc37b5f7fab4a0f505a1c
Gerrit-Change-Number: 20846
Gerrit-PatchSet: 3
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [WIP] Increase AssertEventually timeout to 60 seconds
Posted by "Ádám Bakai (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20846
to look at the new patch set (#2).
Change subject: [WIP] Increase AssertEventually timeout to 60 seconds
......................................................................
[WIP] Increase AssertEventually timeout to 60 seconds
AssertEventually sometimes failed on dist-test, but worked well on local
development environment. After Checking the code thoroughly, it looked
like the code worked fine, it failed because of slow execution. So
AssertEventually timeout is increased to 60 seconds to avoid these kind
of failed tests in the future.
Change-Id: I84349435a0c9b3efeb4fc37b5f7fab4a0f505a1c
---
M src/kudu/util/test_util.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/20846/2
--
To view, visit http://gerrit.cloudera.org:8080/20846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84349435a0c9b3efeb4fc37b5f7fab4a0f505a1c
Gerrit-Change-Number: 20846
Gerrit-PatchSet: 2
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [WIP] Increase AssertEventually timeout to 60 seconds
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20846 )
Change subject: [WIP] Increase AssertEventually timeout to 60 seconds
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/20846/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20846/3//COMMIT_MSG@10
PS3, Line 10: After Checking the code thoroughly, it looked
: like the code worked fine, it failed because of slow execution.
Could you be more specific here, in particular:
* what exact tests failed because of this
* what was the build configurations for the binaries (DEBUG/RELEASE/ASAN/TSAN) that used to run the failing tests
http://gerrit.cloudera.org:8080/#/c/20846/3//COMMIT_MSG@12
PS3, Line 12: AssertEventually timeout is increased to 60 seconds
I'm not sure that's a good resolution for the issue. For the majority of the cases in our current test set, 30 seconds is more than enough: I'd rather try to understand what exact tests are timing out. Most likely, 30 seconds isn't enough either because of a bug/flakiness or running the test under TSAN. I'd rather update the timeout for particular instances of AssertEventually usage, not this sort of blanket change.
--
To view, visit http://gerrit.cloudera.org:8080/20846
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84349435a0c9b3efeb4fc37b5f7fab4a0f505a1c
Gerrit-Change-Number: 20846
Gerrit-PatchSet: 3
Gerrit-Owner: Ádám Bakai <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 04 Jan 2024 17:09:53 +0000
Gerrit-HasComments: Yes