[GitHub] [flink] liyafan82 commented on a change in pull request #8854: [FLINK-12959][table-planner-blink] Use BoundedInput and InputSelectable in blink and implement hash join

[GitBox <gi...@apache.org>]

liyafan82 commented on a change in pull request #8854: [FLINK-12959][table-planner-blink] Use BoundedInput and InputSelectable in blink and implement hash join
URL: https://github.com/apache/flink/pull/8854#discussion_r299301202
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/physical/batch/BatchExecExchange.scala
 ##########
 @@ -163,37 +163,45 @@ class BatchExecExchange(
     val inputType = input.getOutputType.asInstanceOf[BaseRowTypeInfo]
     val outputRowType = BaseRowTypeInfo.of(FlinkTypeFactory.toLogicalRowType(getRowType))
 
-    // TODO supports DataExchangeMode.BATCH in runtime
-    if (requiredExchangeMode.contains(DataExchangeMode.BATCH)) {
-      throw new TableException("DataExchangeMode.BATCH is not supported now")
+    val shuffleMode = requiredExchangeMode match {
+      case None => ShuffleMode.PIPELINED
+      case Some(mode) =>
+        mode match {
+          case DataExchangeMode.BATCH => ShuffleMode.BATCH
+          case DataExchangeMode.PIPELINED => ShuffleMode.PIPELINED
 
 Review comment:
   how about PIPELINE_WITH_BATCH_FALLBACK?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services