You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/07/26 15:18:20 UTC
[GitHub] [fineract] xurror commented on a change in pull request #985: FINERACT-821 Enforced Membername checkstyle(1)
xurror commented on a change in pull request #985:
URL: https://github.com/apache/fineract/pull/985#discussion_r460539551
##########
File path: fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/TemplateIntegrationTest.java
##########
@@ -34,9 +34,9 @@
public class TemplateIntegrationTest {
- private final String GET_TEMPLATES_URL = "/fineract-provider/api/v1/templates?tenantIdentifier=default";
- private final String GET_TEMPLATE_ID_URL = "/fineract-provider/api/v1/templates/%s?tenantIdentifier=default";
- private final String RESPONSE_ATTRIBUTE_NAME = "name";
+ private static final String GET_TEMPLATES_URL = "/fineract-provider/api/v1/templates?tenantIdentifier=default";
+
Review comment:
Why remove this variable?
It was only used once though so I don't mind leaving it as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org