You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/04 14:07:08 UTC

[GitHub] [lucene-solr] jaisonbi commented on pull request #2302: LUCENE-9663: Adding compression to terms dict from SortedSet/Sorted D…

jaisonbi commented on pull request #2302:
URL: https://github.com/apache/lucene-solr/pull/2302#issuecomment-773326313


   @bruno-roustant  I checked all the review comments from #2213, and ensure all the changes included in this PR.  The main items:
   1. Rely ArrayUtil.grow to grow the buffer.
   2. Remove method Lucene80DocValuesConsumer#addCompressedTermsDict, added some compression-conditinal code in Lucene80DocValuesConsumer#addTermsDict. Try to share the same lines across different mode.
   3. Remove "switch" from Lucene80DocValuesConsumer#addSortedSetField and Lucene80DocValuesConsumer#doAddSortedField.
   4. Rename PADDING_LENGTH(from Lucene80DocValuesProducer$TermsDict) to LZ4_DECOMPRESSOR_PADDING, and add comment.
   
   Sorry for the inconvenience:-)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org