You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2015/06/20 02:25:42 UTC
Re: Review Request 34139: AppC image discovery.
> On May 14, 2015, 2:05 p.m., Timothy Chen wrote:
> > src/slave/containerizer/provisioners/appc/discovery.cpp, line 34
> > <https://reviews.apache.org/r/34139/diff/1/?file=957272#file957272line34>
> >
> > static?
This function is only going to be called once anyway though.
- Ian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34139/#review83825
-----------------------------------------------------------
On May 12, 2015, 5:47 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34139/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 5:47 p.m.)
>
>
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Local and simple discovery only.
>
>
> Diffs
> -----
>
> src/Makefile.am 14bc976a7b6a656fb58085484d25c3de3cf0f693
> src/slave/containerizer/provisioners/appc/discovery.hpp PRE-CREATION
> src/slave/containerizer/provisioners/appc/discovery.cpp PRE-CREATION
> src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
> src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
>
> Diff: https://reviews.apache.org/r/34139/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>