You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Daniel Barclay <db...@maprtech.com> on 2015/06/19 21:00:53 UTC
Review Request 35623: DRILL-2494: Have PreparedStmt. set-param.
methods throw "unsupported".
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35623/
-----------------------------------------------------------
Review request for drill, Hanifi Gunes and Mehant Baid.
Bugs: DRILL-2494
https://issues.apache.org/jira/browse/DRILL-2494
Repository: drill-git
Description
-------
Added (integration-level) unit test.
Modified set-parameter methods to throw SQLFeatureNotSupportedException.
(Intercepted common getParameter method.)
Inserted DrillPreparedStatement into hierarchy for place for documentation.
Documented that parameter-setting methods are not supported.
Diffs
-----
exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java PRE-CREATION
exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java 5e9ec93
exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/35623/diff/
Testing
-------
Added specific unit tests.
Ran existing tests; no new failures.
Thanks,
Daniel Barclay
Re: Review Request 35623: DRILL-2494: Have PreparedStmt. set-param.
methods throw "unsupported".
Posted by Hanifi Gunes <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35623/#review89035
-----------------------------------------------------------
Ship it!
Ship It!
- Hanifi Gunes
On June 19, 2015, 7 p.m., Daniel Barclay wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35623/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 7 p.m.)
>
>
> Review request for drill, Hanifi Gunes and Mehant Baid.
>
>
> Bugs: DRILL-2494
> https://issues.apache.org/jira/browse/DRILL-2494
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Added (integration-level) unit test.
>
> Modified set-parameter methods to throw SQLFeatureNotSupportedException.
> (Intercepted common getParameter method.)
>
> Inserted DrillPreparedStatement into hierarchy for place for documentation.
>
> Documented that parameter-setting methods are not supported.
>
>
> Diffs
> -----
>
> exec/jdbc/src/main/java/org/apache/drill/jdbc/DrillPreparedStatement.java PRE-CREATION
> exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillPreparedStatementImpl.java 5e9ec93
> exec/jdbc/src/test/java/org/apache/drill/jdbc/PreparedStatementTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/35623/diff/
>
>
> Testing
> -------
>
> Added specific unit tests.
>
> Ran existing tests; no new failures.
>
>
> Thanks,
>
> Daniel Barclay
>
>