[GitHub] [incubator-nuttx] daniel-p-carvalho commented on a change in pull request #4255: STM32 DAC Driver - Add support to DAC3

[GitBox <gi...@apache.org>]

daniel-p-carvalho commented on a change in pull request #4255:
URL: https://github.com/apache/incubator-nuttx/pull/4255#discussion_r681028532



##########
File path: boards/arm/stm32/nucleo-g431kb/src/stm32_dac.c
##########
@@ -80,6 +84,25 @@ int stm32_dac_setup(void)
       return ret;
     }
 
+#endif
+
+#ifdef CONFIG_STM32_DAC3CH2
+  g_dac5 = stm32_dacinitialize(5);
+  if (g_dac5 == NULL)
+    {
+      aerr("ERROR: Failed to get DAC interface\n");
+      return -ENODEV;
+    }
+
+  /* Register the DAC driver at "/dev/dac0" */
+
+  ret = dac_register("/dev/dac0", g_dac5);

Review comment:
       You are right. I will change the register path of DAC3CH2 to "/dev/dac5".
   
   Thanks




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org