You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/07/18 01:43:34 UTC

Re: Review Request 66843: Enabled per-framework metrics in the allocator.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66843/
-----------------------------------------------------------

(Updated July 18, 2018, 1:43 a.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.


Summary (updated)
-----------------

Enabled per-framework metrics in the allocator.


Repository: mesos


Description (updated)
-------

The `FrameworkMetrics` struct will hold per-framework metrics tracked
by the allocator.


Diffs (updated)
-----

  src/master/allocator/mesos/hierarchical.hpp 0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 
  src/master/allocator/mesos/hierarchical.cpp 5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 
  src/master/allocator/mesos/metrics.hpp 6d386225c301d5ab44f3cc0ecdd1478fb5162e5b 
  src/master/allocator/mesos/metrics.cpp 82990b2dc0b827a43a392d898667eaf58c77ea36 


Diff: https://reviews.apache.org/r/66843/diff/10/

Changes: https://reviews.apache.org/r/66843/diff/9-10/


Testing
-------

Testing details can be found at the end of this chain.


Thanks,

Greg Mann


Re: Review Request 66843: Enabled per-framework metrics in the allocator.

Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66843/#review206229
-----------------------------------------------------------


Ship it!




Ship It!

- Gastón Kleiman


On July 17, 2018, 6:43 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66843/
> -----------------------------------------------------------
> 
> (Updated July 17, 2018, 6:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, Gilbert Song, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The `FrameworkMetrics` struct will hold per-framework metrics tracked
> by the allocator.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26 
>   src/master/allocator/mesos/hierarchical.cpp 5a6cd3d2fc5bdbaaee2d05b9be9e83d4107c749b 
>   src/master/allocator/mesos/metrics.hpp 6d386225c301d5ab44f3cc0ecdd1478fb5162e5b 
>   src/master/allocator/mesos/metrics.cpp 82990b2dc0b827a43a392d898667eaf58c77ea36 
> 
> 
> Diff: https://reviews.apache.org/r/66843/diff/10/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>