You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Ruediger Pluem <rp...@apache.org> on 2007/11/28 21:36:27 UTC
Re: svn commit: r598806 - /httpd/httpd/trunk/modules/ldap/util_ldap.c
On 11/28/2007 12:06 AM, rederpj@apache.org wrote:
> Author: rederpj
> Date: Tue Nov 27 15:06:44 2007
> New Revision: 598806
>
> URL: http://svn.apache.org/viewvc?rev=598806&view=rev
> Log:
> Refactoring stage 2. This commit moves a large chunk of utility code out to its own function
> to make reading and maintaining the actual subgroup function easier. This should just be
> shuffling code around and shouldn't result in any semantic changes.
>
> Modified:
> httpd/httpd/trunk/modules/ldap/util_ldap.c
>
> Modified: httpd/httpd/trunk/modules/ldap/util_ldap.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ldap/util_ldap.c?rev=598806&r1=598805&r2=598806&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/ldap/util_ldap.c (original)
> +++ httpd/httpd/trunk/modules/ldap/util_ldap.c Tue Nov 27 15:06:44 2007
> + lcl_sgl_processedFlag = 1;
What's the purpose of this?
Regards
Rüdiger
Re: svn commit: r598806 - /httpd/httpd/trunk/modules/ldap/util_ldap.c
Posted by "Paul J. Reder" <re...@remulak.net>.
I had a handfull of extra bits to burn? Checking again if anyone was watching?
Actually, the rest of the code that used it was removed but I missed
that line and the declaration. I'll fix that in the next commit...
Good catch, thanks for checking.
Ruediger Pluem wrote:
>
> On 11/28/2007 12:06 AM, rederpj@apache.org wrote:
>> Author: rederpj
>> Date: Tue Nov 27 15:06:44 2007
>> New Revision: 598806
>>
>> URL: http://svn.apache.org/viewvc?rev=598806&view=rev
>> Log:
>> Refactoring stage 2. This commit moves a large chunk of utility code out to its own function
>> to make reading and maintaining the actual subgroup function easier. This should just be
>> shuffling code around and shouldn't result in any semantic changes.
>>
>> Modified:
>> httpd/httpd/trunk/modules/ldap/util_ldap.c
>>
>> Modified: httpd/httpd/trunk/modules/ldap/util_ldap.c
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/ldap/util_ldap.c?rev=598806&r1=598805&r2=598806&view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/modules/ldap/util_ldap.c (original)
>> +++ httpd/httpd/trunk/modules/ldap/util_ldap.c Tue Nov 27 15:06:44 2007
>
>> + lcl_sgl_processedFlag = 1;
>
> What's the purpose of this?
>
> Regards
>
> Rüdiger
>
--
Paul J. Reder
-----------------------------------------------------------
"The strength of the Constitution lies entirely in the determination of each
citizen to defend it. Only if every single citizen feels duty bound to do
his share in this defense are the constitutional rights secure."
-- Albert Einstein