You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Cornwall (JIRA)" <ji...@apache.org> on 2008/03/05 23:05:40 UTC
[jira] Updated: (HARMONY-5578) [classlib][pack200] Remove regex
dependency of Pack200
[ https://issues.apache.org/jira/browse/HARMONY-5578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Cornwall updated HARMONY-5578:
-------------------------------------
Attachment: test.patch
main.patch
Patch to remove regex dependency. Code is in main.patch and testcase is in test.patch.
> [classlib][pack200] Remove regex dependency of Pack200
> ------------------------------------------------------
>
> Key: HARMONY-5578
> URL: https://issues.apache.org/jira/browse/HARMONY-5578
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: All pack200
> Reporter: Andrew Cornwall
> Priority: Minor
> Attachments: main.patch, test.patch
>
>
> I've had a complaint that my Pack200 code depends on regex being available because I use String.matches(). In some cases, regex may not be available - and it really doesn't make sense to use the overhead of regex when I don't need to. So I've added the worlds worst regex replacement to SegmentConstantPool so the dependency isn't there.
> This patch also removes a few magic values from SegmentConstantPool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.