[GitHub] [flink-connector-kafka] tzulitai commented on a diff in pull request #16: [FLINK-30859] Externalize confluent avro related code

["tzulitai (via GitHub)" <gi...@apache.org>]

tzulitai commented on code in PR #16:
URL: https://github.com/apache/flink-connector-kafka/pull/16#discussion_r1157777291


##########
docs/content.zh/docs/connectors/table/formats/avro-confluent.md:
##########


Review Comment:
   Does the "Debezium" format docs need to be migrated here as well?



##########
flink-formats-confluent/flink-avro-confluent-registry/src/main/java/org/apache/flink/formats/avro/registry/confluent/debezium/DebeziumAvroFormatFactory.java:
##########


Review Comment:
   I'm not so sure but: this makes me wonder if `debezium json` should be moved here as well.
   Strictly speaking its tied to Kafka as well. But it's a bit awkward, since that format is bundled as part of `flink-json` ...



##########
flink-formats-confluent/flink-avro-confluent-registry/pom.xml:
##########
@@ -0,0 +1,184 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+		 xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+		 xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+	<parent>
+		<groupId>org.apache.flink</groupId>
+		<artifactId>flink-formats-confluent</artifactId>
+		<version>4.0-SNAPSHOT</version>
+	</parent>
+	<modelVersion>4.0.0</modelVersion>
+
+	<artifactId>flink-avro-confluent-registry</artifactId>
+
+	<name>Flink : Formats : Avro confluent registry</name>
+
+	<properties>
+		<kafka.version>3.2.3</kafka.version>

Review Comment:
   The `main` branch recently had this upgraded to 3.4.0 for `flink-connector-kafka`.
   We'd probably want this version to be shared across all modules.



##########
flink-formats-confluent/pom.xml:
##########
@@ -0,0 +1,41 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+
+  <modelVersion>4.0.0</modelVersion>
+
+  <parent>
+    <groupId>org.apache.flink</groupId>
+    <artifactId>flink-connector-kafka-parent</artifactId>
+    <version>4.0-SNAPSHOT</version>
+  </parent>
+
+  <packaging>pom</packaging>
+
+  <artifactId>flink-formats-confluent</artifactId>
+  <name>Flink : Formats : Confluent</name>

Review Comment:
   Not so sure of the naming. Should we name this `Flink : Formats : Kafka` instead?
   I know that the current formats we have is all Confluent-specific, but naming it more generally might make sense if we add other Kafka-related formats down the road.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org