[GitHub] [flink] buptljy commented on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1

[GitBox <gi...@apache.org>]

buptljy commented on issue #11104: [FLINK-16051] Subtask ID in Overview-Subtasks should start from 1
URL: https://github.com/apache/flink/pull/11104#issuecomment-586890133
 
 
   > Why did you opt for incrementing this subtask id? Now both the checkpoint and subtask id are inconsistent with the entire Flink runtime, including logging and metrics.
   
   @zentol I've struggled for a little bit here because:
   1. ID in subtasks starts from 0, while ID in checkpoint / watermark / backpressure starts from 1.
   2. Logging with #ExecutionVertex#subtaskIndex starts from 0, while Logging with #ExecutionVertex#taskNameWithSubtask starts from 1.
   
   The reason I choose incrementing ID in subtasks is that it may look more reasonable and intuitive from user's perspective(maybe not from developer's perspective). I didn't think of the metrics before but it should be included.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services