You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@maven.apache.org by Wim Deblauwe <wi...@gmail.com> on 2005/05/26 09:29:15 UTC

PMD jar override not respected when in master project

Hi,

All my projects extend from a master project.xml. Along this is a
project.properties file. Normally these values are being used, the
same as they where in a project.properties file along the "real"
project.xml. But I have a problem with the PMD plugin. It seems that
this rule is not being followed.

I created a test with this structure:

+ moduleA
    |
   + project.xml
   + project.properties
+ rootProject
   |
   + project.xml
   + project.properties

In my project.xml I <extend>..\rootproject\project.xml</extend>

In project.properties I have:
maven.jar.override=3Don
maven.jar.pmd=3D3.1

When running "maven pmd" from the moduleA directory with these
properties in the project.properties of moduleA, I get an error from
pmd that I should specify the 'targetjdk' value, which is good(!)
because that way I'm sure I'm using the new version 3.1.
However when I move these properties to the project.properties of
rootproject, pmd does not give an error, meaning that he is not using
the new jar.

I can send you a zip file with the test setup for further
investigation. (I tried to attach it, but the mailing list does not
allow it)

regards,

Wim

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


Re: PMD jar override not respected when in master project

Posted by Wim Deblauwe <wi...@gmail.com>.
There is already a JIRA issue for the PMD upgrade. I added a new one
for the maven inheritance problem.

regards,

Wim

2005/5/31, Kenney Westerhof <fo...@neonics.com>:
> On Tue, 31 May 2005, Wim Deblauwe wrote:
> 
> Still no answer on the maven users list?
> I think you should file 2 requests: one for the failing inheritance in
> project.properties on the maven JIRA, and one on the PMD plugin JIRA
> asking to upgrade the PMD lib.
> 
> 
> > ok, thank you for looking into it. I want to open a JIRA issue. Should
> > I add this to the Maven JIRA or PMD plugin JIRA?
> >
> > 2005/5/31, Kenney Westerhof <fo...@neonics.com>:
> > > On Tue, 31 May 2005, Wim Deblauwe wrote:
> > >
> > > Well, it seems you're right. Didn't know you could also only specify
> > > the version in the maven.jar.X properties. Had to download pmd-3.1
> > > by hand, btw. Also, when I replace the pmd version in the project.xml
> > > in maven-pmd-plugin I don't get an error (but tested with 3.2 which does
> > > not exist).
> > >
> > > Also checked to see if a build.properties would do the trick, but alas..
> > >
> > > I've had similar problems, and the only thing to to was to add the
> > > overrides in every subproject. But my guess is it's better to update the
> > > pmd plugin itself in this case..
> > >
> > > > See attached zip file. Thank you!
> > > >
> > > > regards,
> > > >
> > > > Wim
> > > >
> > > > 2005/5/30, Kenney Westerhof <fo...@neonics.com>:
> > > > > On Mon, 30 May 2005, Wim Deblauwe wrote:
> > > > >
> > > > > Sure, I'll have a look at it.
> > > > >
> > > > > Greetings,
> > > > >
> > > > >         Kenney
> > > > >
> > > > > > I can send you a zip file that reproduces the problem if you care to
> > > > > > take a look at it. It would be very much appriciated.
> > > > > >
> > > > > > regards,
> > > > > >
> > > > > > Wim
> > > > > >
> > > > > > 2005/5/30, Kenney Westerhof <fo...@neonics.com>:
> > > > > > > On Mon, 30 May 2005, Wim Deblauwe wrote:
> > > > > > >
> > > > > > > Are you sure it's because of the inheritance?
> > > > > > > maven.jar.override=on means that for X in maven.jar.X=path/to/some.jar
> > > > > > > you can specify a dependency on X and it will be resolved
> > > > > > > through the maven.jar.X property, not using ibiblio. So your
> > > > > > > maven.jar.pmd=1.3 should mean that you have a file named '1.3' in your
> > > > > > > local directory that represents the pmd jar..
> > > > > > >
> > > > > > > My guess is that something else is the problem. Do you have any other
> > > > > > > properties or perhaps a maven.xml file?
> > > > > > >
> > > > > > > Greetings,
> > > > > > >
> > > > > > >         Kenney
> > > > > > >
> > > > > > >
> > > > > > > > Can I file a JIRA issue for this?
> > > > > > > >
> > > > > > > > regards,
> > > > > > > >
> > > > > > > > Wim
> > > > > > > >
> > > > > > > > ---------- Forwarded message ----------
> > > > > > > > From: Wim Deblauwe <wi...@gmail.com>
> > > > > > > > Date: 26-mei-2005 9:29
> > > > > > > > Subject: PMD jar override not respected when in master project
> > > > > > > > To: Maven Users List <us...@maven.apache.org>
> > > > > > > >
> > > > > > > >
> > > > > > > > Hi,
> > > > > > > >
> > > > > > > > All my projects extend from a master project.xml. Along this is a
> > > > > > > > project.properties file. Normally these values are being used, the
> > > > > > > > same as they where in a project.properties file along the "real"
> > > > > > > > project.xml. But I have a problem with the PMD plugin. It seems that
> > > > > > > > this rule is not being followed.
> > > > > > > >
> > > > > > > > I created a test with this structure:
> > > > > > > >
> > > > > > > > + moduleA
> > > > > > > >     |
> > > > > > > >    + project.xml
> > > > > > > >    + project.properties
> > > > > > > > + rootProject
> > > > > > > >    |
> > > > > > > >    + project.xml
> > > > > > > >    + project.properties
> > > > > > > >
> > > > > > > > In my project.xml I <extend>..\rootproject\project.xml</extend>
> > > > > > > >
> > > > > > > > In project.properties I have:
> > > > > > > > maven.jar.override=3Don
> > > > > > > > maven.jar.pmd=3D3.1
> > > > > > > >
> > > > > > > > When running "maven pmd" from the moduleA directory with these
> > > > > > > > properties in the project.properties of moduleA, I get an error from
> > > > > > > > pmd that I should specify the 'targetjdk' value, which is good(!)
> > > > > > > > because that way I'm sure I'm using the new version 3.1.
> > > > > > > > However when I move these properties to the project.properties of
> > > > > > > > rootproject, pmd does not give an error, meaning that he is not using
> > > > > > > > the new jar.
> > > > > > > >
> > > > > > > > I can send you a zip file with the test setup for further
> > > > > > > > investigation. (I tried to attach it, but the mailing list does not
> > > > > > > > allow it)
> > > > > > > >
> > > > > > > > regards,
> > > > > > > >
> > > > > > > > Wim
> > > > > > > >
> > > > > > > > ---------------------------------------------------------------------
> > > > > > > > To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> > > > > > > > For additional commands, e-mail: users-help@maven.apache.org
> > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Kenney Westerhof
> > > > > > > http://www.neonics.com
> > > > > > > GPG public key: http://www.gods.nl/~forge/kenneyw.key
> > > > > > >
> > > > > >
> > > > >
> > > > > --
> > > > > Kenney Westerhof
> > > > > http://www.neonics.com
> > > > > GPG public key: http://www.gods.nl/~forge/kenneyw.key
> > > > >
> > > >
> > >
> > > --
> > > Kenney Westerhof
> > > http://www.neonics.com
> > > GPG public key: http://www.gods.nl/~forge/kenneyw.key
> > >
> >
> 
> --
> Kenney Westerhof
> http://www.neonics.com
> GPG public key: http://www.gods.nl/~forge/kenneyw.key
>

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


Re: PMD jar override not respected when in master project

Posted by Kenney Westerhof <fo...@neonics.com>.
On Tue, 31 May 2005, Wim Deblauwe wrote:

Still no answer on the maven users list?
I think you should file 2 requests: one for the failing inheritance in
project.properties on the maven JIRA, and one on the PMD plugin JIRA
asking to upgrade the PMD lib.


> ok, thank you for looking into it. I want to open a JIRA issue. Should
> I add this to the Maven JIRA or PMD plugin JIRA?
>
> 2005/5/31, Kenney Westerhof <fo...@neonics.com>:
> > On Tue, 31 May 2005, Wim Deblauwe wrote:
> >
> > Well, it seems you're right. Didn't know you could also only specify
> > the version in the maven.jar.X properties. Had to download pmd-3.1
> > by hand, btw. Also, when I replace the pmd version in the project.xml
> > in maven-pmd-plugin I don't get an error (but tested with 3.2 which does
> > not exist).
> >
> > Also checked to see if a build.properties would do the trick, but alas..
> >
> > I've had similar problems, and the only thing to to was to add the
> > overrides in every subproject. But my guess is it's better to update the
> > pmd plugin itself in this case..
> >
> > > See attached zip file. Thank you!
> > >
> > > regards,
> > >
> > > Wim
> > >
> > > 2005/5/30, Kenney Westerhof <fo...@neonics.com>:
> > > > On Mon, 30 May 2005, Wim Deblauwe wrote:
> > > >
> > > > Sure, I'll have a look at it.
> > > >
> > > > Greetings,
> > > >
> > > >         Kenney
> > > >
> > > > > I can send you a zip file that reproduces the problem if you care to
> > > > > take a look at it. It would be very much appriciated.
> > > > >
> > > > > regards,
> > > > >
> > > > > Wim
> > > > >
> > > > > 2005/5/30, Kenney Westerhof <fo...@neonics.com>:
> > > > > > On Mon, 30 May 2005, Wim Deblauwe wrote:
> > > > > >
> > > > > > Are you sure it's because of the inheritance?
> > > > > > maven.jar.override=on means that for X in maven.jar.X=path/to/some.jar
> > > > > > you can specify a dependency on X and it will be resolved
> > > > > > through the maven.jar.X property, not using ibiblio. So your
> > > > > > maven.jar.pmd=1.3 should mean that you have a file named '1.3' in your
> > > > > > local directory that represents the pmd jar..
> > > > > >
> > > > > > My guess is that something else is the problem. Do you have any other
> > > > > > properties or perhaps a maven.xml file?
> > > > > >
> > > > > > Greetings,
> > > > > >
> > > > > >         Kenney
> > > > > >
> > > > > >
> > > > > > > Can I file a JIRA issue for this?
> > > > > > >
> > > > > > > regards,
> > > > > > >
> > > > > > > Wim
> > > > > > >
> > > > > > > ---------- Forwarded message ----------
> > > > > > > From: Wim Deblauwe <wi...@gmail.com>
> > > > > > > Date: 26-mei-2005 9:29
> > > > > > > Subject: PMD jar override not respected when in master project
> > > > > > > To: Maven Users List <us...@maven.apache.org>
> > > > > > >
> > > > > > >
> > > > > > > Hi,
> > > > > > >
> > > > > > > All my projects extend from a master project.xml. Along this is a
> > > > > > > project.properties file. Normally these values are being used, the
> > > > > > > same as they where in a project.properties file along the "real"
> > > > > > > project.xml. But I have a problem with the PMD plugin. It seems that
> > > > > > > this rule is not being followed.
> > > > > > >
> > > > > > > I created a test with this structure:
> > > > > > >
> > > > > > > + moduleA
> > > > > > >     |
> > > > > > >    + project.xml
> > > > > > >    + project.properties
> > > > > > > + rootProject
> > > > > > >    |
> > > > > > >    + project.xml
> > > > > > >    + project.properties
> > > > > > >
> > > > > > > In my project.xml I <extend>..\rootproject\project.xml</extend>
> > > > > > >
> > > > > > > In project.properties I have:
> > > > > > > maven.jar.override=3Don
> > > > > > > maven.jar.pmd=3D3.1
> > > > > > >
> > > > > > > When running "maven pmd" from the moduleA directory with these
> > > > > > > properties in the project.properties of moduleA, I get an error from
> > > > > > > pmd that I should specify the 'targetjdk' value, which is good(!)
> > > > > > > because that way I'm sure I'm using the new version 3.1.
> > > > > > > However when I move these properties to the project.properties of
> > > > > > > rootproject, pmd does not give an error, meaning that he is not using
> > > > > > > the new jar.
> > > > > > >
> > > > > > > I can send you a zip file with the test setup for further
> > > > > > > investigation. (I tried to attach it, but the mailing list does not
> > > > > > > allow it)
> > > > > > >
> > > > > > > regards,
> > > > > > >
> > > > > > > Wim
> > > > > > >
> > > > > > > ---------------------------------------------------------------------
> > > > > > > To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> > > > > > > For additional commands, e-mail: users-help@maven.apache.org
> > > > > > >
> > > > > > >
> > > > > >
> > > > > > --
> > > > > > Kenney Westerhof
> > > > > > http://www.neonics.com
> > > > > > GPG public key: http://www.gods.nl/~forge/kenneyw.key
> > > > > >
> > > > >
> > > >
> > > > --
> > > > Kenney Westerhof
> > > > http://www.neonics.com
> > > > GPG public key: http://www.gods.nl/~forge/kenneyw.key
> > > >
> > >
> >
> > --
> > Kenney Westerhof
> > http://www.neonics.com
> > GPG public key: http://www.gods.nl/~forge/kenneyw.key
> >
>

--
Kenney Westerhof
http://www.neonics.com
GPG public key: http://www.gods.nl/~forge/kenneyw.key

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


Re: PMD jar override not respected when in master project

Posted by Wim Deblauwe <wi...@gmail.com>.
ok, thank you for looking into it. I want to open a JIRA issue. Should
I add this to the Maven JIRA or PMD plugin JIRA?

2005/5/31, Kenney Westerhof <fo...@neonics.com>:
> On Tue, 31 May 2005, Wim Deblauwe wrote:
> 
> Well, it seems you're right. Didn't know you could also only specify
> the version in the maven.jar.X properties. Had to download pmd-3.1
> by hand, btw. Also, when I replace the pmd version in the project.xml
> in maven-pmd-plugin I don't get an error (but tested with 3.2 which does
> not exist).
> 
> Also checked to see if a build.properties would do the trick, but alas..
> 
> I've had similar problems, and the only thing to to was to add the
> overrides in every subproject. But my guess is it's better to update the
> pmd plugin itself in this case..
> 
> > See attached zip file. Thank you!
> >
> > regards,
> >
> > Wim
> >
> > 2005/5/30, Kenney Westerhof <fo...@neonics.com>:
> > > On Mon, 30 May 2005, Wim Deblauwe wrote:
> > >
> > > Sure, I'll have a look at it.
> > >
> > > Greetings,
> > >
> > >         Kenney
> > >
> > > > I can send you a zip file that reproduces the problem if you care to
> > > > take a look at it. It would be very much appriciated.
> > > >
> > > > regards,
> > > >
> > > > Wim
> > > >
> > > > 2005/5/30, Kenney Westerhof <fo...@neonics.com>:
> > > > > On Mon, 30 May 2005, Wim Deblauwe wrote:
> > > > >
> > > > > Are you sure it's because of the inheritance?
> > > > > maven.jar.override=on means that for X in maven.jar.X=path/to/some.jar
> > > > > you can specify a dependency on X and it will be resolved
> > > > > through the maven.jar.X property, not using ibiblio. So your
> > > > > maven.jar.pmd=1.3 should mean that you have a file named '1.3' in your
> > > > > local directory that represents the pmd jar..
> > > > >
> > > > > My guess is that something else is the problem. Do you have any other
> > > > > properties or perhaps a maven.xml file?
> > > > >
> > > > > Greetings,
> > > > >
> > > > >         Kenney
> > > > >
> > > > >
> > > > > > Can I file a JIRA issue for this?
> > > > > >
> > > > > > regards,
> > > > > >
> > > > > > Wim
> > > > > >
> > > > > > ---------- Forwarded message ----------
> > > > > > From: Wim Deblauwe <wi...@gmail.com>
> > > > > > Date: 26-mei-2005 9:29
> > > > > > Subject: PMD jar override not respected when in master project
> > > > > > To: Maven Users List <us...@maven.apache.org>
> > > > > >
> > > > > >
> > > > > > Hi,
> > > > > >
> > > > > > All my projects extend from a master project.xml. Along this is a
> > > > > > project.properties file. Normally these values are being used, the
> > > > > > same as they where in a project.properties file along the "real"
> > > > > > project.xml. But I have a problem with the PMD plugin. It seems that
> > > > > > this rule is not being followed.
> > > > > >
> > > > > > I created a test with this structure:
> > > > > >
> > > > > > + moduleA
> > > > > >     |
> > > > > >    + project.xml
> > > > > >    + project.properties
> > > > > > + rootProject
> > > > > >    |
> > > > > >    + project.xml
> > > > > >    + project.properties
> > > > > >
> > > > > > In my project.xml I <extend>..\rootproject\project.xml</extend>
> > > > > >
> > > > > > In project.properties I have:
> > > > > > maven.jar.override=3Don
> > > > > > maven.jar.pmd=3D3.1
> > > > > >
> > > > > > When running "maven pmd" from the moduleA directory with these
> > > > > > properties in the project.properties of moduleA, I get an error from
> > > > > > pmd that I should specify the 'targetjdk' value, which is good(!)
> > > > > > because that way I'm sure I'm using the new version 3.1.
> > > > > > However when I move these properties to the project.properties of
> > > > > > rootproject, pmd does not give an error, meaning that he is not using
> > > > > > the new jar.
> > > > > >
> > > > > > I can send you a zip file with the test setup for further
> > > > > > investigation. (I tried to attach it, but the mailing list does not
> > > > > > allow it)
> > > > > >
> > > > > > regards,
> > > > > >
> > > > > > Wim
> > > > > >
> > > > > > ---------------------------------------------------------------------
> > > > > > To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> > > > > > For additional commands, e-mail: users-help@maven.apache.org
> > > > > >
> > > > > >
> > > > >
> > > > > --
> > > > > Kenney Westerhof
> > > > > http://www.neonics.com
> > > > > GPG public key: http://www.gods.nl/~forge/kenneyw.key
> > > > >
> > > >
> > >
> > > --
> > > Kenney Westerhof
> > > http://www.neonics.com
> > > GPG public key: http://www.gods.nl/~forge/kenneyw.key
> > >
> >
> 
> --
> Kenney Westerhof
> http://www.neonics.com
> GPG public key: http://www.gods.nl/~forge/kenneyw.key
>

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


Re: PMD jar override not respected when in master project

Posted by Kenney Westerhof <fo...@neonics.com>.
On Mon, 30 May 2005, Wim Deblauwe wrote:

Are you sure it's because of the inheritance?
maven.jar.override=on means that for X in maven.jar.X=path/to/some.jar
you can specify a dependency on X and it will be resolved
through the maven.jar.X property, not using ibiblio. So your
maven.jar.pmd=1.3 should mean that you have a file named '1.3' in your
local directory that represents the pmd jar..

My guess is that something else is the problem. Do you have any other
properties or perhaps a maven.xml file?

Greetings,

	Kenney


> Can I file a JIRA issue for this?
>
> regards,
>
> Wim
>
> ---------- Forwarded message ----------
> From: Wim Deblauwe <wi...@gmail.com>
> Date: 26-mei-2005 9:29
> Subject: PMD jar override not respected when in master project
> To: Maven Users List <us...@maven.apache.org>
>
>
> Hi,
>
> All my projects extend from a master project.xml. Along this is a
> project.properties file. Normally these values are being used, the
> same as they where in a project.properties file along the "real"
> project.xml. But I have a problem with the PMD plugin. It seems that
> this rule is not being followed.
>
> I created a test with this structure:
>
> + moduleA
>     |
>    + project.xml
>    + project.properties
> + rootProject
>    |
>    + project.xml
>    + project.properties
>
> In my project.xml I <extend>..\rootproject\project.xml</extend>
>
> In project.properties I have:
> maven.jar.override=3Don
> maven.jar.pmd=3D3.1
>
> When running "maven pmd" from the moduleA directory with these
> properties in the project.properties of moduleA, I get an error from
> pmd that I should specify the 'targetjdk' value, which is good(!)
> because that way I'm sure I'm using the new version 3.1.
> However when I move these properties to the project.properties of
> rootproject, pmd does not give an error, meaning that he is not using
> the new jar.
>
> I can send you a zip file with the test setup for further
> investigation. (I tried to attach it, but the mailing list does not
> allow it)
>
> regards,
>
> Wim
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
> For additional commands, e-mail: users-help@maven.apache.org
>
>

--
Kenney Westerhof
http://www.neonics.com
GPG public key: http://www.gods.nl/~forge/kenneyw.key

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org


PMD jar override not respected when in master project

Posted by Wim Deblauwe <wi...@gmail.com>.
Can I file a JIRA issue for this?

regards,

Wim

---------- Forwarded message ----------
From: Wim Deblauwe <wi...@gmail.com>
Date: 26-mei-2005 9:29
Subject: PMD jar override not respected when in master project
To: Maven Users List <us...@maven.apache.org>


Hi,

All my projects extend from a master project.xml. Along this is a
project.properties file. Normally these values are being used, the
same as they where in a project.properties file along the "real"
project.xml. But I have a problem with the PMD plugin. It seems that
this rule is not being followed.

I created a test with this structure:

+ moduleA
    |
   + project.xml
   + project.properties
+ rootProject
   |
   + project.xml
   + project.properties

In my project.xml I <extend>..\rootproject\project.xml</extend>

In project.properties I have:
maven.jar.override=3Don
maven.jar.pmd=3D3.1

When running "maven pmd" from the moduleA directory with these
properties in the project.properties of moduleA, I get an error from
pmd that I should specify the 'targetjdk' value, which is good(!)
because that way I'm sure I'm using the new version 3.1.
However when I move these properties to the project.properties of
rootproject, pmd does not give an error, meaning that he is not using
the new jar.

I can send you a zip file with the test setup for further
investigation. (I tried to attach it, but the mailing list does not
allow it)

regards,

Wim

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@maven.apache.org
For additional commands, e-mail: users-help@maven.apache.org