[GitHub] [incubator-pekko-connectors] pjfanning commented on pull request #31: add license header to conf files

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on PR #31:
URL: https://github.com/apache/incubator-pekko-connectors/pull/31#issuecomment-1437700710

   The reference conf is probably as much part of the codebase as the scala/java source. sbt-header has built-in support for it.
   Other config files are also regularly given headers in ASF projects.
   
   some examples from Apache Spark:
   * https://github.com/apache/spark/blob/master/.asf.yaml
   * https://github.com/apache/spark/blob/master/scalastyle-config.xml
   * https://github.com/apache/spark/blob/master/pom.xml
   * https://github.com/apache/spark/blob/master/conf/fairscheduler.xml.template
   * https://github.com/apache/spark/blob/master/core/src/main/resources/META-INF/services/org.apache.spark.deploy.history.EventFilterBuilder
   
   An sbt file: https://github.com/apache/incubator-toree/blob/master/kernel/build.sbt
   
   I've had a little trouble with license headers in .md files but this looks like the way to do it:
   https://github.com/apache/druid/edit/master/docs/operations/use_sbt_to_build_fat_jar.md (note the project description block needs to start the file or Paradox will not recognise it as a description block.
   
   I can't find any ASF use of HOCON files (probably out there, but just can't track one down) - but I can't see why a .conf should not be headered like anything else.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org