[GitHub] [incubator-superset] betodealmeida opened a new pull request #8721: Add protocol to cache warmup

[GitBox <gi...@apache.org>]

betodealmeida opened a new pull request #8721: Add protocol to cache warmup
URL: https://github.com/apache/incubator-superset/pull/8721
 
 
   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   We have two variables in `config.py` that are used exclusively for the cache warmup celery task:
   
   ```python
   SUPERSET_WEBSERVER_ADDRESS = "0.0.0.0"
   SUPERSET_WEBSERVER_PORT = 8088
   ```
   
   The change from `requests` to `urllib` broke the task, since `urllib` requires a protocol in addition to the host and port.
   
   I fixed it by adding a new variable to `config.py`:
   
   ```python
   SUPERSET_WEBSERVER_PROTOCOL = "http"
   ```
   
   And using that variable when composing the URL.
   
   <!-- ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF -->
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   Updated unit tests.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [X] Has associated issue: https://github.com/apache/incubator-superset/issues/8461
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   This PR fixes https://github.com/apache/incubator-superset/issues/8461.
   
   ### REVIEWERS
   
   @willbarrett 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org