You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2014/06/25 19:27:40 UTC
svn commit: r1605512 -
/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/PatternLayout.java
Author: ggregory
Date: Wed Jun 25 17:27:39 2014
New Revision: 1605512
URL: http://svn.apache.org/r1605512
Log:
[LOG4J2-688] Make org.apache.logging.log4j.core.layout.PatternLayout immutable. Remove old API and make ivars final.
Modified:
logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/PatternLayout.java
Modified: logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/PatternLayout.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/PatternLayout.java?rev=1605512&r1=1605511&r2=1605512&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/PatternLayout.java (original)
+++ logging/log4j/log4j2/trunk/log4j-core/src/main/java/org/apache/logging/log4j/core/layout/PatternLayout.java Wed Jun 25 17:27:39 2014
@@ -79,12 +79,12 @@ public final class PatternLayout extends
/**
* Initial converter for pattern.
*/
- private List<PatternFormatter> formatters;
+ private final List<PatternFormatter> formatters;
/**
* Conversion pattern.
*/
- private String conversionPattern;
+ private final String conversionPattern;
/**
@@ -150,22 +150,6 @@ public final class PatternLayout extends
}
/**
- * Set the <b>ConversionPattern</b> option. This is the string which
- * controls formatting and consists of a mix of literal content and
- * conversion specifiers.
- *
- * @param conversionPattern conversion pattern.
- */
- public void setConversionPattern(final String conversionPattern) {
- if (conversionPattern == null) {
- return;
- }
- this.conversionPattern = conversionPattern;
- final PatternParser parser = createPatternParser(this.config);
- formatters = parser.parse(conversionPattern, this.alwaysWriteExceptions, this.noConsoleNoAnsi);
- }
-
- /**
* Gets the conversion pattern.
*
* @return the conversion pattern.