You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "rickyma (via GitHub)" <gi...@apache.org> on 2024/02/28 09:27:35 UTC

[PR] [#1549] fix(common): Uniformly throw RssException for external callers [incubator-uniffle]

rickyma opened a new pull request, #1550:
URL: https://github.com/apache/incubator-uniffle/pull/1550

   ### What changes were proposed in this pull request?
   
   Make custom exception classes in the `rss-common` module inherit from `RssException`.
   
   ### Why are the changes needed?
   
   For https://github.com/apache/incubator-uniffle/issues/1549
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Existing UTs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1549] fix(common): Uniformly throw RssException for external callers [incubator-uniffle]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1550:
URL: https://github.com/apache/incubator-uniffle/pull/1550#issuecomment-1968633128

   ## Test Results
   2 312 files  + 50  2 312 suites  +50   4h 37m 45s :stopwatch: + 14m 5s
     823 tests ±  0    822 :white_check_mark: +  1   1 :zzz: ±0  0 :x:  - 1 
   9 693 runs  +159  9 679 :white_check_mark: +160  14 :zzz: ±0  0 :x:  - 1 
   
   Results for commit b1884f9a. ± Comparison against base commit 12f9271b.
   
   [test-results]:data:application/gzip;base64,H4sIAK8E32UC/03MTQ6DIBCG4asY1l0UGAboZRoESUhVGn5WTe9eNGpZfg/D+yE+zFMmj4Fxym4DyTWUfruaTAlxbUIRUTRq72W7UIyf65mrtTuxP73Ce/t1gTdhbnC/YEoppkNSXbemRs2PdTY1Sn3R0YQTuua++6SNyxJKG2SkSoHXBsB4YcDhBFJIYVBYh85Kp1BQNUry/QGgpDLWEAEAAA==
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1549] fix(common): Uniformly throw RssException for external callers [incubator-uniffle]

Posted by "rickyma (via GitHub)" <gi...@apache.org>.
rickyma commented on PR #1550:
URL: https://github.com/apache/incubator-uniffle/pull/1550#issuecomment-1968568206

   @jerqi @zuston PTAL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1549] fix(common): Uniformly throw RssException for external callers [incubator-uniffle]

Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #1550:
URL: https://github.com/apache/incubator-uniffle/pull/1550


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org


Re: [PR] [#1549] fix(common): Uniformly throw RssException for external callers [incubator-uniffle]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1550:
URL: https://github.com/apache/incubator-uniffle/pull/1550#issuecomment-1968581923

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1550?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 54.69%. Comparing base [(`12f9271`)](https://app.codecov.io/gh/apache/incubator-uniffle/commit/12f9271b623bfba545892ec6bd707c5144b3d304?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b1884f9`)](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1550?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #1550      +/-   ##
   ============================================
   + Coverage     53.61%   54.69%   +1.08%     
   + Complexity     2815     2425     -390     
   ============================================
     Files           436      377      -59     
     Lines         24536    17246    -7290     
     Branches       2076     1554     -522     
   ============================================
   - Hits          13155     9433    -3722     
   + Misses        10560     7281    -3279     
   + Partials        821      532     -289     
   ```
   
   
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1550?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org