[GitHub] [openwhisk] tysonnorris opened a new pull request #4856: enable optional use of PodDisruptionBudget for action pods

[GitBox <gi...@apache.org>]

tysonnorris opened a new pull request #4856: enable optional use of PodDisruptionBudget for action pods
URL: https://github.com/apache/openwhisk/pull/4856
 
 
   <!--- Provide a concise summary of your changes in the Title -->
   If enabled, when action pods are created, also creates a PodDisruptionBudget with minavailable=1
   Also deletes the PodDisruptionBudget when pod is deleted.
   
   ## Description
   This prevents the action pod from being terminated if the kubernetes node goes into maintenance and is drained. Depending on the PDB configured for the invoker, invokers can still be terminated, which should terminate the action pods that way.
   
   ## Related issue and scope
   <!--- Please include a link to a related issue if there is one. -->
   - [ ] I opened an issue to propose and discuss this change (#????)
   
   ## My changes affect the following components
   <!--- Select below all system components are affected by your change. -->
   <!--- Enter an `x` in all applicable boxes. -->
   - [ ] API
   - [ ] Controller
   - [ ] Message Bus (e.g., Kafka)
   - [ ] Loadbalancer
   - [x] Invoker
   - [ ] Intrinsic actions (e.g., sequences, conductors)
   - [ ] Data stores (e.g., CouchDB)
   - [ ] Tests
   - [ ] Deployment
   - [ ] CLI
   - [ ] General tooling
   - [ ] Documentation
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->
   - [ ] Bug fix (generally a non-breaking change which closes an issue).
   - [x] Enhancement or new feature (adds new functionality).
   - [ ] Breaking change (a bug fix or enhancement which changes existing behavior).
   
   ## Checklist:
   <!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
   
   - [x] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
   - [x] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
   - [x] I added tests to cover my changes.
   - [ ] My changes require further changes to the documentation.
   - [ ] I updated the documentation where necessary.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [openwhisk] tysonnorris merged pull request #4856: enable optional use of PodDisruptionBudget for action pods

[GitBox <gi...@apache.org>]

tysonnorris merged pull request #4856: enable optional use of PodDisruptionBudget for action pods
URL: https://github.com/apache/openwhisk/pull/4856
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services