[incubator-uniffle] branch master updated: [#381]imporvement(server): Check JAVA_HOME and HADOOP_HOME in start-shuffle-server.sh (#954)

[ro...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

roryqi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/master by this push:
     new 8a0ae4bf [#381]imporvement(server): Check JAVA_HOME and HADOOP_HOME in start-shuffle-server.sh (#954)
8a0ae4bf is described below

commit 8a0ae4bf82a3dcb3ee43da34cd052552aec536b6
Author: Neo Chien <cc...@cs.ccu.edu.tw>
AuthorDate: Mon Jun 19 22:36:01 2023 +0800

    [#381]imporvement(server): Check JAVA_HOME and HADOOP_HOME in start-shuffle-server.sh (#954)
    
    ### What changes were proposed in this pull request?
    
    - Comment the variable `JAVA_HOME` and `HADOOP_HOME` assignment in `bin/rss-env.sh`
    - Keep the variable `JAVA_HOME` and `HADOOP_HOME` be checked in `bin/utils.sh`
    
    ### Why are the changes needed?
    
    Fix: #381
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    current UT
---
 bin/rss-env.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bin/rss-env.sh b/bin/rss-env.sh
index 67d0f1a9..39efd5cb 100644
--- a/bin/rss-env.sh
+++ b/bin/rss-env.sh
@@ -21,8 +21,8 @@ set -o pipefail
 set -o nounset   # exit the script if you try to use an uninitialised variable
 set -o errexit   # exit the script if any statement returns a non-true return value
 
-JAVA_HOME=<java_home_dir>
-HADOOP_HOME=<hadoop_home_dir>
+# JAVA_HOME=<java_home_dir>
+# HADOOP_HOME=<hadoop_home_dir>
 XMX_SIZE="80g" # Shuffle Server JVM XMX size
 
 # RSS_HOME, RSS home directory (Default: parent directory of the script)