You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Reza Motamedi <re...@gmail.com> on 2017/10/23 18:01:13 UTC
Review Request 63221: reload instance page once a neighbor item is
clicked
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63221/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin and Kai Huang.
Repository: aurora
Description
-------
reload instance page once a neighbor item is clicked
Diffs
-----
ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a
Diff: https://reviews.apache.org/r/63221/diff/1/
Testing
-------
Checked in my vagrant and now it works.
```
? ./gradlew ui:lint
? ./gradlew ui:test
```
Thanks,
Reza Motamedi
Re: Review Request 63221: reload instance page once a neighbor item is
clicked
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63221/#review188973
-----------------------------------------------------------
Master (ec64011) is red with this patch.
./build-support/jenkins/build.sh
:test
org.apache.aurora.scheduler.http.api.ApiBetaTest > testCreateJob FAILED
java.lang.RuntimeException
1116 tests completed, 1 failed, 2 skipped
:test FAILED
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:jacocoTestCoverageVerification[ant:jacocoReport] Rule violated for bundle aurora: instructions covered ratio is 0.76, but expected minimum is 0.87
[ant:jacocoReport] Rule violated for bundle aurora: branches covered ratio is 0.65, but expected minimum is 0.79
FAILED
FAILURE: Build completed with 2 failures.
1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':test'.
> Process 'Gradle Test Executor 5' finished with non-zero exit value 137
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
2: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':jacocoTestCoverageVerification'.
> Rule violated for bundle aurora: instructions covered ratio is 0.76, but expected minimum is 0.87
Rule violated for bundle aurora: branches covered ratio is 0.65, but expected minimum is 0.79
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
==============================================================================
* Get more help at https://help.gradle.org
BUILD FAILED in 37m 2s
48 actionable tasks: 39 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 23, 2017, 11:01 a.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63221/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2017, 11:01 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Kai Huang.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> reload instance page once a neighbor item is clicked
>
>
> Diffs
> -----
>
> ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a
>
>
> Diff: https://reviews.apache.org/r/63221/diff/1/
>
>
> Testing
> -------
>
> Checked in my vagrant and now it works.
>
> ```
> ? ./gradlew ui:lint
> ? ./gradlew ui:test
> ```
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63221: reload instance page once a neighbor item is
clicked
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63221/#review188977
-----------------------------------------------------------
Master (ec64011) is red with this patch.
./build-support/jenkins/build.sh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
:pmdTest
:testI1023 18:54:32.698 [Test worker-EventThread, ClientCnxn] EventThread shut down for session: 0x0
org.apache.aurora.scheduler.events.WebhookTest > testTaskChangedWithOldStateError FAILED
java.lang.AssertionError at WebhookTest.java:203
I1023 18:55:09.000 [SessionTracker, SessionTrackerImpl] SessionTrackerImpl exited loop!
I1023 18:55:09.000 [SessionTracker, SessionTrackerImpl] SessionTrackerImpl exited loop!
I1023 18:55:09.000 [SessionTracker, SessionTrackerImpl] SessionTrackerImpl exited loop!
I1023 18:55:09.000 [SessionTracker, SessionTrackerImpl] SessionTrackerImpl exited loop!
I1023 18:55:09.001 [SessionTracker, SessionTrackerImpl] SessionTrackerImpl exited loop!
I1023 18:55:44.526 [ShutdownHook, SchedulerMain] Stopping scheduler services.
1135 tests completed, 1 failed, 2 skipped
:test FAILED
:jacocoTestReport
Coverage report generated: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:jacocoTestCoverageVerification
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':test'.
> There were failing tests. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/tests/test/index.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 7m 34s
48 actionable tasks: 39 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 23, 2017, 6:01 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63221/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2017, 6:01 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Kai Huang.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> reload instance page once a neighbor item is clicked
>
>
> Diffs
> -----
>
> ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a
>
>
> Diff: https://reviews.apache.org/r/63221/diff/1/
>
>
> Testing
> -------
>
> Checked in my vagrant and now it works.
>
> ```
> ? ./gradlew ui:lint
> ? ./gradlew ui:test
> ```
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63221: reload instance page once a neighbor item is
clicked
Posted by Reza Motamedi <re...@gmail.com>.
> On Oct. 23, 2017, 7:47 p.m., David McLaughlin wrote:
> > ui/src/main/js/pages/Instance.js
> > Line 34 (original), 38 (patched)
> > <https://reviews.apache.org/r/63221/diff/1/?file=1865800#file1865800line39>
> >
> > enzyme allows you to update props, you can most likely test that when you update the URL that the mock APIs are called (see apiSpy in the existing tests).
The test that I added checks of the api's `getTasksWithoutConfigs` is called once new params are provided.
> On Oct. 23, 2017, 7:47 p.m., David McLaughlin wrote:
> > ui/src/main/js/pages/Instance.js
> > Lines 55 (patched)
> > <https://reviews.apache.org/r/63221/diff/1/?file=1865800#file1865800line56>
> >
> > I don't think this is related to the previous check. They should be independent if statements.
Make sense! done!
> On Oct. 23, 2017, 7:47 p.m., David McLaughlin wrote:
> > ui/src/main/js/pages/Instance.js
> > Lines 56 (patched)
> > <https://reviews.apache.org/r/63221/diff/1/?file=1865800#file1865800line57>
> >
> > Note that params is an object. So this is just testing for reference equality - this means you could have both false negatives and false positives here. You probably want something like the npm module "deep-equal".
Done.
> On Oct. 23, 2017, 7:47 p.m., David McLaughlin wrote:
> > ui/src/main/js/pages/Instance.js
> > Lines 58 (patched)
> > <https://reviews.apache.org/r/63221/diff/1/?file=1865800#file1865800line59>
> >
> > Extra initialState to a variable and use it here and in constructor?
Done!
- Reza
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63221/#review188979
-----------------------------------------------------------
On Oct. 23, 2017, 6:01 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63221/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2017, 6:01 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Kai Huang.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> reload instance page once a neighbor item is clicked
>
>
> Diffs
> -----
>
> ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a
>
>
> Diff: https://reviews.apache.org/r/63221/diff/1/
>
>
> Testing
> -------
>
> Checked in my vagrant and now it works.
>
> ```
> ? ./gradlew ui:lint
> ? ./gradlew ui:test
> ```
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63221: reload instance page once a neighbor item is
clicked
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63221/#review188979
-----------------------------------------------------------
ui/src/main/js/pages/Instance.js
Line 34 (original), 38 (patched)
<https://reviews.apache.org/r/63221/#comment265918>
enzyme allows you to update props, you can most likely test that when you update the URL that the mock APIs are called (see apiSpy in the existing tests).
ui/src/main/js/pages/Instance.js
Lines 55 (patched)
<https://reviews.apache.org/r/63221/#comment265917>
I don't think this is related to the previous check. They should be independent if statements.
ui/src/main/js/pages/Instance.js
Lines 56 (patched)
<https://reviews.apache.org/r/63221/#comment265919>
Note that params is an object. So this is just testing for reference equality - this means you could have both false negatives and false positives here. You probably want something like the npm module "deep-equal".
ui/src/main/js/pages/Instance.js
Lines 58 (patched)
<https://reviews.apache.org/r/63221/#comment265916>
Extra initialState to a variable and use it here and in constructor?
- David McLaughlin
On Oct. 23, 2017, 6:01 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63221/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2017, 6:01 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Kai Huang.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> reload instance page once a neighbor item is clicked
>
>
> Diffs
> -----
>
> ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a
>
>
> Diff: https://reviews.apache.org/r/63221/diff/1/
>
>
> Testing
> -------
>
> Checked in my vagrant and now it works.
>
> ```
> ? ./gradlew ui:lint
> ? ./gradlew ui:test
> ```
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63221: reload instance page once a neighbor item is
clicked
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63221/#review189014
-----------------------------------------------------------
Ship it!
Master (a673c5b) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Oct. 24, 2017, 12:09 a.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63221/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2017, 12:09 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Kai Huang.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> reload instance page once a neighbor item is clicked
>
>
> Diffs
> -----
>
> ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a
> ui/src/main/js/pages/__tests__/Instance-test.js 2395e2e1018d19604a76eddee15f58565f988e3a
>
>
> Diff: https://reviews.apache.org/r/63221/diff/3/
>
>
> Testing
> -------
>
> Checked in my vagrant and now it works.
>
> ```
> ? ./gradlew ui:lint
> ? ./gradlew ui:test
> ```
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63221: reload instance page once a neighbor item is
clicked
Posted by David McLaughlin <da...@dmclaughlin.com>.
> On Oct. 24, 2017, 10:40 p.m., David McLaughlin wrote:
> > ui/src/main/js/pages/Instance.js
> > Lines 2 (patched)
> > <https://reviews.apache.org/r/63221/diff/3/?file=1865983#file1865983line2>
> >
> > I don't see this dependency in package.json. If the build is green, that means this code path is likely untested.
> >
> > Also, why did you go for lodash vs deep-equal?
>
> Reza Motamedi wrote:
> I was testing in vagrant and this works. Not sure why it works, perhaps one of our dependencies already depends on this?
> I did not have a particular reason for picking `lodash`. It seems to a more popular module.
>
> I will use `deep-equal` it is already available in the dependency list.
Ah, that makes sense. But we shouldn't depend on transitive dependencies. You can use npm install --save whenever you install a dependency to take care of writing your dependencies into the package.json file.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63221/#review189110
-----------------------------------------------------------
On Oct. 24, 2017, 12:09 a.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63221/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2017, 12:09 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Kai Huang.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> reload instance page once a neighbor item is clicked
>
>
> Diffs
> -----
>
> ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a
> ui/src/main/js/pages/__tests__/Instance-test.js 2395e2e1018d19604a76eddee15f58565f988e3a
>
>
> Diff: https://reviews.apache.org/r/63221/diff/3/
>
>
> Testing
> -------
>
> Checked in my vagrant and now it works.
>
> ```
> ? ./gradlew ui:lint
> ? ./gradlew ui:test
> ```
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63221: reload instance page once a neighbor item is
clicked
Posted by Reza Motamedi <re...@gmail.com>.
> On Oct. 24, 2017, 10:40 p.m., David McLaughlin wrote:
> > ui/src/main/js/pages/Instance.js
> > Lines 2 (patched)
> > <https://reviews.apache.org/r/63221/diff/3/?file=1865983#file1865983line2>
> >
> > I don't see this dependency in package.json. If the build is green, that means this code path is likely untested.
> >
> > Also, why did you go for lodash vs deep-equal?
I was testing in vagrant and this works. Not sure why it works, perhaps one of our dependencies already depends on this?
I did not have a particular reason for picking `lodash`. It seems to a more popular module.
I will use `deep-equal` it is already available in the dependency list.
- Reza
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63221/#review189110
-----------------------------------------------------------
On Oct. 24, 2017, 12:09 a.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63221/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2017, 12:09 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Kai Huang.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> reload instance page once a neighbor item is clicked
>
>
> Diffs
> -----
>
> ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a
> ui/src/main/js/pages/__tests__/Instance-test.js 2395e2e1018d19604a76eddee15f58565f988e3a
>
>
> Diff: https://reviews.apache.org/r/63221/diff/3/
>
>
> Testing
> -------
>
> Checked in my vagrant and now it works.
>
> ```
> ? ./gradlew ui:lint
> ? ./gradlew ui:test
> ```
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63221: reload instance page once a neighbor item is
clicked
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63221/#review189110
-----------------------------------------------------------
ui/src/main/js/pages/Instance.js
Lines 2 (patched)
<https://reviews.apache.org/r/63221/#comment266031>
I don't see this dependency in package.json. If the build is green, that means this code path is likely untested.
Also, why did you go for lodash vs deep-equal?
- David McLaughlin
On Oct. 24, 2017, 12:09 a.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63221/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2017, 12:09 a.m.)
>
>
> Review request for Aurora, David McLaughlin and Kai Huang.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> reload instance page once a neighbor item is clicked
>
>
> Diffs
> -----
>
> ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a
> ui/src/main/js/pages/__tests__/Instance-test.js 2395e2e1018d19604a76eddee15f58565f988e3a
>
>
> Diff: https://reviews.apache.org/r/63221/diff/3/
>
>
> Testing
> -------
>
> Checked in my vagrant and now it works.
>
> ```
> ? ./gradlew ui:lint
> ? ./gradlew ui:test
> ```
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63221: reload instance page once a neighbor item is
clicked
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63221/#review189256
-----------------------------------------------------------
This is shipped to master.
- David McLaughlin
On Oct. 25, 2017, 10:26 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63221/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2017, 10:26 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Kai Huang.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Reload instance page once a neighbor item is clicked
>
>
> Diffs
> -----
>
> ui/package.json 0651fc74e891149c6d83d5b16f591a3df3c330a8
> ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a
> ui/src/main/js/pages/__tests__/Instance-test.js 2395e2e1018d19604a76eddee15f58565f988e3a
>
>
> Diff: https://reviews.apache.org/r/63221/diff/5/
>
>
> Testing
> -------
>
> Tested in vagrant tunneled to a test cluster and it works!
>
> ```
> # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:neighbors-ui ? [14:08:10]
> ? ./gradlew ui:lint
>
> > Task :ui:lint
>
> > apache-aurora@1.0.0 lint /Users/rmotamedi/oss/aurora/ui
> > eslint src/main/js plugin/ --ext .js
>
>
> BUILD SUCCESSFUL in 12s
> 3 actionable tasks: 1 executed, 2 up-to-date
>
> # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:neighbors-ui ? [14:08:26]
> ? ./gradlew ui:test
>
> > Task :ui:test
>
> > apache-aurora@1.0.0 test /Users/rmotamedi/oss/aurora/ui
> > jest src/ plugin/
>
> PASS src/main/js/components/__tests__/TaskList-test.js
> PASS src/main/js/pages/__tests__/Job-test.js
> PASS src/main/js/components/__tests__/InstanceViz-test.js
> PASS src/main/js/pages/__tests__/Home-test.js
> PASS src/main/js/components/__tests__/InstanceHistoryItem-test.js
> PASS src/main/js/pages/__tests__/Jobs-test.js
> PASS src/main/js/pages/__tests__/Updates-test.js
> PASS src/main/js/components/__tests__/Pagination-test.js
> PASS src/main/js/components/__tests__/JobHistory-test.js
> PASS src/main/js/components/__tests__/Diff-test.js
> PASS src/main/js/pages/__tests__/Update-test.js
> PASS src/main/js/utils/__tests__/Common-test.js
> PASS src/main/js/components/__tests__/ConfigDiff-test.js
> PASS src/main/js/components/__tests__/TaskNeighbors-test.js
> PASS src/main/js/components/__tests__/Tabs-test.js
> PASS src/main/js/components/__tests__/UpdateDiff-test.js
> PASS src/main/js/utils/__tests__/Update-test.js
> PASS src/main/js/pages/__tests__/Instance-test.js
> PASS src/main/js/components/__tests__/StateMachine-test.js
> PASS src/main/js/components/__tests__/UpdateInstanceEvents-test.js
> PASS src/main/js/components/__tests__/JobConfig-test.js
> PASS src/main/js/components/__tests__/JobList-test.js
> PASS src/main/js/components/__tests__/UpdateStatus-test.js
> PASS src/main/js/components/__tests__/Breadcrumb-test.js
> PASS src/main/js/components/__tests__/InstanceHistory-test.js
> PASS src/main/js/components/__tests__/JobStatus-test.js
> PASS src/main/js/utils/__tests__/Task-test.js
> PASS src/main/js/components/__tests__/RoleQuota-test.js
> PASS src/main/js/components/__tests__/UpdateList-test.js
> PASS src/main/js/test-utils/__tests__/Builder-test.js
>
> Test Suites: 30 passed, 30 total
> Tests: 134 passed, 134 total
> Snapshots: 0 total
> Time: 6.883s
> Ran all test suites matching /src\/|plugin\//i.
>
>
> BUILD SUCCESSFUL in 9s
> 2 actionable tasks: 1 executed, 1 up-to-date
> ```
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63221: reload instance page once a neighbor item is
clicked
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63221/#review189255
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On Oct. 25, 2017, 10:26 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63221/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2017, 10:26 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Kai Huang.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Reload instance page once a neighbor item is clicked
>
>
> Diffs
> -----
>
> ui/package.json 0651fc74e891149c6d83d5b16f591a3df3c330a8
> ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a
> ui/src/main/js/pages/__tests__/Instance-test.js 2395e2e1018d19604a76eddee15f58565f988e3a
>
>
> Diff: https://reviews.apache.org/r/63221/diff/5/
>
>
> Testing
> -------
>
> Tested in vagrant tunneled to a test cluster and it works!
>
> ```
> # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:neighbors-ui ? [14:08:10]
> ? ./gradlew ui:lint
>
> > Task :ui:lint
>
> > apache-aurora@1.0.0 lint /Users/rmotamedi/oss/aurora/ui
> > eslint src/main/js plugin/ --ext .js
>
>
> BUILD SUCCESSFUL in 12s
> 3 actionable tasks: 1 executed, 2 up-to-date
>
> # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:neighbors-ui ? [14:08:26]
> ? ./gradlew ui:test
>
> > Task :ui:test
>
> > apache-aurora@1.0.0 test /Users/rmotamedi/oss/aurora/ui
> > jest src/ plugin/
>
> PASS src/main/js/components/__tests__/TaskList-test.js
> PASS src/main/js/pages/__tests__/Job-test.js
> PASS src/main/js/components/__tests__/InstanceViz-test.js
> PASS src/main/js/pages/__tests__/Home-test.js
> PASS src/main/js/components/__tests__/InstanceHistoryItem-test.js
> PASS src/main/js/pages/__tests__/Jobs-test.js
> PASS src/main/js/pages/__tests__/Updates-test.js
> PASS src/main/js/components/__tests__/Pagination-test.js
> PASS src/main/js/components/__tests__/JobHistory-test.js
> PASS src/main/js/components/__tests__/Diff-test.js
> PASS src/main/js/pages/__tests__/Update-test.js
> PASS src/main/js/utils/__tests__/Common-test.js
> PASS src/main/js/components/__tests__/ConfigDiff-test.js
> PASS src/main/js/components/__tests__/TaskNeighbors-test.js
> PASS src/main/js/components/__tests__/Tabs-test.js
> PASS src/main/js/components/__tests__/UpdateDiff-test.js
> PASS src/main/js/utils/__tests__/Update-test.js
> PASS src/main/js/pages/__tests__/Instance-test.js
> PASS src/main/js/components/__tests__/StateMachine-test.js
> PASS src/main/js/components/__tests__/UpdateInstanceEvents-test.js
> PASS src/main/js/components/__tests__/JobConfig-test.js
> PASS src/main/js/components/__tests__/JobList-test.js
> PASS src/main/js/components/__tests__/UpdateStatus-test.js
> PASS src/main/js/components/__tests__/Breadcrumb-test.js
> PASS src/main/js/components/__tests__/InstanceHistory-test.js
> PASS src/main/js/components/__tests__/JobStatus-test.js
> PASS src/main/js/utils/__tests__/Task-test.js
> PASS src/main/js/components/__tests__/RoleQuota-test.js
> PASS src/main/js/components/__tests__/UpdateList-test.js
> PASS src/main/js/test-utils/__tests__/Builder-test.js
>
> Test Suites: 30 passed, 30 total
> Tests: 134 passed, 134 total
> Snapshots: 0 total
> Time: 6.883s
> Ran all test suites matching /src\/|plugin\//i.
>
>
> BUILD SUCCESSFUL in 9s
> 2 actionable tasks: 1 executed, 1 up-to-date
> ```
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63221: reload instance page once a neighbor item is
clicked
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63221/
-----------------------------------------------------------
(Updated Oct. 25, 2017, 10:26 p.m.)
Review request for Aurora, David McLaughlin and Kai Huang.
Changes
-------
- moved deep-equal from `dev-dependencies` to `dependencies`
Repository: aurora
Description
-------
# Reload instance page once a neighbor item is clicked
Diffs (updated)
-----
ui/package.json 0651fc74e891149c6d83d5b16f591a3df3c330a8
ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a
ui/src/main/js/pages/__tests__/Instance-test.js 2395e2e1018d19604a76eddee15f58565f988e3a
Diff: https://reviews.apache.org/r/63221/diff/5/
Changes: https://reviews.apache.org/r/63221/diff/4-5/
Testing
-------
Tested in vagrant tunneled to a test cluster and it works!
```
# rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:neighbors-ui ? [14:08:10]
? ./gradlew ui:lint
> Task :ui:lint
> apache-aurora@1.0.0 lint /Users/rmotamedi/oss/aurora/ui
> eslint src/main/js plugin/ --ext .js
BUILD SUCCESSFUL in 12s
3 actionable tasks: 1 executed, 2 up-to-date
# rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:neighbors-ui ? [14:08:26]
? ./gradlew ui:test
> Task :ui:test
> apache-aurora@1.0.0 test /Users/rmotamedi/oss/aurora/ui
> jest src/ plugin/
PASS src/main/js/components/__tests__/TaskList-test.js
PASS src/main/js/pages/__tests__/Job-test.js
PASS src/main/js/components/__tests__/InstanceViz-test.js
PASS src/main/js/pages/__tests__/Home-test.js
PASS src/main/js/components/__tests__/InstanceHistoryItem-test.js
PASS src/main/js/pages/__tests__/Jobs-test.js
PASS src/main/js/pages/__tests__/Updates-test.js
PASS src/main/js/components/__tests__/Pagination-test.js
PASS src/main/js/components/__tests__/JobHistory-test.js
PASS src/main/js/components/__tests__/Diff-test.js
PASS src/main/js/pages/__tests__/Update-test.js
PASS src/main/js/utils/__tests__/Common-test.js
PASS src/main/js/components/__tests__/ConfigDiff-test.js
PASS src/main/js/components/__tests__/TaskNeighbors-test.js
PASS src/main/js/components/__tests__/Tabs-test.js
PASS src/main/js/components/__tests__/UpdateDiff-test.js
PASS src/main/js/utils/__tests__/Update-test.js
PASS src/main/js/pages/__tests__/Instance-test.js
PASS src/main/js/components/__tests__/StateMachine-test.js
PASS src/main/js/components/__tests__/UpdateInstanceEvents-test.js
PASS src/main/js/components/__tests__/JobConfig-test.js
PASS src/main/js/components/__tests__/JobList-test.js
PASS src/main/js/components/__tests__/UpdateStatus-test.js
PASS src/main/js/components/__tests__/Breadcrumb-test.js
PASS src/main/js/components/__tests__/InstanceHistory-test.js
PASS src/main/js/components/__tests__/JobStatus-test.js
PASS src/main/js/utils/__tests__/Task-test.js
PASS src/main/js/components/__tests__/RoleQuota-test.js
PASS src/main/js/components/__tests__/UpdateList-test.js
PASS src/main/js/test-utils/__tests__/Builder-test.js
Test Suites: 30 passed, 30 total
Tests: 134 passed, 134 total
Snapshots: 0 total
Time: 6.883s
Ran all test suites matching /src\/|plugin\//i.
BUILD SUCCESSFUL in 9s
2 actionable tasks: 1 executed, 1 up-to-date
```
Thanks,
Reza Motamedi
Re: Review Request 63221: reload instance page once a neighbor item is
clicked
Posted by Reza Motamedi <re...@gmail.com>.
> On Oct. 25, 2017, 9:54 p.m., David McLaughlin wrote:
> > Looks good. Please also move deep-equal from "devDependencies" to "dependencies" in package.json.
Done.
- Reza
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63221/#review189250
-----------------------------------------------------------
On Oct. 25, 2017, 10:26 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63221/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2017, 10:26 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Kai Huang.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Reload instance page once a neighbor item is clicked
>
>
> Diffs
> -----
>
> ui/package.json 0651fc74e891149c6d83d5b16f591a3df3c330a8
> ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a
> ui/src/main/js/pages/__tests__/Instance-test.js 2395e2e1018d19604a76eddee15f58565f988e3a
>
>
> Diff: https://reviews.apache.org/r/63221/diff/5/
>
>
> Testing
> -------
>
> Tested in vagrant tunneled to a test cluster and it works!
>
> ```
> # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:neighbors-ui ? [14:08:10]
> ? ./gradlew ui:lint
>
> > Task :ui:lint
>
> > apache-aurora@1.0.0 lint /Users/rmotamedi/oss/aurora/ui
> > eslint src/main/js plugin/ --ext .js
>
>
> BUILD SUCCESSFUL in 12s
> 3 actionable tasks: 1 executed, 2 up-to-date
>
> # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:neighbors-ui ? [14:08:26]
> ? ./gradlew ui:test
>
> > Task :ui:test
>
> > apache-aurora@1.0.0 test /Users/rmotamedi/oss/aurora/ui
> > jest src/ plugin/
>
> PASS src/main/js/components/__tests__/TaskList-test.js
> PASS src/main/js/pages/__tests__/Job-test.js
> PASS src/main/js/components/__tests__/InstanceViz-test.js
> PASS src/main/js/pages/__tests__/Home-test.js
> PASS src/main/js/components/__tests__/InstanceHistoryItem-test.js
> PASS src/main/js/pages/__tests__/Jobs-test.js
> PASS src/main/js/pages/__tests__/Updates-test.js
> PASS src/main/js/components/__tests__/Pagination-test.js
> PASS src/main/js/components/__tests__/JobHistory-test.js
> PASS src/main/js/components/__tests__/Diff-test.js
> PASS src/main/js/pages/__tests__/Update-test.js
> PASS src/main/js/utils/__tests__/Common-test.js
> PASS src/main/js/components/__tests__/ConfigDiff-test.js
> PASS src/main/js/components/__tests__/TaskNeighbors-test.js
> PASS src/main/js/components/__tests__/Tabs-test.js
> PASS src/main/js/components/__tests__/UpdateDiff-test.js
> PASS src/main/js/utils/__tests__/Update-test.js
> PASS src/main/js/pages/__tests__/Instance-test.js
> PASS src/main/js/components/__tests__/StateMachine-test.js
> PASS src/main/js/components/__tests__/UpdateInstanceEvents-test.js
> PASS src/main/js/components/__tests__/JobConfig-test.js
> PASS src/main/js/components/__tests__/JobList-test.js
> PASS src/main/js/components/__tests__/UpdateStatus-test.js
> PASS src/main/js/components/__tests__/Breadcrumb-test.js
> PASS src/main/js/components/__tests__/InstanceHistory-test.js
> PASS src/main/js/components/__tests__/JobStatus-test.js
> PASS src/main/js/utils/__tests__/Task-test.js
> PASS src/main/js/components/__tests__/RoleQuota-test.js
> PASS src/main/js/components/__tests__/UpdateList-test.js
> PASS src/main/js/test-utils/__tests__/Builder-test.js
>
> Test Suites: 30 passed, 30 total
> Tests: 134 passed, 134 total
> Snapshots: 0 total
> Time: 6.883s
> Ran all test suites matching /src\/|plugin\//i.
>
>
> BUILD SUCCESSFUL in 9s
> 2 actionable tasks: 1 executed, 1 up-to-date
> ```
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63221: reload instance page once a neighbor item is
clicked
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63221/#review189250
-----------------------------------------------------------
Looks good. Please also move deep-equal from "devDependencies" to "dependencies" in package.json.
- David McLaughlin
On Oct. 25, 2017, 9:51 p.m., Reza Motamedi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63221/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2017, 9:51 p.m.)
>
>
> Review request for Aurora, David McLaughlin and Kai Huang.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> # Reload instance page once a neighbor item is clicked
>
>
> Diffs
> -----
>
> ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a
> ui/src/main/js/pages/__tests__/Instance-test.js 2395e2e1018d19604a76eddee15f58565f988e3a
>
>
> Diff: https://reviews.apache.org/r/63221/diff/4/
>
>
> Testing
> -------
>
> Tested in vagrant tunneled to a test cluster and it works!
>
> ```
> # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:neighbors-ui ? [14:08:10]
> ? ./gradlew ui:lint
>
> > Task :ui:lint
>
> > apache-aurora@1.0.0 lint /Users/rmotamedi/oss/aurora/ui
> > eslint src/main/js plugin/ --ext .js
>
>
> BUILD SUCCESSFUL in 12s
> 3 actionable tasks: 1 executed, 2 up-to-date
>
> # rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:neighbors-ui ? [14:08:26]
> ? ./gradlew ui:test
>
> > Task :ui:test
>
> > apache-aurora@1.0.0 test /Users/rmotamedi/oss/aurora/ui
> > jest src/ plugin/
>
> PASS src/main/js/components/__tests__/TaskList-test.js
> PASS src/main/js/pages/__tests__/Job-test.js
> PASS src/main/js/components/__tests__/InstanceViz-test.js
> PASS src/main/js/pages/__tests__/Home-test.js
> PASS src/main/js/components/__tests__/InstanceHistoryItem-test.js
> PASS src/main/js/pages/__tests__/Jobs-test.js
> PASS src/main/js/pages/__tests__/Updates-test.js
> PASS src/main/js/components/__tests__/Pagination-test.js
> PASS src/main/js/components/__tests__/JobHistory-test.js
> PASS src/main/js/components/__tests__/Diff-test.js
> PASS src/main/js/pages/__tests__/Update-test.js
> PASS src/main/js/utils/__tests__/Common-test.js
> PASS src/main/js/components/__tests__/ConfigDiff-test.js
> PASS src/main/js/components/__tests__/TaskNeighbors-test.js
> PASS src/main/js/components/__tests__/Tabs-test.js
> PASS src/main/js/components/__tests__/UpdateDiff-test.js
> PASS src/main/js/utils/__tests__/Update-test.js
> PASS src/main/js/pages/__tests__/Instance-test.js
> PASS src/main/js/components/__tests__/StateMachine-test.js
> PASS src/main/js/components/__tests__/UpdateInstanceEvents-test.js
> PASS src/main/js/components/__tests__/JobConfig-test.js
> PASS src/main/js/components/__tests__/JobList-test.js
> PASS src/main/js/components/__tests__/UpdateStatus-test.js
> PASS src/main/js/components/__tests__/Breadcrumb-test.js
> PASS src/main/js/components/__tests__/InstanceHistory-test.js
> PASS src/main/js/components/__tests__/JobStatus-test.js
> PASS src/main/js/utils/__tests__/Task-test.js
> PASS src/main/js/components/__tests__/RoleQuota-test.js
> PASS src/main/js/components/__tests__/UpdateList-test.js
> PASS src/main/js/test-utils/__tests__/Builder-test.js
>
> Test Suites: 30 passed, 30 total
> Tests: 134 passed, 134 total
> Snapshots: 0 total
> Time: 6.883s
> Ran all test suites matching /src\/|plugin\//i.
>
>
> BUILD SUCCESSFUL in 9s
> 2 actionable tasks: 1 executed, 1 up-to-date
> ```
>
>
> Thanks,
>
> Reza Motamedi
>
>
Re: Review Request 63221: reload instance page once a neighbor item is
clicked
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63221/
-----------------------------------------------------------
(Updated Oct. 25, 2017, 9:51 p.m.)
Review request for Aurora, David McLaughlin and Kai Huang.
Changes
-------
- Using deep-equal instead of lodash for comparing objects.
Repository: aurora
Description (updated)
-------
# Reload instance page once a neighbor item is clicked
Diffs (updated)
-----
ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a
ui/src/main/js/pages/__tests__/Instance-test.js 2395e2e1018d19604a76eddee15f58565f988e3a
Diff: https://reviews.apache.org/r/63221/diff/4/
Changes: https://reviews.apache.org/r/63221/diff/3-4/
Testing (updated)
-------
Tested in vagrant tunneled to a test cluster and it works!
```
# rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:neighbors-ui ? [14:08:10]
? ./gradlew ui:lint
> Task :ui:lint
> apache-aurora@1.0.0 lint /Users/rmotamedi/oss/aurora/ui
> eslint src/main/js plugin/ --ext .js
BUILD SUCCESSFUL in 12s
3 actionable tasks: 1 executed, 2 up-to-date
# rmotamedi@tw-mbp-rmotamedi:~/oss/aurora on git:neighbors-ui ? [14:08:26]
? ./gradlew ui:test
> Task :ui:test
> apache-aurora@1.0.0 test /Users/rmotamedi/oss/aurora/ui
> jest src/ plugin/
PASS src/main/js/components/__tests__/TaskList-test.js
PASS src/main/js/pages/__tests__/Job-test.js
PASS src/main/js/components/__tests__/InstanceViz-test.js
PASS src/main/js/pages/__tests__/Home-test.js
PASS src/main/js/components/__tests__/InstanceHistoryItem-test.js
PASS src/main/js/pages/__tests__/Jobs-test.js
PASS src/main/js/pages/__tests__/Updates-test.js
PASS src/main/js/components/__tests__/Pagination-test.js
PASS src/main/js/components/__tests__/JobHistory-test.js
PASS src/main/js/components/__tests__/Diff-test.js
PASS src/main/js/pages/__tests__/Update-test.js
PASS src/main/js/utils/__tests__/Common-test.js
PASS src/main/js/components/__tests__/ConfigDiff-test.js
PASS src/main/js/components/__tests__/TaskNeighbors-test.js
PASS src/main/js/components/__tests__/Tabs-test.js
PASS src/main/js/components/__tests__/UpdateDiff-test.js
PASS src/main/js/utils/__tests__/Update-test.js
PASS src/main/js/pages/__tests__/Instance-test.js
PASS src/main/js/components/__tests__/StateMachine-test.js
PASS src/main/js/components/__tests__/UpdateInstanceEvents-test.js
PASS src/main/js/components/__tests__/JobConfig-test.js
PASS src/main/js/components/__tests__/JobList-test.js
PASS src/main/js/components/__tests__/UpdateStatus-test.js
PASS src/main/js/components/__tests__/Breadcrumb-test.js
PASS src/main/js/components/__tests__/InstanceHistory-test.js
PASS src/main/js/components/__tests__/JobStatus-test.js
PASS src/main/js/utils/__tests__/Task-test.js
PASS src/main/js/components/__tests__/RoleQuota-test.js
PASS src/main/js/components/__tests__/UpdateList-test.js
PASS src/main/js/test-utils/__tests__/Builder-test.js
Test Suites: 30 passed, 30 total
Tests: 134 passed, 134 total
Snapshots: 0 total
Time: 6.883s
Ran all test suites matching /src\/|plugin\//i.
BUILD SUCCESSFUL in 9s
2 actionable tasks: 1 executed, 1 up-to-date
```
Thanks,
Reza Motamedi
Re: Review Request 63221: reload instance page once a neighbor item is
clicked
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63221/
-----------------------------------------------------------
(Updated Oct. 24, 2017, 12:09 a.m.)
Review request for Aurora, David McLaughlin and Kai Huang.
Changes
-------
Fixing an import issue.
Repository: aurora
Description
-------
reload instance page once a neighbor item is clicked
Diffs (updated)
-----
ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a
ui/src/main/js/pages/__tests__/Instance-test.js 2395e2e1018d19604a76eddee15f58565f988e3a
Diff: https://reviews.apache.org/r/63221/diff/3/
Changes: https://reviews.apache.org/r/63221/diff/2-3/
Testing
-------
Checked in my vagrant and now it works.
```
? ./gradlew ui:lint
? ./gradlew ui:test
```
Thanks,
Reza Motamedi
Re: Review Request 63221: reload instance page once a neighbor item is
clicked
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63221/
-----------------------------------------------------------
(Updated Oct. 24, 2017, midnight)
Review request for Aurora, David McLaughlin and Kai Huang.
Repository: aurora
Description
-------
reload instance page once a neighbor item is clicked
Diffs (updated)
-----
ui/src/main/js/pages/Instance.js 4b855457c36e180c0ade629f58e8a03b1273a67a
ui/src/main/js/pages/__tests__/Instance-test.js 2395e2e1018d19604a76eddee15f58565f988e3a
Diff: https://reviews.apache.org/r/63221/diff/2/
Changes: https://reviews.apache.org/r/63221/diff/1-2/
Testing
-------
Checked in my vagrant and now it works.
```
? ./gradlew ui:lint
? ./gradlew ui:test
```
Thanks,
Reza Motamedi