You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2017/02/22 20:09:38 UTC
[kudu-CR] [docs] added info on TSK an CA entries in systable
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6111
Change subject: [docs] added info on TSK an CA entries in systable
......................................................................
[docs] added info on TSK an CA entries in systable
Change-Id: I3c75d792981c3152f5844a2ea6934c0ce0032522
---
M docs/design-docs/master.md
1 file changed, 23 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/6111/1
--
To view, visit http://gerrit.cloudera.org:8080/6111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c75d792981c3152f5844a2ea6934c0ce0032522
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [docs] added info on TSK an CA entries in systable
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [docs] added info on TSK an CA entries in systable
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6111/1/docs/design-docs/master.md
File docs/design-docs/master.md:
PS1, Line 244: root CA certificate
> I'm not sure I understand which redundant part you are pointing at. 'Certi
Nope, I'm just not that well versed in this security stuff, thanks for the explanation.
--
To view, visit http://gerrit.cloudera.org:8080/6111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c75d792981c3152f5844a2ea6934c0ce0032522
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [docs] added info on TSK an CA entries in systable
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [docs] added info on TSK an CA entries in systable
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6111/1/docs/design-docs/master.md
File docs/design-docs/master.md:
Line 107: A "Cleaner" process is responsible for removing the data from deleted tables
> ok, I'll remove this TODO and turn the sentence into the present tense.
It's not quite right though; tablet data deletion is done synchronously in the DeleteTablet RPC. There's no asynchronous "cleaner".
http://gerrit.cloudera.org:8080/#/c/6111/2/docs/design-docs/master.md
File docs/design-docs/master.md:
PS2, Line 244: contains root
"contains a root" or "contains the root"
PS2, Line 246: security
Let's be more specific; this is for authn, right?
--
To view, visit http://gerrit.cloudera.org:8080/6111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c75d792981c3152f5844a2ea6934c0ce0032522
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [docs] added info on TSK an CA entries in systable
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6111
to look at the new patch set (#2).
Change subject: [docs] added info on TSK an CA entries in systable
......................................................................
[docs] added info on TSK an CA entries in systable
Change-Id: I3c75d792981c3152f5844a2ea6934c0ce0032522
---
M docs/design-docs/master.md
1 file changed, 24 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/6111/2
--
To view, visit http://gerrit.cloudera.org:8080/6111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c75d792981c3152f5844a2ea6934c0ce0032522
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [docs] added info on TSK an CA entries in systable
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [docs] added info on TSK an CA entries in systable
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/6111/1/docs/design-docs/master.md
File docs/design-docs/master.md:
Line 107: A "Cleaner" process will be responsible for removing the data from deleted tables
> Pretty sure we're handling this correctly now?
ok, I'll remove this TODO and turn the sentence into the present tense.
PS1, Line 244: root CA certificate
> Isn't that redundant? root Certificate Authority certificate
I'm not sure I understand which redundant part you are pointing at. 'Certificate Authority certificate' means the certificate which is used to verify that some other certificate (like server cert) is signed with corresponding private key.
'Root' means we use our own cert chain and our CA is not a subordinate one.
'Certificate Authority' is just an entity authorized to issue X509 certificates. We authorized some component of leader master server to act as CA :)
I think 'root CA certificate' is not redundant. Let me know if you feel strong about this -- probably we can re-phrase it somehow.
PS1, Line 249: yet
> Seems redundant.
Done
PS1, Line 250: the
> remove
Done
--
To view, visit http://gerrit.cloudera.org:8080/6111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c75d792981c3152f5844a2ea6934c0ce0032522
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [docs] added info on TSK an CA entries in systable
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: [docs] added info on TSK an CA entries in systable
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/6111/1/docs/design-docs/master.md
File docs/design-docs/master.md:
Line 107: A "Cleaner" process will be responsible for removing the data from deleted tables
Pretty sure we're handling this correctly now?
PS1, Line 244: root CA certificate
Isn't that redundant? root Certificate Authority certificate
PS1, Line 249: yet
Seems redundant.
PS1, Line 250: the
remove
--
To view, visit http://gerrit.cloudera.org:8080/6111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c75d792981c3152f5844a2ea6934c0ce0032522
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [docs] added info on TSK an CA entries in systable
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [docs] added info on TSK an CA entries in systable
......................................................................
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6111/1/docs/design-docs/master.md
File docs/design-docs/master.md:
Line 107: A "Cleaner" process is responsible for removing the data from deleted tables
> It's not quite right though; tablet data deletion is done synchronously in
All right, then I'll just remove this sentence. Yep, I remember the data is deleted from the system table in a synchronous way, and then the 'cleaner' updates the metadata in memory.
http://gerrit.cloudera.org:8080/#/c/6111/2/docs/design-docs/master.md
File docs/design-docs/master.md:
PS2, Line 244: contains root
> "contains a root" or "contains the root"
Done
PS2, Line 246: security
> Let's be more specific; this is for authn, right?
This sounds good to me -- will update.
That's for signing server certificates. The CA cert (without its pairing private key) is also used by TLS connection initiators to authenticate the server side. For authn tokens we need just private keys, and they are not linked to the CA cert or CA private key at all: we just generate private/public keypairs out of thin air using OpenSSL crypto library (some system entropy is used for creating keys, though).
--
To view, visit http://gerrit.cloudera.org:8080/6111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c75d792981c3152f5844a2ea6934c0ce0032522
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] [docs] added info on TSK an CA entries in systable
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6111
to look at the new patch set (#4).
Change subject: [docs] added info on TSK an CA entries in systable
......................................................................
[docs] added info on TSK an CA entries in systable
Change-Id: I3c75d792981c3152f5844a2ea6934c0ce0032522
---
M docs/design-docs/master.md
1 file changed, 29 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/6111/4
--
To view, visit http://gerrit.cloudera.org:8080/6111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3c75d792981c3152f5844a2ea6934c0ce0032522
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [docs] added info on TSK an CA entries in systable
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged.
Change subject: [docs] added info on TSK an CA entries in systable
......................................................................
[docs] added info on TSK an CA entries in systable
Change-Id: I3c75d792981c3152f5844a2ea6934c0ce0032522
Reviewed-on: http://gerrit.cloudera.org:8080/6111
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M docs/design-docs/master.md
1 file changed, 29 insertions(+), 3 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c75d792981c3152f5844a2ea6934c0ce0032522
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [docs] added info on TSK an CA entries in systable
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [docs] added info on TSK an CA entries in systable
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c75d792981c3152f5844a2ea6934c0ce0032522
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [docs] added info on TSK an CA entries in systable
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [docs] added info on TSK an CA entries in systable
......................................................................
Patch Set 4: Verified+1
Unrelated flaky MasterReplicationTest.TestCycleThroughAllMasters
--
To view, visit http://gerrit.cloudera.org:8080/6111
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3c75d792981c3152f5844a2ea6934c0ce0032522
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No