[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #12000: feat(datasets): security perm simplification

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #12000:
URL: https://github.com/apache/incubator-superset/pull/12000#discussion_r540881683



##########
File path: tests/datasets/api_tests.py
##########
@@ -1086,7 +1100,7 @@ def test_export_dataset_gamma(self):
 
         self.login(username="gamma")
         rv = self.client.get(uri)
-        assert rv.status_code == 401
+        assert rv.status_code == 404

Review comment:
       @betodealmeida export and import datasets will not need a separate permission now. import needs `can_write` on `Dataset` and export `can_read` on `Dataset`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org