You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/11/12 09:49:14 UTC

[GitHub] [incubator-kyuubi] zhouyifan279 opened a new pull request #1367: [KYUUBI #1361][FOLLOWUP] Rename kyuubi.ha.engine.session.id to kyuubi…

zhouyifan279 opened a new pull request #1367:
URL: https://github.com/apache/incubator-kyuubi/pull/1367


   ### _Why are the changes needed?_
   Rename kyuubi.ha.engine.session.id to kyuubi.ha.engine.ref.id to keep configuration key consistent between branch-1.3 and master.
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [x] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 merged pull request #1367: [KYUUBI #1361][FOLLOWUP] Rename kyuubi.ha.engine.session.id to kyuubi.ha.engine.ref.id

Posted by GitBox <gi...@apache.org>.

pan3793 merged pull request #1367:
URL: https://github.com/apache/incubator-kyuubi/pull/1367


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] zhouyifan279 commented on pull request #1367: [KYUUBI #1361][FOLLOWUP] Rename kyuubi.ha.engine.session.id to kyuubi…

Posted by GitBox <gi...@apache.org>.

zhouyifan279 commented on pull request #1367:
URL: https://github.com/apache/incubator-kyuubi/pull/1367#issuecomment-967004321


   @ulysses-you @pan3793 ready for review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #1367: [KYUUBI #1361][FOLLOWUP] Rename kyuubi.ha.engine.session.id to kyuubi.ha.engine.ref.id

Posted by GitBox <gi...@apache.org>.

pan3793 commented on pull request #1367:
URL: https://github.com/apache/incubator-kyuubi/pull/1367#issuecomment-967040996


   Since it's not designed to expose to users, I'm fine with including this change in v1.3.2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org