You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by Guillaume Nodet <gn...@gmail.com> on 2007/12/04 11:25:51 UTC
Re: svn commit: r600866 - in /servicemix/branches/servicemix-4.0: camel/ camel/src/main/java/org/apache/servicemix/camel/ camel/src/main/java/org/apache/servicemix/camel/spring/ camel/src/main/resources/META-INF/ camel/src/main/resources/schema/ came
On Dec 4, 2007 11:09 AM, <ff...@apache.org> wrote:
> Modified: servicemix/branches/servicemix-4.0
> /nmr/core/src/main/java/org/apache/servicemix/nmr/core/ServiceMix.java
> URL:
> http://svn.apache.org/viewvc/servicemix/branches/servicemix-4.0/nmr/core/src/main/java/org/apache/servicemix/nmr/core/ServiceMix.java?rev=600866&r1=600865&r2=600866&view=diff
>
> ==============================================================================
> --- servicemix/branches/servicemix-4.0/nmr/core/src/main/java/org/apache/servicemix/nmr/core/ServiceMix.java
> (original)
> +++ servicemix/branches/servicemix-4.0/nmr/core/src/main/java/org/apache/servicemix/nmr/core/ServiceMix.java
> Tue Dec 4 02:09:51 2007
> @@ -46,8 +46,9 @@
> }
> if (flows == null) {
> flows = new FlowRegistryImpl();
> - flows.register(new StraightThroughFlow(),
> ServiceHelper.createMap(Flow.ID, StraightThroughFlow.class.getName()));
> +
> }
> + flows.register(new StraightThroughFlow(), ServiceHelper.createMap
> (Flow.ID, StraightThroughFlow.class.getName()));
> }
>
> /**
>
>
>
I don't think this is a good idea. As this would prevent a proper
configuration of the STFlow by the user (or even the possibility to not use
it).
If you set your own FlowRegistry, you are responsible for populating it, but
if you let the class create it for you, it will be populated with a default
config (in this case, a StraightThroughFlow).
--
Cheers,
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
Re: svn commit: r600866 - in /servicemix/branches/servicemix-4.0: camel/ camel/src/main/java/org/apache/servicemix/camel/ camel/src/main/java/org/apache/servicemix/camel/spring/ camel/src/main/resources/META-INF/ camel/src/main/resources/schema/ came
Posted by Freeman Fang <fr...@gmail.com>.
Hi Guillaume,
You are correct, I will fix it up soon.
Best Regards
Freeman
On Dec 4, 2007 6:25 PM, Guillaume Nodet <gn...@gmail.com> wrote:
> On Dec 4, 2007 11:09 AM, <ff...@apache.org> wrote:
>
> > Modified: servicemix/branches/servicemix-4.0
> > /nmr/core/src/main/java/org/apache/servicemix/nmr/core/ServiceMix.java
> > URL:
> >
> http://svn.apache.org/viewvc/servicemix/branches/servicemix-4.0/nmr/core/src/main/java/org/apache/servicemix/nmr/core/ServiceMix.java?rev=600866&r1=600865&r2=600866&view=diff
> >
> >
> ==============================================================================
> > --- servicemix/branches/servicemix-4.0
> /nmr/core/src/main/java/org/apache/servicemix/nmr/core/ServiceMix.java
> > (original)
> > +++ servicemix/branches/servicemix-4.0
> /nmr/core/src/main/java/org/apache/servicemix/nmr/core/ServiceMix.java
> > Tue Dec 4 02:09:51 2007
> > @@ -46,8 +46,9 @@
> > }
> > if (flows == null) {
> > flows = new FlowRegistryImpl();
> > - flows.register(new StraightThroughFlow(),
> > ServiceHelper.createMap(Flow.ID, StraightThroughFlow.class.getName()));
> > +
> > }
> > + flows.register(new StraightThroughFlow(),
> ServiceHelper.createMap
> > (Flow.ID, StraightThroughFlow.class.getName()));
> > }
> >
> > /**
> >
> >
> >
> I don't think this is a good idea. As this would prevent a proper
> configuration of the STFlow by the user (or even the possibility to not
> use
> it).
> If you set your own FlowRegistry, you are responsible for populating it,
> but
> if you let the class create it for you, it will be populated with a
> default
> config (in this case, a StraightThroughFlow).
>
> --
> Cheers,
> Guillaume Nodet
> ------------------------
> Blog: http://gnodet.blogspot.com/
>