You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficcontrol.apache.org by ne...@apache.org on 2017/01/25 17:30:25 UTC
[14/20] incubator-trafficcontrol git commit: Fix TM2 compile issue,
rename health/cache.go
Fix TM2 compile issue, rename health/cache.go
Project: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/commit/3db9dd7b
Tree: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/tree/3db9dd7b
Diff: http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/diff/3db9dd7b
Branch: refs/heads/master
Commit: 3db9dd7bd952249c071bc0bec238cd6d89ef9e21
Parents: 4fec599
Author: Robert Butts <ro...@gmail.com>
Authored: Tue Jan 24 10:41:37 2017 -0700
Committer: Dave Neuman <ne...@apache.org>
Committed: Wed Jan 25 10:29:46 2017 -0700
----------------------------------------------------------------------
.../traffic_monitor/health/cache.go | 210 +++++++++++++++++++
.../traffic_monitor/health/cache_health.go | 210 -------------------
.../traffic_monitor/manager/stathistory.go | 2 +-
3 files changed, 211 insertions(+), 211 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/blob/3db9dd7b/traffic_monitor/experimental/traffic_monitor/health/cache.go
----------------------------------------------------------------------
diff --git a/traffic_monitor/experimental/traffic_monitor/health/cache.go b/traffic_monitor/experimental/traffic_monitor/health/cache.go
new file mode 100644
index 0000000..0a00838
--- /dev/null
+++ b/traffic_monitor/experimental/traffic_monitor/health/cache.go
@@ -0,0 +1,210 @@
+package health
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import (
+ "fmt"
+ "strconv"
+ "strings"
+
+ "github.com/apache/incubator-trafficcontrol/traffic_monitor/experimental/common/log"
+ "github.com/apache/incubator-trafficcontrol/traffic_monitor/experimental/traffic_monitor/cache"
+ "github.com/apache/incubator-trafficcontrol/traffic_monitor/experimental/traffic_monitor/enum"
+ "github.com/apache/incubator-trafficcontrol/traffic_monitor/experimental/traffic_monitor/peer"
+ to "github.com/apache/incubator-trafficcontrol/traffic_ops/client"
+)
+
+func setError(newResult *cache.Result, err error) {
+ newResult.Error = err
+ newResult.Available = false
+}
+
+// GetVitals Gets the vitals to decide health on in the right format
+func GetVitals(newResult *cache.Result, prevResult *cache.Result, mc *to.TrafficMonitorConfigMap) {
+ if newResult.Error != nil {
+ log.Errorf("cache_health.GetVitals() called with an errored Result!")
+ return
+ }
+ // proc.loadavg -- we're using the 1 minute average (!?)
+ // value looks like: "0.20 0.07 0.07 1/967 29536" (without the quotes)
+ loadAverages := strings.Fields(newResult.Astats.System.ProcLoadavg)
+ if len(loadAverages) > 0 {
+ oneMinAvg, err := strconv.ParseFloat(loadAverages[0], 64)
+ if err != nil {
+ setError(newResult, fmt.Errorf("Error converting load average string '%s': %v", newResult.Astats.System.ProcLoadavg, err))
+ return
+ }
+ newResult.Vitals.LoadAvg = oneMinAvg
+ } else {
+ setError(newResult, fmt.Errorf("Can't make sense of '%s' as a load average for %s", newResult.Astats.System.ProcLoadavg, newResult.ID))
+ return
+ }
+
+ // proc.net.dev -- need to compare to prevSample
+ // value looks like
+ // "bond0:8495786321839 31960528603 0 0 0 0 0 2349716 143283576747316 101104535041 0 0 0 0 0 0"
+ // (without the quotes)
+ parts := strings.Split(newResult.Astats.System.ProcNetDev, ":")
+ if len(parts) > 1 {
+ numbers := strings.Fields(parts[1])
+ var err error
+ newResult.Vitals.BytesOut, err = strconv.ParseInt(numbers[8], 10, 64)
+ if err != nil {
+ setError(newResult, fmt.Errorf("Error converting BytesOut from procnetdev: %v", err))
+ return
+ }
+ newResult.Vitals.BytesIn, err = strconv.ParseInt(numbers[0], 10, 64)
+ if err != nil {
+ setError(newResult, fmt.Errorf("Error converting BytesIn from procnetdev: %v", err))
+ return
+ }
+ if prevResult != nil && prevResult.Vitals.BytesOut != 0 {
+ elapsedTimeInSecs := float64(newResult.Time.UnixNano()-prevResult.Time.UnixNano()) / 1000000000
+ newResult.Vitals.KbpsOut = int64(float64(((newResult.Vitals.BytesOut - prevResult.Vitals.BytesOut) * 8 / 1000)) / elapsedTimeInSecs)
+ } else {
+ // log.Infoln("prevResult == nil for id " + newResult.Id + ". Hope we're just starting up?")
+ }
+ } else {
+ setError(newResult, fmt.Errorf("Error parsing procnetdev: no fields found"))
+ return
+ }
+
+ // inf.speed -- value looks like "10000" (without the quotes) so it is in Mbps.
+ // TODO JvD: Should we really be running this code every second for every cache polled????? I don't think so.
+ interfaceBandwidth := newResult.Astats.System.InfSpeed
+ newResult.Vitals.MaxKbpsOut = int64(interfaceBandwidth) * 1000
+
+ // log.Infoln(newResult.Id, "BytesOut", newResult.Vitals.BytesOut, "BytesIn", newResult.Vitals.BytesIn, "Kbps", newResult.Vitals.KbpsOut, "max", newResult.Vitals.MaxKbpsOut)
+}
+
+// EvalCache returns whether the given cache should be marked available, a string describing why, and which stat exceeded a threshold. The `stats` may be nil, for pollers which don't poll stats.
+// The availability of EvalCache MAY NOT be used to directly set the cache's local availability, because the threshold stats may not be part of the poller which produced the result. Rather, if the cache was previously unavailable from a threshold, it must be verified that threshold stat is in the results before setting the cache to available.
+// TODO change to return a `cache.AvailableStatus`
+func EvalCache(result cache.ResultInfo, resultStats cache.ResultStatValHistory, mc *to.TrafficMonitorConfigMap) (bool, string, string) {
+ serverInfo, ok := mc.TrafficServer[string(result.ID)]
+ if !ok {
+ log.Errorf("Cache %v missing from from Traffic Ops Monitor Config - treating as OFFLINE\n", result.ID)
+ return false, "ERROR - server missing in Traffic Ops monitor config", ""
+ }
+ serverProfile, ok := mc.Profile[serverInfo.Profile]
+ if !ok {
+ log.Errorf("Cache %v profile %v missing from from Traffic Ops Monitor Config - treating as OFFLINE\n", result.ID, serverInfo.Profile)
+ return false, "ERROR - server profile missing in Traffic Ops monitor config", ""
+ }
+
+ status := enum.CacheStatusFromString(serverInfo.Status)
+ if status == enum.CacheStatusInvalid {
+ log.Errorf("Cache %v got invalid status from Traffic Ops '%v' - treating as Reported\n", result.ID, serverInfo.Status)
+ }
+
+ availability := "available"
+ if !result.Available {
+ availability = "unavailable"
+ }
+
+ switch {
+ case status == enum.CacheStatusInvalid:
+ log.Errorf("Cache %v got invalid status from Traffic Ops '%v' - treating as OFFLINE\n", result.ID, serverInfo.Status)
+ return false, getEventDescription(status, availability+"; invalid status"), ""
+ case status == enum.CacheStatusAdminDown:
+ return false, getEventDescription(status, availability), ""
+ case status == enum.CacheStatusOffline:
+ log.Errorf("Cache %v set to offline, but still polled\n", result.ID)
+ return false, getEventDescription(status, availability), ""
+ case status == enum.CacheStatusOnline:
+ return true, getEventDescription(status, availability), ""
+ case result.Error != nil:
+ return false, getEventDescription(status, fmt.Sprintf("%v", result.Error)), ""
+ }
+
+ computedStats := cache.ComputedStats()
+
+ for stat, threshold := range serverProfile.Parameters.Thresholds {
+ resultStat := interface{}(nil)
+ if computedStatF, ok := computedStats[stat]; ok {
+ dummyCombinedstate := peer.IsAvailable{} // the only stats which use combinedState are things like isAvailable, which don't make sense to ever be thresholds.
+ resultStat = computedStatF(result, serverInfo, serverProfile, dummyCombinedstate)
+ } else {
+ if resultStats == nil {
+ continue
+ }
+ resultStatHistory, ok := resultStats[stat]
+ if !ok {
+ continue
+ }
+ if len(resultStatHistory) < 1 {
+ continue
+ }
+ resultStat = resultStatHistory[0].Val
+ }
+
+ resultStatNum, ok := enum.ToNumeric(resultStat)
+ if !ok {
+ log.Errorf("health.EvalCache threshold stat %s was not a number: %v", stat, resultStat)
+ continue
+ }
+
+ if !InThreshold(threshold, resultStatNum) {
+ return false, getEventDescription(status, ExceedsThresholdMsg(stat, threshold, resultStatNum)), stat
+ }
+ }
+
+ return result.Available, getEventDescription(status, availability), ""
+}
+
+// ExceedsThresholdMsg returns a human-readable message for why the given value exceeds the threshold. It does NOT check whether the value actually exceeds the threshold; call `InThreshold` to check first.
+func ExceedsThresholdMsg(stat string, threshold to.HealthThreshold, val float64) string {
+ switch threshold.Comparator {
+ case "=":
+ return fmt.Sprintf("%s not equal (%f != %f)", stat, val, threshold.Val)
+ case ">":
+ return fmt.Sprintf("%s too low (%f < %f)", stat, val, threshold.Val)
+ case "<":
+ return fmt.Sprintf("%s too high (%f > %f)", stat, val, threshold.Val)
+ case ">=":
+ return fmt.Sprintf("%s too low (%f <= %f)", stat, val, threshold.Val)
+ case "<=":
+ return fmt.Sprintf("%s too high (%f >= %f)", stat, val, threshold.Val)
+ default:
+ return fmt.Sprintf("ERROR: Invalid Threshold: %+v", threshold)
+ }
+}
+
+func InThreshold(threshold to.HealthThreshold, val float64) bool {
+ switch threshold.Comparator {
+ case "=":
+ return val == threshold.Val
+ case ">":
+ return val > threshold.Val
+ case "<":
+ return val < threshold.Val
+ case ">=":
+ return val >= threshold.Val
+ case "<=":
+ return val <= threshold.Val
+ default:
+ log.Errorf("Invalid Threshold: %+v", threshold)
+ return true // for safety, if a threshold somehow gets corrupted, don't start marking caches down.
+ }
+}
+
+func getEventDescription(status enum.CacheStatus, message string) string {
+ return fmt.Sprintf("%s - %s", status, message)
+}
http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/blob/3db9dd7b/traffic_monitor/experimental/traffic_monitor/health/cache_health.go
----------------------------------------------------------------------
diff --git a/traffic_monitor/experimental/traffic_monitor/health/cache_health.go b/traffic_monitor/experimental/traffic_monitor/health/cache_health.go
deleted file mode 100644
index 0a00838..0000000
--- a/traffic_monitor/experimental/traffic_monitor/health/cache_health.go
+++ /dev/null
@@ -1,210 +0,0 @@
-package health
-
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import (
- "fmt"
- "strconv"
- "strings"
-
- "github.com/apache/incubator-trafficcontrol/traffic_monitor/experimental/common/log"
- "github.com/apache/incubator-trafficcontrol/traffic_monitor/experimental/traffic_monitor/cache"
- "github.com/apache/incubator-trafficcontrol/traffic_monitor/experimental/traffic_monitor/enum"
- "github.com/apache/incubator-trafficcontrol/traffic_monitor/experimental/traffic_monitor/peer"
- to "github.com/apache/incubator-trafficcontrol/traffic_ops/client"
-)
-
-func setError(newResult *cache.Result, err error) {
- newResult.Error = err
- newResult.Available = false
-}
-
-// GetVitals Gets the vitals to decide health on in the right format
-func GetVitals(newResult *cache.Result, prevResult *cache.Result, mc *to.TrafficMonitorConfigMap) {
- if newResult.Error != nil {
- log.Errorf("cache_health.GetVitals() called with an errored Result!")
- return
- }
- // proc.loadavg -- we're using the 1 minute average (!?)
- // value looks like: "0.20 0.07 0.07 1/967 29536" (without the quotes)
- loadAverages := strings.Fields(newResult.Astats.System.ProcLoadavg)
- if len(loadAverages) > 0 {
- oneMinAvg, err := strconv.ParseFloat(loadAverages[0], 64)
- if err != nil {
- setError(newResult, fmt.Errorf("Error converting load average string '%s': %v", newResult.Astats.System.ProcLoadavg, err))
- return
- }
- newResult.Vitals.LoadAvg = oneMinAvg
- } else {
- setError(newResult, fmt.Errorf("Can't make sense of '%s' as a load average for %s", newResult.Astats.System.ProcLoadavg, newResult.ID))
- return
- }
-
- // proc.net.dev -- need to compare to prevSample
- // value looks like
- // "bond0:8495786321839 31960528603 0 0 0 0 0 2349716 143283576747316 101104535041 0 0 0 0 0 0"
- // (without the quotes)
- parts := strings.Split(newResult.Astats.System.ProcNetDev, ":")
- if len(parts) > 1 {
- numbers := strings.Fields(parts[1])
- var err error
- newResult.Vitals.BytesOut, err = strconv.ParseInt(numbers[8], 10, 64)
- if err != nil {
- setError(newResult, fmt.Errorf("Error converting BytesOut from procnetdev: %v", err))
- return
- }
- newResult.Vitals.BytesIn, err = strconv.ParseInt(numbers[0], 10, 64)
- if err != nil {
- setError(newResult, fmt.Errorf("Error converting BytesIn from procnetdev: %v", err))
- return
- }
- if prevResult != nil && prevResult.Vitals.BytesOut != 0 {
- elapsedTimeInSecs := float64(newResult.Time.UnixNano()-prevResult.Time.UnixNano()) / 1000000000
- newResult.Vitals.KbpsOut = int64(float64(((newResult.Vitals.BytesOut - prevResult.Vitals.BytesOut) * 8 / 1000)) / elapsedTimeInSecs)
- } else {
- // log.Infoln("prevResult == nil for id " + newResult.Id + ". Hope we're just starting up?")
- }
- } else {
- setError(newResult, fmt.Errorf("Error parsing procnetdev: no fields found"))
- return
- }
-
- // inf.speed -- value looks like "10000" (without the quotes) so it is in Mbps.
- // TODO JvD: Should we really be running this code every second for every cache polled????? I don't think so.
- interfaceBandwidth := newResult.Astats.System.InfSpeed
- newResult.Vitals.MaxKbpsOut = int64(interfaceBandwidth) * 1000
-
- // log.Infoln(newResult.Id, "BytesOut", newResult.Vitals.BytesOut, "BytesIn", newResult.Vitals.BytesIn, "Kbps", newResult.Vitals.KbpsOut, "max", newResult.Vitals.MaxKbpsOut)
-}
-
-// EvalCache returns whether the given cache should be marked available, a string describing why, and which stat exceeded a threshold. The `stats` may be nil, for pollers which don't poll stats.
-// The availability of EvalCache MAY NOT be used to directly set the cache's local availability, because the threshold stats may not be part of the poller which produced the result. Rather, if the cache was previously unavailable from a threshold, it must be verified that threshold stat is in the results before setting the cache to available.
-// TODO change to return a `cache.AvailableStatus`
-func EvalCache(result cache.ResultInfo, resultStats cache.ResultStatValHistory, mc *to.TrafficMonitorConfigMap) (bool, string, string) {
- serverInfo, ok := mc.TrafficServer[string(result.ID)]
- if !ok {
- log.Errorf("Cache %v missing from from Traffic Ops Monitor Config - treating as OFFLINE\n", result.ID)
- return false, "ERROR - server missing in Traffic Ops monitor config", ""
- }
- serverProfile, ok := mc.Profile[serverInfo.Profile]
- if !ok {
- log.Errorf("Cache %v profile %v missing from from Traffic Ops Monitor Config - treating as OFFLINE\n", result.ID, serverInfo.Profile)
- return false, "ERROR - server profile missing in Traffic Ops monitor config", ""
- }
-
- status := enum.CacheStatusFromString(serverInfo.Status)
- if status == enum.CacheStatusInvalid {
- log.Errorf("Cache %v got invalid status from Traffic Ops '%v' - treating as Reported\n", result.ID, serverInfo.Status)
- }
-
- availability := "available"
- if !result.Available {
- availability = "unavailable"
- }
-
- switch {
- case status == enum.CacheStatusInvalid:
- log.Errorf("Cache %v got invalid status from Traffic Ops '%v' - treating as OFFLINE\n", result.ID, serverInfo.Status)
- return false, getEventDescription(status, availability+"; invalid status"), ""
- case status == enum.CacheStatusAdminDown:
- return false, getEventDescription(status, availability), ""
- case status == enum.CacheStatusOffline:
- log.Errorf("Cache %v set to offline, but still polled\n", result.ID)
- return false, getEventDescription(status, availability), ""
- case status == enum.CacheStatusOnline:
- return true, getEventDescription(status, availability), ""
- case result.Error != nil:
- return false, getEventDescription(status, fmt.Sprintf("%v", result.Error)), ""
- }
-
- computedStats := cache.ComputedStats()
-
- for stat, threshold := range serverProfile.Parameters.Thresholds {
- resultStat := interface{}(nil)
- if computedStatF, ok := computedStats[stat]; ok {
- dummyCombinedstate := peer.IsAvailable{} // the only stats which use combinedState are things like isAvailable, which don't make sense to ever be thresholds.
- resultStat = computedStatF(result, serverInfo, serverProfile, dummyCombinedstate)
- } else {
- if resultStats == nil {
- continue
- }
- resultStatHistory, ok := resultStats[stat]
- if !ok {
- continue
- }
- if len(resultStatHistory) < 1 {
- continue
- }
- resultStat = resultStatHistory[0].Val
- }
-
- resultStatNum, ok := enum.ToNumeric(resultStat)
- if !ok {
- log.Errorf("health.EvalCache threshold stat %s was not a number: %v", stat, resultStat)
- continue
- }
-
- if !InThreshold(threshold, resultStatNum) {
- return false, getEventDescription(status, ExceedsThresholdMsg(stat, threshold, resultStatNum)), stat
- }
- }
-
- return result.Available, getEventDescription(status, availability), ""
-}
-
-// ExceedsThresholdMsg returns a human-readable message for why the given value exceeds the threshold. It does NOT check whether the value actually exceeds the threshold; call `InThreshold` to check first.
-func ExceedsThresholdMsg(stat string, threshold to.HealthThreshold, val float64) string {
- switch threshold.Comparator {
- case "=":
- return fmt.Sprintf("%s not equal (%f != %f)", stat, val, threshold.Val)
- case ">":
- return fmt.Sprintf("%s too low (%f < %f)", stat, val, threshold.Val)
- case "<":
- return fmt.Sprintf("%s too high (%f > %f)", stat, val, threshold.Val)
- case ">=":
- return fmt.Sprintf("%s too low (%f <= %f)", stat, val, threshold.Val)
- case "<=":
- return fmt.Sprintf("%s too high (%f >= %f)", stat, val, threshold.Val)
- default:
- return fmt.Sprintf("ERROR: Invalid Threshold: %+v", threshold)
- }
-}
-
-func InThreshold(threshold to.HealthThreshold, val float64) bool {
- switch threshold.Comparator {
- case "=":
- return val == threshold.Val
- case ">":
- return val > threshold.Val
- case "<":
- return val < threshold.Val
- case ">=":
- return val >= threshold.Val
- case "<=":
- return val <= threshold.Val
- default:
- log.Errorf("Invalid Threshold: %+v", threshold)
- return true // for safety, if a threshold somehow gets corrupted, don't start marking caches down.
- }
-}
-
-func getEventDescription(status enum.CacheStatus, message string) string {
- return fmt.Sprintf("%s - %s", status, message)
-}
http://git-wip-us.apache.org/repos/asf/incubator-trafficcontrol/blob/3db9dd7b/traffic_monitor/experimental/traffic_monitor/manager/stathistory.go
----------------------------------------------------------------------
diff --git a/traffic_monitor/experimental/traffic_monitor/manager/stathistory.go b/traffic_monitor/experimental/traffic_monitor/manager/stathistory.go
index c63584e..a4a9b81 100644
--- a/traffic_monitor/experimental/traffic_monitor/manager/stathistory.go
+++ b/traffic_monitor/experimental/traffic_monitor/manager/stathistory.go
@@ -255,7 +255,7 @@ func calcAvailability(results []cache.Result, pollerName string, statResultHisto
if available, ok := localStates.GetCache(result.ID); !ok || available.IsAvailable != isAvailable {
log.Infof("Changing state for %s was: %t now: %t because %s poller: %v error: %v", result.ID, available.IsAvailable, isAvailable, whyAvailable, pollerName, result.Error)
- events.Add(cache.Event{Time: time.Now().Unix(), Description: whyAvailable + " (" + pollerName + ")", Name: result.ID, Hostname: result.ID, Type: toData.ServerTypes[result.ID].String(), Available: isAvailable})
+ events.Add(health.Event{Time: time.Now(), Description: whyAvailable + " (" + pollerName + ")", Name: string(result.ID), Hostname: string(result.ID), Type: toData.ServerTypes[result.ID].String(), Available: isAvailable})
}
localStates.SetCache(result.ID, peer.IsAvailable{IsAvailable: isAvailable})