You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/05/22 03:36:32 UTC

[GitHub] [shardingsphere] terrymanu commented on a diff in pull request #17782: Database discovery type support `string`.

terrymanu commented on code in PR #17782:
URL: https://github.com/apache/shardingsphere/pull/17782#discussion_r878787966


##########
shardingsphere-features/shardingsphere-db-discovery/shardingsphere-db-discovery-distsql/shardingsphere-db-discovery-distsql-parser/src/main/antlr4/imports/db-discovery/RDLStatement.g4:
##########
@@ -104,7 +104,7 @@ property
     ;
 
 discoveryTypeName
-    : IDENTIFIER
+    : IDENTIFIER | STRING

Review Comment:
   Is `IDENTIFIER` suitable in discoveryTypeName?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org