[jira] [Comment Edited] (NIFI-11747) Refactor Groovy tests in nifi-web-api to Java (and JUnit 5)

["Daniel Stieglitz (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-11747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736606#comment-17736606 ] 

Daniel Stieglitz edited comment on NIFI-11747 at 6/23/23 8:27 PM:
------------------------------------------------------------------

[~exceptionfactory]
I was able to refactor the following non Spock Groovy files
# ApplicationResourceTest.groovy
# ProcessGroupResourceTest.groovy
# JsonContentConversionExceptionMapperTest.groovy

There are 3 Spock Groovy files.
# StandardNiFiServiceFacadeSpec.groovy
# StandardPolicyBasedAuthorizerDAOSpec.groovy
# StandardTemplateDAOSpec.groovy

Most of the "tests" in StandardNiFiServiceFacadeSpec.groovy are marked as ignored except for 2. That said do you want the existing "tests" tfrom the Spock files to be refactored to regular Junit  tests?


was (Author: JIRAUSER294662):
[~exceptionfactory]
I was able to refactor the following non Spock Groovy files
# ApplicationResourceTest.groovy
# ProcessGroupResourceTest.groovy
# JsonContentConversionExceptionMapperTest.groovy

There are 3 Spock Groovy files.
# StandardNiFiServiceFacadeSpec.groovy
# StandardPolicyBasedAuthorizerDAOSpec.groovy
# StandardTemplateDAOSpec.groovy

Most of the "tests" in StandardNiFiServiceFacadeSpec.groovy are marked as ignored except for 2. That said do you want the existing "tests" to be refactored to regular Junit  tests?

> Refactor Groovy tests in nifi-web-api to Java (and JUnit 5)	
> ------------------------------------------------------------
>
>                 Key: NIFI-11747
>                 URL: https://issues.apache.org/jira/browse/NIFI-11747
>             Project: Apache NiFi
>          Issue Type: Sub-task
>            Reporter: Daniel Stieglitz
>            Assignee: Daniel Stieglitz
>            Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)