You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/23 22:52:08 UTC

[GitHub] [hudi] xushiyan commented on a diff in pull request #5525: [MINOR] Update cli.md

xushiyan commented on code in PR #5525:
URL: https://github.com/apache/hudi/pull/5525#discussion_r879922639


##########
website/versioned_docs/version-0.11.0/cli.md:
##########
@@ -5,7 +5,7 @@ last_modified_at: 2021-08-18T15:59:57-04:00
 ---
 
 ### Local set up
-Once hudi has been built, the shell can be fired by via  `cd hudi-cli && ./hudi-cli.sh`. A hudi table resides on DFS, in a location referred to as the `basePath` and
+Once hudi has been built, the shell can be fired by via  `export CLIENT_JAR=hudi-cli/target/hudi-cli-xx.jar && cd hudi-cli && ./hudi-cli.sh`. A hudi table resides on DFS, in a location referred to as the `basePath` and

Review Comment:
   there is no need to set extra command in the guide. the `hudi-cli.sh` already prompt users to set `hudi-env.sh` so people should just change it here, instead of having inline env var, which does not look clean



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org