You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2022/01/07 16:50:36 UTC
[Impala-ASF-CR] test for execute without async
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18133
Change subject: test for execute without async
......................................................................
test for execute without async
Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
---
M tests/common/impala_connection.py
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/18133/1
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18133
to look at the new patch set (#13).
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
When executing a query in Hive, the query goes into RUNNING state
and then FINISHED state. The FINISHED state is the signal for
the client that it is ok to start fetching results.
In the test framework, we issue the queries async to Hive, so
it is necessary to wait_to_finish to be called. The tests were
working prior to the fix, but only because the query hit the
FINISH state quickly enough so that it was ok to retrieve the
result set.
Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
---
M tests/common/impala_connection.py
1 file changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/18133/13
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 13
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 8: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7794/
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 8
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 06:29:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Change to sync HS2 execute call in test framework.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18133
to look at the new patch set (#4).
Change subject: IMPALA-11097: Change to sync HS2 execute call in test framework.
......................................................................
IMPALA-11097: Change to sync HS2 execute call in test framework.
Changed the HS2 execute call to be synchronous. The async call
can fail if the fetch_results call is made before the execute is
finished.
Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
---
M tests/common/impala_connection.py
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/18133/4
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18133
to look at the new patch set (#12).
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
---
M tests/common/impala_connection.py
1 file changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/18133/12
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 12
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11097: In test framework, call HS2 execute synchronously
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18133
to look at the new patch set (#18).
Change subject: IMPALA-11097: In test framework, call HS2 execute synchronously
......................................................................
IMPALA-11097: In test framework, call HS2 execute synchronously
Changed the HS2 call to be synchronous. The previous code had a
race condition because wait_to_finish needs to be called before
checking the result set for Hive. Calling execute synchronously
for HS2 ensures that the result set is ready.
Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
---
M tests/common/impala_connection.py
1 file changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/18133/18
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 18
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-11097: In test framework, call HS2 execute synchronously
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: In test framework, call HS2 execute synchronously
......................................................................
Patch Set 18: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 18
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Feb 2022 15:53:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 13:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10121/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 13
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Feb 2022 00:31:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18133
to look at the new patch set (#15).
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
When executing a query in Hive, the query goes into RUNNING state
and then FINISHED state. The FINISHED state is the signal for
the client that it is ok to start fetching results.
In the test framework, we issue the queries async to Hive, so
it is necessary to wait_to_finish to be called. The tests were
working prior to the fix, but only because the query hit the
FINISH state quickly enough so that it was ok to retrieve the
result set.
Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
---
M tests/common/impala_connection.py
1 file changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/18133/15
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 15
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18133
to look at the new patch set (#16).
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
When executing a query in Hive, the query goes into RUNNING state
and then FINISHED state. The FINISHED state is the signal for
the client that it is ok to start fetching results.
In the test framework, we issue the queries async to Hive, so
it is necessary to wait_to_finish to be called. The tests were
working prior to the fix, but only because the query hit the
FINISH state quickly enough so that it was ok to retrieve the
result set.
Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
---
M tests/common/impala_connection.py
1 file changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/18133/16
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 16
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-11097: In test framework, call HS2 execute synchronously
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18133
to look at the new patch set (#17).
Change subject: IMPALA-11097: In test framework, call HS2 execute synchronously
......................................................................
IMPALA-11097: In test framework, call HS2 execute synchronously
Changed the HS2 call to be synchronous. The previous code had a
race condition because wait_to_finish needs to be called before
checking the result set. Calling execute synchronously for HS2
ensure that the result set is ready.
Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
---
M tests/common/impala_connection.py
1 file changed, 3 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/18133/17
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 17
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18133
to look at the new patch set (#6).
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
---
M tests/common/impala_connection.py
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/18133/6
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 7:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7786/
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Feb 2022 00:34:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 11: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7806/
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 11
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 05 Feb 2022 22:30:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 11:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7806/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 11
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 05 Feb 2022 15:58:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18133
to look at the new patch set (#11).
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
---
M tests/common/impala_connection.py
1 file changed, 9 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/18133/11
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 11
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 16: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 16
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Feb 2022 13:03:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 14: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 14
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Feb 2022 10:59:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 15:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7825/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 15
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Feb 2022 16:39:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] test for execute without async
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: test for execute without async
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7732/
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 08 Jan 2022 23:52:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 11:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18133/11/tests/common/impala_connection.py
File tests/common/impala_connection.py:
http://gerrit.cloudera.org:8080/#/c/18133/11/tests/common/impala_connection.py@344
PS11, Line 344: c
flake8: F821 undefined name 'cursor'
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 11
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 05 Feb 2022 15:58:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 9:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7801/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 16:03:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 12:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18133/12//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18133/12//COMMIT_MSG@8
PS12, Line 8:
Can you add some more context about the issue?
http://gerrit.cloudera.org:8080/#/c/18133/12/tests/common/impala_connection.py
File tests/common/impala_connection.py:
http://gerrit.cloudera.org:8080/#/c/18133/12/tests/common/impala_connection.py@342
PS12, Line 342: # For Hive statements that have no result set (eg USE), they may still be
: # running, and we need to wait for them to finish before we can proceed.
Is the comment still valid? now we are always calling wait_to_finish(), even if the query has a result set.
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 12
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 08 Feb 2022 23:33:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 16:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7826/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 16
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Feb 2022 19:04:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 12: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7808/
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 12
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 05 Feb 2022 23:42:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 15: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7825/
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 15
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Feb 2022 23:12:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 16: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 16
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Feb 2022 01:44:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10078/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 31 Jan 2022 21:16:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Change to sync HS2 execute call in test framework.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18133
to look at the new patch set (#5).
Change subject: IMPALA-11097: Change to sync HS2 execute call in test framework.
......................................................................
IMPALA-11097: Change to sync HS2 execute call in test framework.
Need to wait_to_finish for HS2 calls before fetch_results can
be called.
Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
---
M tests/common/impala_connection.py
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/18133/5
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 16:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10127/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 16
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Feb 2022 18:33:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] test for execute without async
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: test for execute without async
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7727/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jan 2022 16:51:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] test for execute without async
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: test for execute without async
......................................................................
Patch Set 2:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7733/
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 09 Jan 2022 07:21:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7808/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 12
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 05 Feb 2022 17:08:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 12: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 12
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 07 Feb 2022 03:27:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 12:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10105/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 12
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 05 Feb 2022 17:31:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 12:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7811/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 12
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 06 Feb 2022 20:56:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7786/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Feb 2022 17:46:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10077/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 31 Jan 2022 21:12:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] test for execute without async
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: test for execute without async
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9983/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Jan 2022 17:14:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] test for execute without async
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: test for execute without async
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7727/
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 08 Jan 2022 01:14:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] test for execute without async
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18133
to look at the new patch set (#2).
Change subject: test for execute without async
......................................................................
test for execute without async
Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
---
M tests/common/impala_connection.py
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/18133/2
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] test for execute without async
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: test for execute without async
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7732/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 08 Jan 2022 16:39:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] test for execute without async
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: test for execute without async
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7733/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 09 Jan 2022 00:58:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7782/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 31 Jan 2022 21:52:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: In test framework, call HS2 execute synchronously
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: In test framework, call HS2 execute synchronously
......................................................................
Patch Set 18: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 18
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Feb 2022 15:53:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 12:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18133/12//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18133/12//COMMIT_MSG@8
PS12, Line 8:
> Can you add some more context about the issue?
Done
http://gerrit.cloudera.org:8080/#/c/18133/12/tests/common/impala_connection.py
File tests/common/impala_connection.py:
http://gerrit.cloudera.org:8080/#/c/18133/12/tests/common/impala_connection.py@342
PS12, Line 342: # For Hive statements that have no result set (eg USE), they may still be
: # running, and we need to wait for them to finish before we can proceed.
> Is the comment still valid? now we are always calling wait_to_finish(), eve
Done
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 12
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Feb 2022 00:07:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 13: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 13
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Feb 2022 10:58:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 15:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10126/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 15
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Feb 2022 17:01:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 11:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10103/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 11
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 05 Feb 2022 16:21:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 9: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7801/
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 22:36:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: In test framework, call HS2 execute synchronously
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: In test framework, call HS2 execute synchronously
......................................................................
IMPALA-11097: In test framework, call HS2 execute synchronously
Changed the HS2 call to be synchronous. The previous code had a
race condition because wait_to_finish needs to be called before
checking the result set for Hive. Calling execute synchronously
for HS2 ensures that the result set is ready.
Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Reviewed-on: http://gerrit.cloudera.org:8080/18133
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Csaba Ringhofer <cs...@cloudera.com>
---
M tests/common/impala_connection.py
1 file changed, 3 insertions(+), 5 deletions(-)
Approvals:
Csaba Ringhofer: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 19
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-11097: In test framework, call HS2 execute synchronously
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: In test framework, call HS2 execute synchronously
......................................................................
Patch Set 17:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/10133/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 17
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Thu, 10 Feb 2022 16:13:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 14: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 14
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Feb 2022 17:26:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 14:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7823/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 14
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Steve Carlin <sc...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Feb 2022 10:59:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] test for execute without async
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: test for execute without async
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Jan 2022 20:40:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] test for execute without async
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: test for execute without async
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7754/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Jan 2022 14:09:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7794/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 8
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Feb 2022 23:58:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
Patch Set 7: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7782/
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Feb 2022 04:26:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] test for execute without async
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18133 )
Change subject: test for execute without async
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9992/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 08 Jan 2022 17:00:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11097: Call wait to finish before fetch results for HS2.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18133
to look at the new patch set (#7).
Change subject: IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
......................................................................
IMPALA-11097: Call wait_to_finish before fetch_results for HS2.
Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
---
M tests/common/impala_connection.py
1 file changed, 6 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/33/18133/7
--
To view, visit http://gerrit.cloudera.org:8080/18133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ab4b90ba2e1a439119d37fe9fb9c55eeeb53ba0
Gerrit-Change-Number: 18133
Gerrit-PatchSet: 7
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>