You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2015/08/01 12:09:30 UTC
Re: Review Request 36819: Use setup.py in python cli package.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819/
-----------------------------------------------------------
(Updated Aug. 1, 2015, 10:09 a.m.)
Review request for mesos, Benjamin Hindman and Marco Massenzio.
Bugs: MESOS-3149
https://issues.apache.org/jira/browse/MESOS-3149
Repository: mesos
Description
-------
Use setup.py in python cli package.
Diffs
-----
Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e
bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95
configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500
src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec
src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef
src/cli/python/mesos/cli.py
src/cli/python/mesos/futures.py
src/cli/python/mesos/http.py
src/python/cli/src/mesos/__init__.py PRE-CREATION
src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311
src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311
src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311
Diff: https://reviews.apache.org/r/36819/diff/
Testing
-------
make check
Thanks,
haosdent huang
Re: Review Request 36819: Use setup.py in python cli package.
Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819/#review93931
-----------------------------------------------------------
Ship it!
This looks good to me.
Provided that we test it on a couple of other platforms (CentOS 7.x and Ubuntu 14.04 would be good) I'm fine with it.
You still need a shepher to commit this, though - I can't.
- Marco Massenzio
On Aug. 1, 2015, 10:09 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36819/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2015, 10:09 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Marco Massenzio.
>
>
> Bugs: MESOS-3149
> https://issues.apache.org/jira/browse/MESOS-3149
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Use setup.py in python cli package.
>
>
> Diffs
> -----
>
> Makefile.am f8e958d376efa55ace7c5727a31b8e747403641e
> bin/mesos.sh.in 5cbeac4330a9f45fc6d54b8c2d383f48e4098f95
> configure.ac 546c9bbf775a4ef481fafb3a58c85c6d80e19500
> src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec
> src/cli/python/mesos/__init__.py 028b0d27fb193bac96f2a6a3201ee4cc8fd369ef
> src/cli/python/mesos/cli.py
> src/cli/python/mesos/futures.py
> src/cli/python/mesos/http.py
> src/python/cli/src/mesos/__init__.py PRE-CREATION
> src/python/interface/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311
> src/python/native/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311
> src/python/protocol/src/mesos/__init__.py f48ad10528712b2b8960f1863d156b88ed1ce311
>
> Diff: https://reviews.apache.org/r/36819/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> haosdent huang
>
>