Threaded comments testing

[Java Web Development <ja...@verizon.net>]

I put up my threaded comment changes in roller on a site I've been messing
around with. Please excuse the theme as it's still a work in progress as is
the rest of the site.

The threaded comments need some refinements too. You can go ahead and post
comments at
http://www.bergenjerseyforeclosures.com/blog/info/entry/test_entry_for_threa
ded_comments 

At some point I'll probably delete the whole entry.

There are some issues that need to be addressed such as should atom and rss
comment feeds be changed as well? If a subcomment is orphaned, what should
happen? 

Any comments would be appreciated.

Re: Threaded comments testing

[Matt Raible <mr...@gmail.com>]

On Thu, Jun 12, 2008 at 7:22 AM, Junchen Liu
<ju...@simulation-systems.co.uk> wrote:
> Hi all:
>
> Do we have a forum,  if we don`t I can make one for everybody, coz I really
> don`t get used to this mailling list thing.
>

You can use Nabble:

http://www.nabble.com/Roller-f12275.html

Matt

RE: Threaded comments testing

[Junchen Liu <ju...@simulation-systems.co.uk>]

Hi all:

Do we have a forum,  if we don`t I can make one for everybody, coz I really
don`t get used to this mailling list thing.

 Regards

Re: Threaded comments testing

[Richard Jones <ri...@pictorialpress.com>]

Apologies for resurrecting an old thread... but thought it might give some
context.

Would love to integrate threaded comments into our Roller installation, just
like the test entry here:

http://www.bergenjerseyforeclosures.com/blog/info/entry/test_entry_for_threaded_comments

Does anyone have a patch for this?

Cheers,

Richard




2008/6/16 Dave <sn...@gmail.com>

> On Fri, Jun 13, 2008 at 5:10 PM, Java Web Development
> <ja...@verizon.net> wrote:
> > Also, I need to alter two tables with a new column. It looks like I have
> to
> > insert a velocimacro for each in 400-to-410-migration.vm I can't seem to
> > find the velocimacro definitions so can you confirm the following.
> >
> > To add a varchar column to a table that can be null I need to use
> > #addColumnNull("<tablename>" "<columnname>" "varchar(48)")
> >
> > To add a boolean column to a table with a default value of false
> > #addColumnNotNull("<tablename>" "<columnname>" $db.BOOLEAN_SQL_TYPE
> > $db.BOOLEAN_FALSE)
>
> Looks good to me.
>
> - Dave
>
>

Re: Threaded comments testing

[Dave <sn...@gmail.com>]

On Fri, Jun 13, 2008 at 5:10 PM, Java Web Development
<ja...@verizon.net> wrote:
> Also, I need to alter two tables with a new column. It looks like I have to
> insert a velocimacro for each in 400-to-410-migration.vm I can't seem to
> find the velocimacro definitions so can you confirm the following.
>
> To add a varchar column to a table that can be null I need to use
> #addColumnNull("<tablename>" "<columnname>" "varchar(48)")
>
> To add a boolean column to a table with a default value of false
> #addColumnNotNull("<tablename>" "<columnname>" $db.BOOLEAN_SQL_TYPE
> $db.BOOLEAN_FALSE)

Looks good to me.

- Dave

RE: Threaded comments testing

[Java Web Development <ja...@verizon.net>]

> Nice! I'm looking forward to seeing a patch ;-)
> 
> - Dave

Dave,

The mechanics of posting and replying to comments and the ability to turn on
this feature on a per weblog basis are done except for one issue and one
optimization I need to verify I can safely make.

Right now I'm working on comment management to reflect the changes.
Basically, if a comment has replies, what happens to those replies if that
comment is marked as spam or deleted. So we don't end up with orphaned
comments the changes should either cascade through the rest of the thread or
the replies need to be promoted one level.

Doing one of those is pretty easy. Giving the moderator a choice a little
bit harder but doable. I'm still trying to familiarize myself with this
section and haven't decided what to do yet. Do you (or anyone else) have any
thoughts on whether cascading changes, promoting replies or giving the
moderator the option would be the best way to implement it?

Also, I need to alter two tables with a new column. It looks like I have to
insert a velocimacro for each in 400-to-410-migration.vm I can't seem to
find the velocimacro definitions so can you confirm the following.

To add a varchar column to a table that can be null I need to use
#addColumnNull("<tablename>" "<columnname>" "varchar(48)")

To add a boolean column to a table with a default value of false
#addColumnNotNull("<tablename>" "<columnname>" $db.BOOLEAN_SQL_TYPE
$db.BOOLEAN_FALSE)

Does that look right?

Re: Threaded comments testing

[Dave <sn...@gmail.com>]

On Thu, Jun 12, 2008 at 9:04 AM, Java Web Development
<ja...@verizon.net> wrote:
> I put up my threaded comment changes in roller on a site I've been messing
> around with. Please excuse the theme as it's still a work in progress as is
> the rest of the site.
>
> The threaded comments need some refinements too. You can go ahead and post
> comments at
> http://www.bergenjerseyforeclosures.com/blog/info/entry/test_entry_for_threa
> ded_comments

Nice! I'm looking forward to seeing a patch ;-)

- Dave

RE: Threaded comments testing

[Java Web Development <ja...@verizon.net>]

Sorry,

URL was too long. Try this http://tinyurl.com/6cyfa8



-----Original Message-----
From: Java Web Development [mailto:javawebdev@verizon.net] 
Sent: Thursday, June 12, 2008 9:05 AM
To: dev@roller.apache.org
Subject: Threaded comments testing

I put up my threaded comment changes in roller on a site I've been messing
around with. Please excuse the theme as it's still a work in progress as is
the rest of the site.

The threaded comments need some refinements too. You can go ahead and post
comments at
http://www.bergenjerseyforeclosures.com/blog/info/entry/test_entry_for_threa
ded_comments 

At some point I'll probably delete the whole entry.

There are some issues that need to be addressed such as should atom and rss
comment feeds be changed as well? If a subcomment is orphaned, what should
happen? 

Any comments would be appreciated.