You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/03/06 01:20:58 UTC

[kudu-CR] build: stop generating md5 file 

Hello Dan Burkert,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/9504

to review the following change.


Change subject: build: stop generating md5 file
......................................................................

build: stop generating md5 file

New guidance from the ASF is to not generate md5 files when producing source
releases. Instead we just generate the sha checksum.

Change-Id: I6b0359d63b660b285c0853cd9b88654a400f14c2
---
M build-support/build_source_release.py
1 file changed, 11 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/9504/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6b0359d63b660b285c0853cd9b88654a400f14c2
Gerrit-Change-Number: 9504
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>

[kudu-CR] build: stop generating md5 file

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9504 )

Change subject: build: stop generating md5 file
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/9504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b0359d63b660b285c0853cd9b88654a400f14c2
Gerrit-Change-Number: 9504
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 06 Mar 2018 02:31:37 +0000
Gerrit-HasComments: No

[kudu-CR] build: stop generating md5 file

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9504 )

Change subject: build: stop generating md5 file
......................................................................

build: stop generating md5 file

New guidance from the ASF is to not generate md5 files when producing source
releases. Instead we just generate the sha checksum.

Change-Id: I6b0359d63b660b285c0853cd9b88654a400f14c2
Reviewed-on: http://gerrit.cloudera.org:8080/9504
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M build-support/build_source_release.py
1 file changed, 11 insertions(+), 14 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Dan Burkert: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/9504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b0359d63b660b285c0853cd9b88654a400f14c2
Gerrit-Change-Number: 9504
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>