You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/20 16:13:55 UTC
[GitHub] [flink] azagrebin opened a new pull request #12563: [FLINK-16225] Implement user class loading exception handler
azagrebin opened a new pull request #12563:
URL: https://github.com/apache/flink/pull/12563
1.10 Port of #12446.
Just to run CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12563:
URL: https://github.com/apache/flink/pull/12563#issuecomment-641499901
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "9dd08c598b563dc116248372c03cd449a1525c39",
"triggerType" : "PUSH"
}, {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "641766274",
"triggerType" : "MANUAL"
}, {
"hash" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170642365",
"triggerID" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"triggerType" : "PUSH"
}, {
"hash" : "dd4bb7283e4b52e5646c9809f21d39f1a95bb550",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/176357163",
"triggerID" : "dd4bb7283e4b52e5646c9809f21d39f1a95bb550",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c1d0d9befd392aa787f498efc6b3f7e3f2badfe6 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/170642365)
* dd4bb7283e4b52e5646c9809f21d39f1a95bb550 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/176357163)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #12563:
URL: https://github.com/apache/flink/pull/12563#discussion_r458594116
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobManagerSharedServices.java
##########
@@ -144,11 +146,13 @@ public static JobManagerSharedServices fromConfiguration(
final String[] alwaysParentFirstLoaderPatterns = CoreOptions.getParentFirstLoaderPatterns(config);
+ final boolean failOnJvmMetaspaceOomError = config.getBoolean(CoreOptions.FAIL_ON_USER_CLASS_LOADING_METASPACE_OOM);
final BlobLibraryCacheManager libraryCacheManager =
new BlobLibraryCacheManager(
blobServer,
FlinkUserCodeClassLoaders.ResolveOrder.fromString(classLoaderResolveOrder),
- alwaysParentFirstLoaderPatterns);
+ alwaysParentFirstLoaderPatterns,
+ fatalErrorHandler);
Review comment:
```suggestion
failOnJvmMetaspaceOomError ? fatalErrorHandler : null);
```
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -1326,7 +1326,8 @@ private JobManagerConnection associateWithJobManager(
final LibraryCacheManager libraryCacheManager = new BlobLibraryCacheManager(
blobCacheService.getPermanentBlobService(),
taskManagerConfiguration.getClassLoaderResolveOrder(),
- taskManagerConfiguration.getAlwaysParentFirstLoaderPatterns());
+ taskManagerConfiguration.getAlwaysParentFirstLoaderPatterns(),
+ fatalErrorHandler);
Review comment:
Here we are not respecting `FAIL_ON_USER_CLASS_LOADING_METASPACE_OOM`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12563:
URL: https://github.com/apache/flink/pull/12563#issuecomment-641499901
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9dd08c598b563dc116248372c03cd449a1525c39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dd08c598b563dc116248372c03cd449a1525c39 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12563:
URL: https://github.com/apache/flink/pull/12563#issuecomment-641499901
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "9dd08c598b563dc116248372c03cd449a1525c39",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dd08c598b563dc116248372c03cd449a1525c39 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/170571823)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12563:
URL: https://github.com/apache/flink/pull/12563#issuecomment-641499901
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "9dd08c598b563dc116248372c03cd449a1525c39",
"triggerType" : "PUSH"
}, {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "641766274",
"triggerType" : "MANUAL"
}, {
"hash" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170642365",
"triggerID" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"triggerType" : "PUSH"
}, {
"hash" : "dd4bb7283e4b52e5646c9809f21d39f1a95bb550",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/176357163",
"triggerID" : "dd4bb7283e4b52e5646c9809f21d39f1a95bb550",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd4bb7283e4b52e5646c9809f21d39f1a95bb550 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/176357163)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12563:
URL: https://github.com/apache/flink/pull/12563#issuecomment-641499901
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "9dd08c598b563dc116248372c03cd449a1525c39",
"triggerType" : "PUSH"
}, {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "641766274",
"triggerType" : "MANUAL"
}, {
"hash" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170642365",
"triggerID" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"triggerType" : "PUSH"
}, {
"hash" : "dd4bb7283e4b52e5646c9809f21d39f1a95bb550",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/176357163",
"triggerID" : "dd4bb7283e4b52e5646c9809f21d39f1a95bb550",
"triggerType" : "PUSH"
}, {
"hash" : "3873dd832db7a863367ef10245ad62a8fd1324cf",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/176652439",
"triggerID" : "3873dd832db7a863367ef10245ad62a8fd1324cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd4bb7283e4b52e5646c9809f21d39f1a95bb550 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/176357163)
* 3873dd832db7a863367ef10245ad62a8fd1324cf Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/176652439)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12563:
URL: https://github.com/apache/flink/pull/12563#issuecomment-641499901
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "9dd08c598b563dc116248372c03cd449a1525c39",
"triggerType" : "PUSH"
}, {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "641766274",
"triggerType" : "MANUAL"
}, {
"hash" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dd08c598b563dc116248372c03cd449a1525c39 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/170571823)
* c1d0d9befd392aa787f498efc6b3f7e3f2badfe6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12563:
URL: https://github.com/apache/flink/pull/12563#issuecomment-641499901
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "9dd08c598b563dc116248372c03cd449a1525c39",
"triggerType" : "PUSH"
}, {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "641766274",
"triggerType" : "MANUAL"
}, {
"hash" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170642365",
"triggerID" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"triggerType" : "PUSH"
}, {
"hash" : "dd4bb7283e4b52e5646c9809f21d39f1a95bb550",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/176357163",
"triggerID" : "dd4bb7283e4b52e5646c9809f21d39f1a95bb550",
"triggerType" : "PUSH"
}, {
"hash" : "3873dd832db7a863367ef10245ad62a8fd1324cf",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3873dd832db7a863367ef10245ad62a8fd1324cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd4bb7283e4b52e5646c9809f21d39f1a95bb550 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/176357163)
* 3873dd832db7a863367ef10245ad62a8fd1324cf UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12563:
URL: https://github.com/apache/flink/pull/12563#issuecomment-641499901
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "9dd08c598b563dc116248372c03cd449a1525c39",
"triggerType" : "PUSH"
}, {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "641766274",
"triggerType" : "MANUAL"
}, {
"hash" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170642365",
"triggerID" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9dd08c598b563dc116248372c03cd449a1525c39 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/170571823)
* c1d0d9befd392aa787f498efc6b3f7e3f2badfe6 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/170642365)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] azagrebin commented on pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
azagrebin commented on pull request #12563:
URL: https://github.com/apache/flink/pull/12563#issuecomment-641766274
@flinkbot run travis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] azagrebin commented on pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
azagrebin commented on pull request #12563:
URL: https://github.com/apache/flink/pull/12563#issuecomment-662325907
Thanks for the review @tillrohrmann
True, the option got lost during the rebase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] azagrebin closed pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
azagrebin closed pull request #12563:
URL: https://github.com/apache/flink/pull/12563
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12563:
URL: https://github.com/apache/flink/pull/12563#issuecomment-641492756
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9dd08c598b563dc116248372c03cd449a1525c39 (Tue Jun 09 18:26:48 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12563:
URL: https://github.com/apache/flink/pull/12563#issuecomment-641499901
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "9dd08c598b563dc116248372c03cd449a1525c39",
"triggerType" : "PUSH"
}, {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "641766274",
"triggerType" : "MANUAL"
}, {
"hash" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170642365",
"triggerID" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c1d0d9befd392aa787f498efc6b3f7e3f2badfe6 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/170642365)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] azagrebin commented on pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
azagrebin commented on pull request #12563:
URL: https://github.com/apache/flink/pull/12563#issuecomment-644170325
When `EventTimeWindowCheckpointingITCase` runs the whole package, it sometimes hits the default JVM direct memory limit (2g). The GC of netty direct memory buffers is slowed down for some reason which leads to direct OOM errors in netty stack. This is also reproducible in `release-1.10` branch with a lower JVM direct memory limit (e.g. 512mb). This is not clear how inheritance in user class loaders, introduced in this PR, affects direct memory GC.
We could reduce the usage of netty buffers by porting some network stack improvements to 1.10 from 1.11 (FLINK-15962) but we rather do not merge this change to 1.10 and reconsider it if this becomes a problem in future.
cc @zhijiangW
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] azagrebin merged pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
azagrebin merged pull request #12563:
URL: https://github.com/apache/flink/pull/12563
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12563:
URL: https://github.com/apache/flink/pull/12563#issuecomment-641499901
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "9dd08c598b563dc116248372c03cd449a1525c39",
"triggerType" : "PUSH"
}, {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "641766274",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 9dd08c598b563dc116248372c03cd449a1525c39 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/170571823)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12563:
URL: https://github.com/apache/flink/pull/12563#issuecomment-641499901
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "9dd08c598b563dc116248372c03cd449a1525c39",
"triggerType" : "PUSH"
}, {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "641766274",
"triggerType" : "MANUAL"
}, {
"hash" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170642365",
"triggerID" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"triggerType" : "PUSH"
}, {
"hash" : "dd4bb7283e4b52e5646c9809f21d39f1a95bb550",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/176357163",
"triggerID" : "dd4bb7283e4b52e5646c9809f21d39f1a95bb550",
"triggerType" : "PUSH"
}, {
"hash" : "3873dd832db7a863367ef10245ad62a8fd1324cf",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/176652439",
"triggerID" : "3873dd832db7a863367ef10245ad62a8fd1324cf",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3873dd832db7a863367ef10245ad62a8fd1324cf Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/176652439)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12563: [FLINK-16225] Implement user class loading exception handler
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12563:
URL: https://github.com/apache/flink/pull/12563#issuecomment-641499901
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "9dd08c598b563dc116248372c03cd449a1525c39",
"triggerType" : "PUSH"
}, {
"hash" : "9dd08c598b563dc116248372c03cd449a1525c39",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170571823",
"triggerID" : "641766274",
"triggerType" : "MANUAL"
}, {
"hash" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"status" : "FAILURE",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/170642365",
"triggerID" : "c1d0d9befd392aa787f498efc6b3f7e3f2badfe6",
"triggerType" : "PUSH"
}, {
"hash" : "dd4bb7283e4b52e5646c9809f21d39f1a95bb550",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dd4bb7283e4b52e5646c9809f21d39f1a95bb550",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c1d0d9befd392aa787f498efc6b3f7e3f2badfe6 Travis: [FAILURE](https://travis-ci.com/github/flink-ci/flink/builds/170642365)
* dd4bb7283e4b52e5646c9809f21d39f1a95bb550 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org