You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "dajac (via GitHub)" <gi...@apache.org> on 2025/01/13 11:14:22 UTC
[PR] MINOR: Fix typo in DumpLogSegments' TransactionLogMessageParser [kafka]
dajac opened a new pull request, #18505:
URL: https://github.com/apache/kafka/pull/18505
The value should use `version` instead of `type`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix typo in DumpLogSegments' TransactionLogMessageParser [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac merged PR #18505:
URL: https://github.com/apache/kafka/pull/18505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix typo in DumpLogSegments' TransactionLogMessageParser [kafka]
Posted by "clolov (via GitHub)" <gi...@apache.org>.
clolov commented on code in PR #18505:
URL: https://github.com/apache/kafka/pull/18505#discussion_r1913071846
##########
core/src/main/scala/kafka/tools/DumpLogSegments.scala:
##########
@@ -548,7 +548,7 @@ object DumpLogSegments {
}
val json = new ObjectNode(JsonNodeFactory.instance)
- json.set("type", new TextNode(version.toString))
+ json.set("version", new TextNode(version.toString))
Review Comment:
For my understanding, if `type` is changed to `version` here shouldn't it also be changed to `version` in `prepareKey` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix typo in DumpLogSegments' TransactionLogMessageParser [kafka]
Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #18505:
URL: https://github.com/apache/kafka/pull/18505#discussion_r1913210424
##########
core/src/main/scala/kafka/tools/DumpLogSegments.scala:
##########
@@ -548,7 +548,7 @@ object DumpLogSegments {
}
val json = new ObjectNode(JsonNodeFactory.instance)
- json.set("type", new TextNode(version.toString))
+ json.set("version", new TextNode(version.toString))
Review Comment:
No, it should not. In the key, we get the type of the record together with the serialized key. In the value, we have the version of the record together with the serialized record. The format is defined here: https://github.com/apache/kafka/blob/trunk/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRecordSerde.java#L29
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org