You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by DaveBirdsall <gi...@git.apache.org> on 2015/09/24 19:14:19 UTC
[GitHub] incubator-trafodion pull request: [TRAFODION-1497] Fix expected re...
GitHub user DaveBirdsall opened a pull request:
https://github.com/apache/incubator-trafodion/pull/91
[TRAFODION-1497] Fix expected results for compGeneral/TEST042
The fix to JIRA TRAFODION-1494 unfortunately changed the results for compGeneral/TEST042. This check-in updates the expected results for that test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/DaveBirdsall/incubator-trafodion Test042Update
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/91.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #91
----
commit 3700e90f9318ff3ed1c0847473722bbf5ab0f09f
Author: Dave Birdsall <db...@apache.org>
Date: 2015-09-24T17:10:09Z
[TRAFODION-1497] Fix expected results for compGeneral/TEST042
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1497] Fix expected re...
Posted by sureshsubbiah <gi...@git.apache.org>.
Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/91#discussion_r40385990
--- Diff: core/sql/regress/compGeneral/EXPECTED042 ---
@@ -1871,8 +1871,8 @@ NUM_ENTRIES TEXT_ENTRIES NUM_PLANS
NUM_ENTRIES TEXT_ENTRIES NUM_PLANS
----------- ------------ ----------
- 17 0 17
- 1 0 1
+ 22 0 22
--- End diff --
Does this mean more metadata queries are being cached now? Dow we know what the new entries are? There is no doubt that the fix for 1494 is necessary and required. I am not able to understand fully the changes in this expected file. If it will take too much effort to find out, we could simply accept the result. I am good with that too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1497] Fix expected re...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/91#discussion_r40389240
--- Diff: core/sql/regress/compGeneral/EXPECTED042 ---
@@ -1977,25 +1977,31 @@ NUM_HITS NUM_PARAMS
---------- ----------
0 1
+ 0 1
+ 0 1
+ 0 1
+ 0 2
0 2
+ 0 2
+ 0 2
+ 0 3
0 3
+ 0 4
0 5
1 1
1 1
1 2
1 2
1 3
+ 1 3
--- End diff --
Same number of queries as before. What's happening is that some of the cache entries are not matching up due to differences in CQDs. That's not surprising as the bug in 1494 prevented the toggling of CQDs in some circumstances. In this particular test suite, the metadata queries get cached very early on and the increase in cache usage stops. (I found this out by peppering a copy of the test script with selects against querycache.) So it is up-front growth. Of course if we wish, we could investigate further and perhaps add or delete some of the CQDs in the metadata code to improve the entry sharing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1497] Fix expected re...
Posted by sureshsubbiah <gi...@git.apache.org>.
Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/91#discussion_r40386072
--- Diff: core/sql/regress/compGeneral/EXPECTED042 ---
@@ -1977,25 +1977,31 @@ NUM_HITS NUM_PARAMS
---------- ----------
0 1
+ 0 1
+ 0 1
+ 0 1
+ 0 2
0 2
+ 0 2
+ 0 2
+ 0 3
0 3
+ 0 4
0 5
1 1
1 1
1 2
1 2
1 3
+ 1 3
--- End diff --
This looks more serious. We have more entries in the query cache, but are getting fewer hits. I wonder what happened.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1497] Fix expected re...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/91
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---