You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/15 22:49:11 UTC

[GitHub] [incubator-nuttx-apps] patacongo commented on a change in pull request #75: testing/fstest/fstest_main.c: Eliminate a warning found during the build

patacongo commented on a change in pull request #75: testing/fstest/fstest_main.c: Eliminate a warning found during the build
URL: https://github.com/apache/incubator-nuttx-apps/pull/75#discussion_r379861083
 
 

 ##########
 File path: testing/fstest/fstest_main.c
 ##########
 @@ -1084,7 +1084,7 @@ int main(int argc, FAR char *argv[])
 
       /* Perform garbage collection, integrity checks */
 
-      fstest_gc(buf.f_bfree);
+      (void)fstest_gc(buf.f_bfree);
 
 Review comment:
   The use of (void) to ignore return values was recently removed in some recent PRs.  How do we know that this void will not be removed in the future, re-introducing the warning.   An alternative would be to make ftest_gc return void instead of int.  The return value is never used.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services