You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@daffodil.apache.org by "mbeckerle (via GitHub)" <gi...@apache.org> on 2023/04/19 12:36:06 UTC

[GitHub] [daffodil] mbeckerle commented on a diff in pull request #1006: Fix textStandardZeroRep to be "" not "0"

mbeckerle commented on code in PR #1006:
URL: https://github.com/apache/daffodil/pull/1006#discussion_r1171273827


##########
daffodil-lib/src/main/resources/org/apache/daffodil/xsd/DFDLGeneralFormat.dfdl.xsd:
##########
@@ -92,7 +92,7 @@
           textStandardGroupingSeparator=","
           textStandardInfinityRep="Inf"
           textStandardNaNRep="NaN"
-          textStandardZeroRep="0"
+          textStandardZeroRep=""

Review Comment:
   Great suggestions. I'll add a test that insures this is working properly. you are correct that empty string turns "off" the feature of special zero rep. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org