You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "ericxiao251 (via GitHub)" <gi...@apache.org> on 2023/04/26 14:25:26 UTC

[GitHub] [flink] ericxiao251 commented on a diff in pull request #22438: [FLINK-31873] Add method setMaxParallelism to DataStreamSink.

ericxiao251 commented on code in PR #22438:
URL: https://github.com/apache/flink/pull/22438#discussion_r1177962682


##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java:
##########
@@ -283,6 +283,25 @@ public void testTransformationSetParallelism() {
         assertThat(vertices.get(2).isParallelismConfigured()).isTrue();
     }
 
+    @Test
+    public void testTransformationSetMaxParallelism() {

Review Comment:
   Hey Weihua, that's a good point I've noticed that in the other test files before I believe, but all the tests in this file are marked `public` for some reason 🤔 . Should I mark my test as `public` still?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org