You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2016/02/26 03:00:47 UTC

Fwd: [GitHub] commons-lang pull request: StrSubstitutor can preserve escapes

Just FYI, is that something we can use?

Should we port again?

Gary
---------- Forwarded message ----------
From: samuelkarp <gi...@git.apache.org>
Date: Thu, Feb 25, 2016 at 5:07 PM
Subject: [GitHub] commons-lang pull request: StrSubstitutor can preserve
escapes
To: issues@commons.apache.org


GitHub user samuelkarp opened a pull request:

    https://github.com/apache/commons-lang/pull/124

    StrSubstitutor can preserve escapes

    StrSubstitutor can now optionally preserve the escape character for an
    escaped reference, which is useful when substitution takes place in
    multiple phases and some references are intentionally unresolved.  Prior
    to this change, an unresolved reference `${a}` and an escaped reference
    `$${a}` may result in the same string `${a}`, making it impossible for
    an additional substitution phase to distinguish between escaped
    references and non-escaped references.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/samuelkarp/commons-lang preserve-escapes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/commons-lang/pull/124.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #124

----
commit e55aaa5706f031df2e8d68bdf088604c79944246
Author: Samuel Karp <sk...@amazon.com>
Date:   2016-02-03T23:45:21Z

    StrSubstitutor can preserve escapes

    StrSubstitutor can now optionally preserve the escape character for an
    escaped reference, which is useful when substitution takes place in
    multiple phases and some references are intentionally unresolved.  Prior
    to this change, an unresolved reference `${a}` and an escaped reference
    `$${a}` may result in the same string `${a}`, making it impossible for
    an additional substitution phase to distinguish between escaped
    references and non-escaped references.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Re: [GitHub] commons-lang pull request: StrSubstitutor can preserve escapes

Posted by Ralph Goers <ra...@dslextreme.com>.
I don't see how it can hurt.

Ralph

> On Feb 25, 2016, at 7:00 PM, Gary Gregory <ga...@gmail.com> wrote:
> 
> Just FYI, is that something we can use?
> 
> Should we port again?
> 
> Gary
> ---------- Forwarded message ----------
> From: samuelkarp <gi...@git.apache.org>
> Date: Thu, Feb 25, 2016 at 5:07 PM
> Subject: [GitHub] commons-lang pull request: StrSubstitutor can preserve escapes
> To: issues@commons.apache.org
> 
> 
> GitHub user samuelkarp opened a pull request:
> 
>     https://github.com/apache/commons-lang/pull/124
> 
>     StrSubstitutor can preserve escapes
> 
>     StrSubstitutor can now optionally preserve the escape character for an
>     escaped reference, which is useful when substitution takes place in
>     multiple phases and some references are intentionally unresolved.  Prior
>     to this change, an unresolved reference `${a}` and an escaped reference
>     `$${a}` may result in the same string `${a}`, making it impossible for
>     an additional substitution phase to distinguish between escaped
>     references and non-escaped references.
> 
> You can merge this pull request into a Git repository by running:
> 
>     $ git pull https://github.com/samuelkarp/commons-lang preserve-escapes
> 
> Alternatively you can review and apply these changes as the patch at:
> 
>     https://github.com/apache/commons-lang/pull/124.patch
> 
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
> 
>     This closes #124
> 
> ----
> commit e55aaa5706f031df2e8d68bdf088604c79944246
> Author: Samuel Karp <sk...@amazon.com>
> Date:   2016-02-03T23:45:21Z
> 
>     StrSubstitutor can preserve escapes
> 
>     StrSubstitutor can now optionally preserve the escape character for an
>     escaped reference, which is useful when substitution takes place in
>     multiple phases and some references are intentionally unresolved.  Prior
>     to this change, an unresolved reference `${a}` and an escaped reference
>     `$${a}` may result in the same string `${a}`, making it impossible for
>     an additional substitution phase to distinguish between escaped
>     references and non-escaped references.
> 
> ----
> 
> 
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
> 
> 
> 
> -- 
> E-Mail: garydgregory@gmail.com | ggregory@apache.org 
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com 
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory