You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuweni.apache.org by GitBox <gi...@apache.org> on 2020/07/19 02:04:33 UTC
[GitHub] [incubator-tuweni] atoulme opened a new pull request #133: Improve build, move license checks to only run if we touch dependencies
atoulme opened a new pull request #133:
URL: https://github.com/apache/incubator-tuweni/pull/133
<!-- Thanks for sending a pull request! Please check out our contribution guidelines: -->
<!-- https://github.com/apache/incubator-tuweni/blob/master/CONTRIBUTING.md -->
## PR description
Improve build, move license checks to only run if we touch dependencies
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #133: Improve build, move license checks to only run if we touch dependencies
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #133:
URL: https://github.com/apache/incubator-tuweni/pull/133#issuecomment-660597141
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=h1) Report
> Merging [#133](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/43fb3c59d0d57bba51075f9e8efd5477de32cf95&el=desc) will **increase** coverage by `7.51%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #133 +/- ##
============================================
+ Coverage 59.29% 66.81% +7.51%
- Complexity 3825 4232 +407
============================================
Files 374 399 +25
Lines 19117 19497 +380
Branches 2414 2419 +5
============================================
+ Hits 11335 13026 +1691
+ Misses 6553 5083 -1470
- Partials 1229 1388 +159
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #integration | `60.89% <0.00%> (?)` | `807.00 <0.00> (?)` | |
| #unit | `59.29% <ø> (ø)` | `3825.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/tuweni/concurrent/AsyncCompletion.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-Y29uY3VycmVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL2NvbmN1cnJlbnQvQXN5bmNDb21wbGV0aW9uLmphdmE=) | `81.60% <ø> (ø)` | `26.00 <0.00> (ø)` | |
| [...n/java/org/apache/tuweni/config/Configuration.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-Y29uZmlnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY29uZmlnL0NvbmZpZ3VyYXRpb24uamF2YQ==) | `43.47% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [...src/main/java/org/apache/tuweni/config/Schema.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-Y29uZmlnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY29uZmlnL1NjaGVtYS5qYXZh) | `43.57% <ø> (ø)` | `22.00 <0.00> (ø)` | |
| [...vp2p/v5/internal/handler/RegTopicMessageHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvaW50ZXJuYWwvaGFuZGxlci9SZWdUb3BpY01lc3NhZ2VIYW5kbGVyLmt0) | `66.66% <ø> (+66.66%)` | `2.00 <0.00> (+2.00)` | |
| [.../apache/tuweni/devp2p/v5/packet/RegTopicMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvcGFja2V0L1JlZ1RvcGljTWVzc2FnZS5rdA==) | `100.00% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [...n/org/apache/tuweni/devp2p/v5/packet/UdpMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvcGFja2V0L1VkcE1lc3NhZ2Uua3Q=) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...rc/main/java/org/apache/tuweni/plumtree/State.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cGx1bXRyZWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9wbHVtdHJlZS9TdGF0ZS5qYXZh) | `89.79% <ø> (+10.20%)` | `14.00 <0.00> (+3.00)` | |
| [...c/main/java/org/apache/tuweni/progpow/ProgPoW.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cHJvZ3Bvdy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3Byb2dwb3cvUHJvZ1BvVy5qYXZh) | `95.79% <ø> (ø)` | `31.00 <0.00> (ø)` | |
| [...apache/tuweni/rlpx/wire/DefaultWireConnection.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9EZWZhdWx0V2lyZUNvbm5lY3Rpb24uamF2YQ==) | `77.56% <ø> (+30.12%)` | `25.00 <0.00> (+9.00)` | |
| [...va/org/apache/tuweni/rlpx/wire/WireConnection.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9XaXJlQ29ubmVjdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [116 more](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=footer). Last update [43fb3c5...923d4b1](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #133: Improve build, move license checks to only run if we touch dependencies
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #133:
URL: https://github.com/apache/incubator-tuweni/pull/133#issuecomment-660597141
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=h1) Report
> Merging [#133](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/43fb3c59d0d57bba51075f9e8efd5477de32cf95&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #133 +/- ##
=========================================
Coverage 59.29% 59.29%
Complexity 3825 3825
=========================================
Files 374 374
Lines 19117 19117
Branches 2414 2414
=========================================
Hits 11335 11335
Misses 6553 6553
Partials 1229 1229
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #unit | `59.29% <ø> (ø)` | `3825.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/tuweni/concurrent/AsyncCompletion.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-Y29uY3VycmVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL2NvbmN1cnJlbnQvQXN5bmNDb21wbGV0aW9uLmphdmE=) | `81.60% <ø> (ø)` | `26.00 <0.00> (ø)` | |
| [...n/java/org/apache/tuweni/config/Configuration.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-Y29uZmlnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY29uZmlnL0NvbmZpZ3VyYXRpb24uamF2YQ==) | `43.47% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [...src/main/java/org/apache/tuweni/config/Schema.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-Y29uZmlnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY29uZmlnL1NjaGVtYS5qYXZh) | `43.57% <ø> (ø)` | `22.00 <0.00> (ø)` | |
| [...rc/main/java/org/apache/tuweni/plumtree/State.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cGx1bXRyZWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9wbHVtdHJlZS9TdGF0ZS5qYXZh) | `79.59% <ø> (ø)` | `11.00 <0.00> (ø)` | |
| [...c/main/java/org/apache/tuweni/progpow/ProgPoW.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cHJvZ3Bvdy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3Byb2dwb3cvUHJvZ1BvVy5qYXZh) | `95.79% <ø> (ø)` | `31.00 <0.00> (ø)` | |
| [...apache/tuweni/rlpx/wire/DefaultWireConnection.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9EZWZhdWx0V2lyZUNvbm5lY3Rpb24uamF2YQ==) | `47.43% <ø> (ø)` | `16.00 <0.00> (ø)` | |
| [...va/org/apache/tuweni/rlpx/wire/WireConnection.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9XaXJlQ29ubmVjdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../handshake/vertx/SecureScuttlebuttVertxClient.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL3ZlcnR4L1NlY3VyZVNjdXR0bGVidXR0VmVydHhDbGllbnQuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...va/org/apache/tuweni/scuttlebutt/rpc/RPCCodec.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0NvZGVjLmphdmE=) | `56.75% <ø> (ø)` | `8.00 <0.00> (ø)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [2 more](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=footer). Last update [43fb3c5...923d4b1](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] commented on pull request #133: Improve build, move license checks to only run if we touch dependencies
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #133:
URL: https://github.com/apache/incubator-tuweni/pull/133#issuecomment-660597141
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=h1) Report
> Merging [#133](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/e3c2f65b5906073fdae5096a25d6774c3f60ac7f&el=desc) will **decrease** coverage by `6.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #133 +/- ##
============================================
- Coverage 65.57% 59.29% -6.29%
+ Complexity 4177 3825 -352
============================================
Files 399 374 -25
Lines 19512 19117 -395
Branches 2419 2414 -5
============================================
- Hits 12795 11335 -1460
- Misses 5332 6553 +1221
+ Partials 1385 1229 -156
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #integration | `?` | `?` | |
| #unit | `59.29% <ø> (+1.31%)` | `3825.00 <ø> (+37.00)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/tuweni/concurrent/AsyncCompletion.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-Y29uY3VycmVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL2NvbmN1cnJlbnQvQXN5bmNDb21wbGV0aW9uLmphdmE=) | `81.60% <ø> (ø)` | `26.00 <0.00> (ø)` | |
| [...n/java/org/apache/tuweni/config/Configuration.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-Y29uZmlnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY29uZmlnL0NvbmZpZ3VyYXRpb24uamF2YQ==) | `43.47% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [...src/main/java/org/apache/tuweni/config/Schema.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-Y29uZmlnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY29uZmlnL1NjaGVtYS5qYXZh) | `43.57% <ø> (ø)` | `22.00 <0.00> (ø)` | |
| [...rc/main/java/org/apache/tuweni/plumtree/State.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cGx1bXRyZWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9wbHVtdHJlZS9TdGF0ZS5qYXZh) | `79.59% <ø> (-10.21%)` | `11.00 <0.00> (-3.00)` | |
| [...c/main/java/org/apache/tuweni/progpow/ProgPoW.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cHJvZ3Bvdy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3Byb2dwb3cvUHJvZ1BvVy5qYXZh) | `95.79% <ø> (ø)` | `31.00 <0.00> (ø)` | |
| [...apache/tuweni/rlpx/wire/DefaultWireConnection.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9EZWZhdWx0V2lyZUNvbm5lY3Rpb24uamF2YQ==) | `47.43% <ø> (-30.13%)` | `16.00 <0.00> (-9.00)` | |
| [...va/org/apache/tuweni/rlpx/wire/WireConnection.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9XaXJlQ29ubmVjdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../handshake/vertx/SecureScuttlebuttVertxClient.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL3ZlcnR4L1NlY3VyZVNjdXR0bGVidXR0VmVydHhDbGllbnQuamF2YQ==) | `0.00% <ø> (-58.54%)` | `0.00 <0.00> (-5.00)` | |
| [...va/org/apache/tuweni/scuttlebutt/rpc/RPCCodec.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ0NvZGVjLmphdmE=) | `56.75% <ø> (-10.82%)` | `8.00 <0.00> (-1.00)` | |
| [...pache/tuweni/scuttlebutt/rpc/RPCStreamRequest.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtcnBjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvcnBjL1JQQ1N0cmVhbVJlcXVlc3QuamF2YQ==) | `0.00% <ø> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
| ... and [116 more](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=footer). Last update [e3c2f65...b1b22bc](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #133: Improve build, move license checks to only run if we touch dependencies
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #133:
URL: https://github.com/apache/incubator-tuweni/pull/133#issuecomment-660597141
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=h1) Report
> Merging [#133](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/43fb3c59d0d57bba51075f9e8efd5477de32cf95&el=desc) will **increase** coverage by `7.46%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #133 +/- ##
============================================
+ Coverage 59.29% 66.75% +7.46%
- Complexity 3825 4226 +401
============================================
Files 374 399 +25
Lines 19117 19497 +380
Branches 2414 2419 +5
============================================
+ Hits 11335 13016 +1681
+ Misses 6553 5092 -1461
- Partials 1229 1389 +160
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #integration | `60.66% <0.00%> (?)` | `801.00 <0.00> (?)` | |
| #unit | `59.29% <ø> (ø)` | `3825.00 <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/tuweni/concurrent/AsyncCompletion.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-Y29uY3VycmVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL2NvbmN1cnJlbnQvQXN5bmNDb21wbGV0aW9uLmphdmE=) | `81.60% <ø> (ø)` | `26.00 <0.00> (ø)` | |
| [...n/java/org/apache/tuweni/config/Configuration.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-Y29uZmlnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY29uZmlnL0NvbmZpZ3VyYXRpb24uamF2YQ==) | `43.47% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [...src/main/java/org/apache/tuweni/config/Schema.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-Y29uZmlnL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvY29uZmlnL1NjaGVtYS5qYXZh) | `43.57% <ø> (ø)` | `22.00 <0.00> (ø)` | |
| [...vp2p/v5/internal/handler/RegTopicMessageHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvaW50ZXJuYWwvaGFuZGxlci9SZWdUb3BpY01lc3NhZ2VIYW5kbGVyLmt0) | `61.11% <ø> (+61.11%)` | `2.00 <0.00> (+2.00)` | |
| [.../apache/tuweni/devp2p/v5/packet/RegTopicMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvcGFja2V0L1JlZ1RvcGljTWVzc2FnZS5rdA==) | `100.00% <ø> (ø)` | `7.00 <0.00> (ø)` | |
| [...n/org/apache/tuweni/devp2p/v5/packet/UdpMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvcGFja2V0L1VkcE1lc3NhZ2Uua3Q=) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...rc/main/java/org/apache/tuweni/plumtree/State.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cGx1bXRyZWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9wbHVtdHJlZS9TdGF0ZS5qYXZh) | `89.79% <ø> (+10.20%)` | `14.00 <0.00> (+3.00)` | |
| [...c/main/java/org/apache/tuweni/progpow/ProgPoW.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cHJvZ3Bvdy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3Byb2dwb3cvUHJvZ1BvVy5qYXZh) | `95.79% <ø> (ø)` | `31.00 <0.00> (ø)` | |
| [...apache/tuweni/rlpx/wire/DefaultWireConnection.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9EZWZhdWx0V2lyZUNvbm5lY3Rpb24uamF2YQ==) | `77.56% <ø> (+30.12%)` | `25.00 <0.00> (+9.00)` | |
| [...va/org/apache/tuweni/rlpx/wire/WireConnection.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9XaXJlQ29ubmVjdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| ... and [116 more](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=footer). Last update [43fb3c5...923d4b1](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] atoulme merged pull request #133: Improve build, move license checks to only run if we touch dependencies
Posted by GitBox <gi...@apache.org>.
atoulme merged pull request #133:
URL: https://github.com/apache/incubator-tuweni/pull/133
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org
[GitHub] [incubator-tuweni] codecov[bot] edited a comment on pull request #133: Improve build, move license checks to only run if we touch dependencies
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #133:
URL: https://github.com/apache/incubator-tuweni/pull/133#issuecomment-660597141
# [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=h1) Report
> Merging [#133](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-tuweni/commit/43fb3c59d0d57bba51075f9e8efd5477de32cf95&el=desc) will **increase** coverage by `1.37%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #133 +/- ##
============================================
+ Coverage 59.29% 60.66% +1.37%
+ Complexity 3825 801 -3024
============================================
Files 374 162 -212
Lines 19117 5982 -13135
Branches 2414 589 -1825
============================================
- Hits 11335 3629 -7706
+ Misses 6553 1999 -4554
+ Partials 1229 354 -875
```
| Flag | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| #integration | `60.66% <0.00%> (?)` | `801.00 <0.00> (?)` | |
| #unit | `?` | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...vp2p/v5/internal/handler/RegTopicMessageHandler.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvaW50ZXJuYWwvaGFuZGxlci9SZWdUb3BpY01lc3NhZ2VIYW5kbGVyLmt0) | `61.11% <ø> (+61.11%)` | `2.00 <0.00> (+2.00)` | |
| [.../apache/tuweni/devp2p/v5/packet/RegTopicMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvcGFja2V0L1JlZ1RvcGljTWVzc2FnZS5rdA==) | `100.00% <ø> (ø)` | `6.00 <0.00> (-1.00)` | |
| [...n/org/apache/tuweni/devp2p/v5/packet/UdpMessage.kt](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-ZGV2cDJwL3NyYy9tYWluL2tvdGxpbi9vcmcvYXBhY2hlL3R1d2VuaS9kZXZwMnAvdjUvcGFja2V0L1VkcE1lc3NhZ2Uua3Q=) | `100.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...rc/main/java/org/apache/tuweni/plumtree/State.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cGx1bXRyZWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3R1d2VuaS9wbHVtdHJlZS9TdGF0ZS5qYXZh) | `60.20% <ø> (-19.39%)` | `10.00 <0.00> (-1.00)` | |
| [...apache/tuweni/rlpx/wire/DefaultWireConnection.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9EZWZhdWx0V2lyZUNvbm5lY3Rpb24uamF2YQ==) | `64.74% <ø> (+17.30%)` | `22.00 <0.00> (+6.00)` | |
| [...va/org/apache/tuweni/rlpx/wire/WireConnection.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-cmxweC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3JscHgvd2lyZS9XaXJlQ29ubmVjdGlvbi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...g/apache/tuweni/scuttlebutt/lib/KeyFileLoader.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtY2xpZW50LWxpYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3NjdXR0bGVidXR0L2xpYi9LZXlGaWxlTG9hZGVyLmphdmE=) | `76.92% <ø> (ø)` | `5.00 <0.00> (?)` | |
| [.../apache/tuweni/scuttlebutt/lib/NetworkService.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtY2xpZW50LWxpYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3NjdXR0bGVidXR0L2xpYi9OZXR3b3JrU2VydmljZS5qYXZh) | `22.44% <0.00%> (ø)` | `4.00 <0.00> (?)` | |
| [...tuweni/scuttlebutt/lib/model/query/AboutQuery.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtY2xpZW50LWxpYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdHV3ZW5pL3NjdXR0bGVidXR0L2xpYi9tb2RlbC9xdWVyeS9BYm91dFF1ZXJ5LmphdmE=) | `0.00% <ø> (ø)` | `0.00 <0.00> (?)` | |
| [.../handshake/vertx/SecureScuttlebuttVertxClient.java](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree#diff-c2N1dHRsZWJ1dHQtaGFuZHNoYWtlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS90dXdlbmkvc2N1dHRsZWJ1dHQvaGFuZHNoYWtlL3ZlcnR4L1NlY3VyZVNjdXR0bGVidXR0VmVydHhDbGllbnQuamF2YQ==) | `58.53% <ø> (+58.53%)` | `5.00 <0.00> (+5.00)` | |
| ... and [363 more](https://codecov.io/gh/apache/incubator-tuweni/pull/133/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=footer). Last update [43fb3c5...923d4b1](https://codecov.io/gh/apache/incubator-tuweni/pull/133?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tuweni.apache.org
For additional commands, e-mail: dev-help@tuweni.apache.org