You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Emmanuel Lecharny (JIRA)" <di...@incubator.apache.org> on 2005/02/03 11:37:18 UTC

[jira] Created: (DIRLDAP-34) DnParser does not respect RFC2253

DnParser does not respect RFC2253
---------------------------------

         Key: DIRLDAP-34
         URL: http://issues.apache.org/jira/browse/DIRLDAP-34
     Project: Directory LDAP
        Type: Bug
  Components: Common  
    Versions: 0.8.0    
 Environment: NR
    Reporter: Emmanuel Lecharny
 Assigned to: Alex Karasulu 


The DnParser does not conform to RFC 2253 and RFC 1779 :

parsed  :  "CN=L. Eagle,O=Sue\, Grabbit and Runn,C=GB"
expected : "CN=L. Eagle,O=Sue\,Grabbit and Runn,C=GB"

Parsing "CN=Before\0DAfter,O=Test,C=GB" leads to an infinite loop

Other tests are to be done ...


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DIRLDAP-34) DnParser does not respect RFC2253

Posted by "Alan Cabrera (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIRLDAP-34?page=comments#action_58556 ]
     
Alan Cabrera commented on DIRLDAP-34:
-------------------------------------

I noticed that the ANTLR code for DN is split into several files.  Is this necessary?

> DnParser does not respect RFC2253
> ---------------------------------
>
>          Key: DIRLDAP-34
>          URL: http://issues.apache.org/jira/browse/DIRLDAP-34
>      Project: Directory LDAP
>         Type: Bug
>   Components: Common
>     Versions: 0.8.0
>  Environment: NR
>     Reporter: Emmanuel Lecharny
>     Assignee: Alex Karasulu
>  Attachments: DnParserTest.java
>
> The DnParser does not conform to RFC 2253 and RFC 1779 :
> parsed  :  "CN=L. Eagle,O=Sue\, Grabbit and Runn,C=GB"
> expected : "CN=L. Eagle,O=Sue\,Grabbit and Runn,C=GB"
> Parsing "CN=Before\0DAfter,O=Test,C=GB" leads to an infinite loop
> Other tests are to be done ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Updated: (DIRLDAP-34) DnParser does not respect RFC2253

Posted by "Emmanuel Lecharny (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIRLDAP-34?page=history ]

Emmanuel Lecharny updated DIRLDAP-34:
-------------------------------------

    Attachment: DnParserTest.java

Test case for DnParser

> DnParser does not respect RFC2253
> ---------------------------------
>
>          Key: DIRLDAP-34
>          URL: http://issues.apache.org/jira/browse/DIRLDAP-34
>      Project: Directory LDAP
>         Type: Bug
>   Components: Common
>     Versions: 0.8.0
>  Environment: NR
>     Reporter: Emmanuel Lecharny
>     Assignee: Alex Karasulu
>  Attachments: DnParserTest.java
>
> The DnParser does not conform to RFC 2253 and RFC 1779 :
> parsed  :  "CN=L. Eagle,O=Sue\, Grabbit and Runn,C=GB"
> expected : "CN=L. Eagle,O=Sue\,Grabbit and Runn,C=GB"
> Parsing "CN=Before\0DAfter,O=Test,C=GB" leads to an infinite loop
> Other tests are to be done ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DIRLDAP-34) DnParser does not respect RFC2253

Posted by "Alan Cabrera (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIRLDAP-34?page=comments#action_58599 ]
     
Alan Cabrera commented on DIRLDAP-34:
-------------------------------------

Fixed the infinite loop.  The string "CN=Before\0DAfter,O=Test,C=GB"  should be "CN=Before\\0DAfter,O=Test,C=GB".

We should be immune to bad strings like this.  We should add a check before we parse.

> DnParser does not respect RFC2253
> ---------------------------------
>
>          Key: DIRLDAP-34
>          URL: http://issues.apache.org/jira/browse/DIRLDAP-34
>      Project: Directory LDAP
>         Type: Bug
>   Components: Common
>     Versions: 0.8.0
>  Environment: NR
>     Reporter: Emmanuel Lecharny
>     Assignee: Alan Cabrera
>  Attachments: DnParserTest.java
>
> The DnParser does not conform to RFC 2253 and RFC 1779 :
> parsed  :  "CN=L. Eagle,O=Sue\, Grabbit and Runn,C=GB"
> expected : "CN=L. Eagle,O=Sue\,Grabbit and Runn,C=GB"
> Parsing "CN=Before\0DAfter,O=Test,C=GB" leads to an infinite loop
> Other tests are to be done ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (DIRLDAP-34) DnParser does not respect RFC2253

Posted by "Alex Karasulu (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIRLDAP-34?page=comments#action_58563 ]
     
Alex Karasulu commented on DIRLDAP-34:
--------------------------------------

Perhaps not - I don't know.  I tried to get grammar into one lexer but Antlr would not have it.  It's due I think to oddities in the EBNF with values conflicting with identifiers.  I needed to switch lexical state.  Allan could u take the time to look at the RFC and the grammar to figure this out for me.  I'd like a second oppinion on this.


> DnParser does not respect RFC2253
> ---------------------------------
>
>          Key: DIRLDAP-34
>          URL: http://issues.apache.org/jira/browse/DIRLDAP-34
>      Project: Directory LDAP
>         Type: Bug
>   Components: Common
>     Versions: 0.8.0
>  Environment: NR
>     Reporter: Emmanuel Lecharny
>     Assignee: Alex Karasulu
>  Attachments: DnParserTest.java
>
> The DnParser does not conform to RFC 2253 and RFC 1779 :
> parsed  :  "CN=L. Eagle,O=Sue\, Grabbit and Runn,C=GB"
> expected : "CN=L. Eagle,O=Sue\,Grabbit and Runn,C=GB"
> Parsing "CN=Before\0DAfter,O=Test,C=GB" leads to an infinite loop
> Other tests are to be done ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (DIRLDAP-34) DnParser does not respect RFC2253

Posted by "Alan Cabrera (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIRLDAP-34?page=history ]

Alan Cabrera reassigned DIRLDAP-34:
-----------------------------------

    Assign To: Alan Cabrera  (was: Alex Karasulu)

> DnParser does not respect RFC2253
> ---------------------------------
>
>          Key: DIRLDAP-34
>          URL: http://issues.apache.org/jira/browse/DIRLDAP-34
>      Project: Directory LDAP
>         Type: Bug
>   Components: Common
>     Versions: 0.8.0
>  Environment: NR
>     Reporter: Emmanuel Lecharny
>     Assignee: Alan Cabrera
>  Attachments: DnParserTest.java
>
> The DnParser does not conform to RFC 2253 and RFC 1779 :
> parsed  :  "CN=L. Eagle,O=Sue\, Grabbit and Runn,C=GB"
> expected : "CN=L. Eagle,O=Sue\,Grabbit and Runn,C=GB"
> Parsing "CN=Before\0DAfter,O=Test,C=GB" leads to an infinite loop
> Other tests are to be done ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Re: [jira] Commented: (DIRLDAP-34) DnParser does not respect RFC2253

Posted by Alex Karasulu <ao...@bellsouth.net>.
It may very well be designed poorly and in need of Alanification.  I 
don't remember too much of what I did in the past.  Looks like you have 
a handle on it though.  I'd have to go into the code to reassociate 
myself with it.  I will start doing that if you need me to.  Just let me 
know if you need a hand deciphering it.

Thanks,
Alex

Alan Cabrera (JIRA) wrote:

>     [ http://issues.apache.org/jira/browse/DIRLDAP-34?page=comments#action_58601 ]
>     
>Alan Cabrera commented on DIRLDAP-34:
>-------------------------------------
>
>The value parser does something odd.  It parses the values in bits.  I suspect that it does this because it wants the possibility to normalize the bits; which is something that it doesn't seem to do very well atm but, I could be wrong.  
>
>The problem w/ parsing in pieces is that the parser thinks that this is a valid value
>
>CN= FOO "BAR" CAR ,
>
>I believe that the value parser should grab the whole value in one valid piece.  If normalization needs to take place, then break the valid value into tiny normalizable pieces.
>
>  
>
>>DnParser does not respect RFC2253
>>---------------------------------
>>
>>         Key: DIRLDAP-34
>>         URL: http://issues.apache.org/jira/browse/DIRLDAP-34
>>     Project: Directory LDAP
>>        Type: Bug
>>  Components: Common
>>    Versions: 0.8.0
>> Environment: NR
>>    Reporter: Emmanuel Lecharny
>>    Assignee: Alan Cabrera
>> Attachments: DnParserTest.java
>>
>>The DnParser does not conform to RFC 2253 and RFC 1779 :
>>parsed  :  "CN=L. Eagle,O=Sue\, Grabbit and Runn,C=GB"
>>expected : "CN=L. Eagle,O=Sue\,Grabbit and Runn,C=GB"
>>Parsing "CN=Before\0DAfter,O=Test,C=GB" leads to an infinite loop
>>Other tests are to be done ...
>>    
>>
>
>  
>


[jira] Commented: (DIRLDAP-34) DnParser does not respect RFC2253

Posted by "Alan Cabrera (JIRA)" <di...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/DIRLDAP-34?page=comments#action_58601 ]
     
Alan Cabrera commented on DIRLDAP-34:
-------------------------------------

The value parser does something odd.  It parses the values in bits.  I suspect that it does this because it wants the possibility to normalize the bits; which is something that it doesn't seem to do very well atm but, I could be wrong.  

The problem w/ parsing in pieces is that the parser thinks that this is a valid value

CN= FOO "BAR" CAR ,

I believe that the value parser should grab the whole value in one valid piece.  If normalization needs to take place, then break the valid value into tiny normalizable pieces.

> DnParser does not respect RFC2253
> ---------------------------------
>
>          Key: DIRLDAP-34
>          URL: http://issues.apache.org/jira/browse/DIRLDAP-34
>      Project: Directory LDAP
>         Type: Bug
>   Components: Common
>     Versions: 0.8.0
>  Environment: NR
>     Reporter: Emmanuel Lecharny
>     Assignee: Alan Cabrera
>  Attachments: DnParserTest.java
>
> The DnParser does not conform to RFC 2253 and RFC 1779 :
> parsed  :  "CN=L. Eagle,O=Sue\, Grabbit and Runn,C=GB"
> expected : "CN=L. Eagle,O=Sue\,Grabbit and Runn,C=GB"
> Parsing "CN=Before\0DAfter,O=Test,C=GB" leads to an infinite loop
> Other tests are to be done ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira