[GitHub] [storm] agresch commented on a change in pull request #3096: STORM-3480 Implement One Worker Per Executor RAS Option

[GitBox <gi...@apache.org>]

agresch commented on a change in pull request #3096: STORM-3480 Implement One Worker Per Executor RAS Option
URL: https://github.com/apache/storm/pull/3096#discussion_r310197676
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/Cluster.java
 ##########
 @@ -700,17 +703,17 @@ public void assign(SchedulerAssignment assignment, boolean ignoreSingleException
     }
 
     /**
-     * Calculate the amount of shared off heap memory on a given nodes with the given assignment.
+     * Calculate the amount of shared off heap node memory on a given node with the given assignment.
      *
      * @param nodeId     the id of the node
      * @param assignment the current assignment
-     * @return the amount of shared off heap memory for that node in MB
+     * @return the amount of shared off heap node memory for that node in MB
      */
-    private double calculateSharedOffHeapMemory(String nodeId, SchedulerAssignmentImpl assignment) {
-        return calculateSharedOffHeapMemory(nodeId, assignment, null);
+    private double calculateSharedOffHeapNodedMemory(String nodeId, SchedulerAssignmentImpl assignment) {
 
 Review comment:
   Did you mean Nodeid or NodeId?  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services