You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Dhaval Rajpara <dh...@gmail.com> on 2024/04/30 12:02:02 UTC
Re: Review Request 74924: RANGER-4593 : Upgrade react-bootstrap library.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74924/
-----------------------------------------------------------
(Updated April 30, 2024, 12:01 p.m.)
Review request for ranger, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, and Velmurugan Periasamy.
Bugs: RANGER-4593
https://issues.apache.org/jira/browse/RANGER-4593
Repository: ranger
Description
-------
Upgrade react-bootstrap library version 1.6.7 to 2.10.0.
This changes also required bootstrap library Upgrade.
so we migrate Bootstrap version 4.6.0 to 5.3.2
Diffs
-----
security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java c0a0b7e2d
security-admin/src/main/resources/conf.dist/security-applicationContext.xml 738ca16f7
security-admin/src/main/webapp/login.jsp 142aa03a6
security-admin/src/main/webapp/react-webapp/package-lock.json 7de226745
security-admin/src/main/webapp/react-webapp/package.json 0808fac9c
security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx 79fcbd11a
security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx 7dfcc672a
security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx e0b7dc596
security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/token.js 564378272
security-admin/src/main/webapp/react-webapp/src/styles/style.css 1de790b9f
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx 23236ff9f
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx 7781ebd2b
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx d73e81f23
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx 064717025
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx 29d5299da
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx 36dffc0cc
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx bebbcc40b
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx 999a29162
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx a582cbb8b
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx 6e20763d4
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx 5eb26825c
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx b4945a351
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx 37a8cd2a5
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx 01a5fbd1b
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx a99c4f27b
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx d900ecbf6
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx 5e01f6a38
security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx f114c0c92
security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx 57f6790c5
security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx 46418ffe8
security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx 2b8c6d4fc
security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx 660252c16
security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx a19374485
security-admin/src/main/webapp/react-webapp/src/views/Header.jsx a51e1a644
security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx dc3c21ff8
security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx e0953008a
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx 7ba555972
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx f9aaa3a40
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx 5a0eeb602
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx f9fe4a38d
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx 890722990
security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx 1fef5501b
security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx 08e3d5ebd
security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx bfea9793a
security-admin/src/main/webapp/react-webapp/src/views/Resources/ModalResourceComp.jsx f6e559041
security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx fa4d518f4
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx 474d8eeec
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx 61bc250e8
security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx f01483bab
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx 21b9f6ee1
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx ae05a1f2c
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx 2643c5586
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx cf61db294
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx be179a981
security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceViewDetails.jsx 8016d4489
security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBarBody.jsx 0bcccc968
security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx 297996170
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx 108731f26
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx 3414246f0
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx 97d0194a1
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx 4b202ea6d
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx f01398aa4
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx 44468cda6
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx cb0544c8a
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx 82506ff8a
security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx d5f3018e5
Diff: https://reviews.apache.org/r/74924/diff/1/
Testing (updated)
-------
Validated below scenarios on react UI
1. Tested Resource Based/Tag Based/ KMS Service CRUD.
2. Tested Zone & Unzone policy CRUD.
3. Tested User/Group/ Role CRUD.
4. Tested Zone CRUD.
5. Tested with all role users.
6. Tested reports/permissions/audits tab.
7. Tested Export and import feature.
Thanks,
Dhaval Rajpara
Re: Review Request 74924: RANGER-4593 : Upgrade react-bootstrap library.
Posted by Brijesh Bhalala <br...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74924/#review226406
-----------------------------------------------------------
Ship it!
Ship It!
- Brijesh Bhalala
On April 30, 2024, 12:01 p.m., Dhaval Rajpara wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74924/
> -----------------------------------------------------------
>
> (Updated April 30, 2024, 12:01 p.m.)
>
>
> Review request for ranger, Brijesh Bhalala, Dhaval Shah, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Mugdha Varadkar, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4593
> https://issues.apache.org/jira/browse/RANGER-4593
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Upgrade react-bootstrap library version 1.6.7 to 2.10.0.
>
> This changes also required bootstrap library Upgrade.
> so we migrate Bootstrap version 4.6.0 to 5.3.2
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSecurityContextFormationFilter.java c0a0b7e2d
> security-admin/src/main/resources/conf.dist/security-applicationContext.xml 738ca16f7
> security-admin/src/main/webapp/login.jsp 142aa03a6
> security-admin/src/main/webapp/react-webapp/package-lock.json 7de226745
> security-admin/src/main/webapp/react-webapp/package.json 0808fac9c
> security-admin/src/main/webapp/react-webapp/src/components/CommonComponents.jsx 79fcbd11a
> security-admin/src/main/webapp/react-webapp/src/components/Editable.jsx 7dfcc672a
> security-admin/src/main/webapp/react-webapp/src/components/XATableLayout.jsx e0b7dc596
> security-admin/src/main/webapp/react-webapp/src/components/structured-filter/react-typeahead/tokenizer/token.js 564378272
> security-admin/src/main/webapp/react-webapp/src/styles/style.css 1de790b9f
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogs.jsx 23236ff9f
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AccessLogsTable.jsx 7781ebd2b
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs.jsx d73e81f23
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/GroupLogs.jsx 064717025
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PasswordLogs.jsx 29d5299da
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyLogs.jsx 36dffc0cc
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/PolicyViewDetails.jsx bebbcc40b
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/RoleLogs.jsx 999a29162
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/SecurityZonelogs.jsx a582cbb8b
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/ServiceLogs.jsx 6e20763d4
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserLogs.jsx 5eb26825c
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminLogs/UserprofileLogs.jsx b4945a351
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/AdminModal.jsx 37a8cd2a5
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/LoginSessionsLogs.jsx 01a5fbd1b
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/OperationAdminModal.jsx a99c4f27b
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginStatusLogs.jsx d900ecbf6
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/PluginsLog.jsx 5e01f6a38
> security-admin/src/main/webapp/react-webapp/src/views/AuditEvent/UserSync.jsx f114c0c92
> security-admin/src/main/webapp/react-webapp/src/views/CustomBreadcrumb.jsx 57f6790c5
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyCreate.jsx 46418ffe8
> security-admin/src/main/webapp/react-webapp/src/views/Encryption/KeyManager.jsx 2b8c6d4fc
> security-admin/src/main/webapp/react-webapp/src/views/ErrorBoundary.jsx 660252c16
> security-admin/src/main/webapp/react-webapp/src/views/ErrorPage.jsx a19374485
> security-admin/src/main/webapp/react-webapp/src/views/Header.jsx a51e1a644
> security-admin/src/main/webapp/react-webapp/src/views/Layout.jsx dc3c21ff8
> security-admin/src/main/webapp/react-webapp/src/views/PermissionsModule/EditPermission.jsx e0953008a
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/AddUpdatePolicyForm.jsx 7ba555972
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyConditionsComp.jsx f9aaa3a40
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyListing.jsx 5a0eeb602
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyPermissionItem.jsx f9fe4a38d
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/PolicyValidityPeriodComp.jsx 890722990
> security-admin/src/main/webapp/react-webapp/src/views/PolicyListing/TagBasePermissionItem.jsx 1fef5501b
> security-admin/src/main/webapp/react-webapp/src/views/Reports/SearchPolicyTable.jsx 08e3d5ebd
> security-admin/src/main/webapp/react-webapp/src/views/Reports/UserAccessLayout.jsx bfea9793a
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ModalResourceComp.jsx f6e559041
> security-admin/src/main/webapp/react-webapp/src/views/Resources/ResourceComp.jsx fa4d518f4
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/SecurityZoneForm.jsx 474d8eeec
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneDisplay.jsx 61bc250e8
> security-admin/src/main/webapp/react-webapp/src/views/SecurityZone/ZoneListing.jsx f01483bab
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ImportPolicy.jsx 21b9f6ee1
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceAuditFilter.jsx ae05a1f2c
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinition.jsx 2643c5586
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceDefinitions.jsx cf61db294
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceForm.jsx be179a981
> security-admin/src/main/webapp/react-webapp/src/views/ServiceManager/ServiceViewDetails.jsx 8016d4489
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/SideBarBody.jsx 0bcccc968
> security-admin/src/main/webapp/react-webapp/src/views/SideBar/TopNavBar.jsx 297996170
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/GroupAssociateUserDetails.jsx 108731f26
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupForm.jsx 3414246f0
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/groups_details/GroupListing.jsx 97d0194a1
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleForm.jsx 4b202ea6d
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/role_details/RoleListing.jsx f01398aa4
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/EditUserView.jsx 44468cda6
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserFormComp.jsx cb0544c8a
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/users_details/UserListing.jsx 82506ff8a
> security-admin/src/main/webapp/react-webapp/src/views/UserProfile.jsx d5f3018e5
>
>
> Diff: https://reviews.apache.org/r/74924/diff/1/
>
>
> Testing
> -------
>
> Validated below scenarios on react UI
> 1. Tested Resource Based/Tag Based/ KMS Service CRUD.
> 2. Tested Zone & Unzone policy CRUD.
> 3. Tested User/Group/ Role CRUD.
> 4. Tested Zone CRUD.
> 5. Tested with all role users.
> 6. Tested reports/permissions/audits tab.
> 7. Tested Export and import feature.
>
>
> Thanks,
>
> Dhaval Rajpara
>
>