You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/11 04:36:03 UTC

[GitHub] [beam] AnandInguva opened a new pull request, #24114: Update staging of Python wheels

AnandInguva opened a new pull request, #24114:
URL: https://github.com/apache/beam/pull/24114

   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #24114:
URL: https://github.com/apache/beam/pull/24114#issuecomment-1312097173

   > Could you please come up with a minimum change that can unblock 2.43.0 ? (for example, just change wheel selection to pick up the correct one in stager).
   > 
   > If this is the minimal change that's OK.
   
   Unfortunately, this is the minimum change. 
   
   I had to update the regex to accommodate Python 3.10 wheels as well


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] chamikaramj commented on pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #24114:
URL: https://github.com/apache/beam/pull/24114#issuecomment-1312099685

   Run Python Dataflow V2 ValidatesRunner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on a diff in pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on code in PR #24114:
URL: https://github.com/apache/beam/pull/24114#discussion_r1020507565


##########
sdks/python/setup.py:
##########
@@ -95,7 +95,7 @@ def get_version():
 different technologies and user communities.
 '''
 
-RECOMMENDED_MIN_PIP_VERSION = '7.0.0'

Review Comment:
   it's harmless, used below in a warning message



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] chamikaramj commented on pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #24114:
URL: https://github.com/apache/beam/pull/24114#issuecomment-1312098951

   Run Python 3.10 PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] chamikaramj commented on pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #24114:
URL: https://github.com/apache/beam/pull/24114#issuecomment-1312091728

   Could you please come up with a minimum change that can unblock 2.43.0 ? (for example, just change wheel selection to pick up the correct one in stager).
   
   If this is the minimal change that's OK.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on a diff in pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on code in PR #24114:
URL: https://github.com/apache/beam/pull/24114#discussion_r1020507004


##########
sdks/python/setup.py:
##########
@@ -95,7 +95,7 @@ def get_version():
 different technologies and user communities.
 '''
 
-RECOMMENDED_MIN_PIP_VERSION = '7.0.0'

Review Comment:
   Yes, pip can discover manylinux_2014 wheels from version 19.3.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #24114:
URL: https://github.com/apache/beam/pull/24114#issuecomment-1312072830

   > > could you add some details to the PR description what pypi changes required us making these modifications?
   > 
   > looks like you updated it already.do you know what changes made us build manylinux2014 wheels?
   
   Hm..I think I found why. We updated the `cibuildwheels` to `2.9.0` recently. Before that, it was `1.1.x`. After the upgrade, one thing we missed is how `cibuildwheel` new version builds the wheel. In `cibuildwheel==2.3.0`, they made the default of building images on `manylinux2014` instead of `manylinux2010`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #24114:
URL: https://github.com/apache/beam/pull/24114#issuecomment-1312108013

   happy to merge when precommits pass


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] chamikaramj commented on pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #24114:
URL: https://github.com/apache/beam/pull/24114#issuecomment-1312122607

   Ack. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] chamikaramj commented on a diff in pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on code in PR #24114:
URL: https://github.com/apache/beam/pull/24114#discussion_r1020499161


##########
sdks/python/setup.py:
##########
@@ -95,7 +95,7 @@ def get_version():
 different technologies and user communities.
 '''
 
-RECOMMENDED_MIN_PIP_VERSION = '7.0.0'

Review Comment:
   Is this change needed for 2.43.0 ? I wonder if this can result in other regressions.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] chamikaramj commented on pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #24114:
URL: https://github.com/apache/beam/pull/24114#issuecomment-1312097011

   Thanks. Let's get the change into master first and cherry-pick from there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on a diff in pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on code in PR #24114:
URL: https://github.com/apache/beam/pull/24114#discussion_r1020456265


##########
sdks/python/apache_beam/runners/portability/stager.py:
##########
@@ -897,10 +901,10 @@ def _create_beam_sdk(sdk_remote_location, temp_dir):
   def _download_pypi_sdk_package(
       temp_dir,
       fetch_binary=False,
-      language_version_tag='27',
+      language_version_tag='39',

Review Comment:
   doesn't matter here, but in general changing default values may be a risky change in case there are some callers that rely on older default.



##########
sdks/python/apache_beam/runners/portability/stager.py:
##########
@@ -935,7 +939,12 @@ def _download_pypi_sdk_package(
           '--platform',
           platform_tag
       ])
-      # Example wheel: apache_beam-2.4.0-cp27-cp27mu-manylinux1_x86_64.whl
+      # Example wheel: apache_beam-2.42.0-cp39-cp39-manylinux1_x86_64.whl
+      # Example wheel: with manylinux14 tag.
+      # apache_beam-2.43.0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_

Review Comment:
   nit: you can move it on the same line for readability and disable linter on this line if necessary



##########
sdks/python/apache_beam/runners/portability/stager.py:
##########
@@ -935,7 +939,12 @@ def _download_pypi_sdk_package(
           '--platform',
           platform_tag
       ])
-      # Example wheel: apache_beam-2.4.0-cp27-cp27mu-manylinux1_x86_64.whl
+      # Example wheel: apache_beam-2.42.0-cp39-cp39-manylinux1_x86_64.whl

Review Comment:
   no longer need to mention the outdated case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] chamikaramj commented on pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #24114:
URL: https://github.com/apache/beam/pull/24114#issuecomment-1312099050

   Run Python 3.8 PostCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn merged pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
tvalentyn merged PR #24114:
URL: https://github.com/apache/beam/pull/24114


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] codecov[bot] commented on pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #24114:
URL: https://github.com/apache/beam/pull/24114#issuecomment-1311236834

   # [Codecov](https://codecov.io/gh/apache/beam/pull/24114?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#24114](https://codecov.io/gh/apache/beam/pull/24114?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f6a7710) into [master](https://codecov.io/gh/apache/beam/commit/4b96193250a63b27721a8c5e1a3bd6ecff983093?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b96193) will **increase** coverage by `0.00%`.
   > The diff coverage is `100.00%`.
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #24114   +/-   ##
   =======================================
     Coverage   73.32%   73.33%           
   =======================================
     Files         714      714           
     Lines       96442    96443    +1     
   =======================================
   + Hits        70717    70723    +6     
   + Misses      24405    24400    -5     
     Partials     1320     1320           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | python | `83.21% <100.00%> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/beam/pull/24114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...s/python/apache\_beam/runners/portability/stager.py](https://codecov.io/gh/apache/beam/pull/24114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9zdGFnZXIucHk=) | `87.15% <100.00%> (+0.87%)` | :arrow_up: |
   | [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/24114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `95.12% <0.00%> (-2.44%)` | :arrow_down: |
   | [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/24114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.30% <0.00%> (-0.25%)` | :arrow_down: |
   | [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/24114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.24% <0.00%> (+0.16%)` | :arrow_up: |
   | [...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/24114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=) | `91.77% <0.00%> (+1.26%)` | :arrow_up: |
   | [.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/24114/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5) | `92.85% <0.00%> (+4.76%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #24114:
URL: https://github.com/apache/beam/pull/24114#issuecomment-1312051577

   Dataflow runner able to catch the cached wheel wit these changes. Without these changes, there is a 5 minutes overhead for installing Apache beam for sdist. 
   
   https://screenshot.googleplex.com/uvouKrEiLFD2eEJ


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #24114:
URL: https://github.com/apache/beam/pull/24114#issuecomment-1312055890

   > could you add some details to the PR description what pypi changes required us making these modifications?
   
   looks like you updated it already.do you know what changes made us build manylinux2014 wheels?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #24114:
URL: https://github.com/apache/beam/pull/24114#issuecomment-1312056673

   > description
   
   No, we don't need to change anything related to staging requirements cache. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on a diff in pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on code in PR #24114:
URL: https://github.com/apache/beam/pull/24114#discussion_r1020489605


##########
sdks/python/apache_beam/runners/portability/stager.py:
##########
@@ -897,10 +901,10 @@ def _create_beam_sdk(sdk_remote_location, temp_dir):
   def _download_pypi_sdk_package(
       temp_dir,
       fetch_binary=False,
-      language_version_tag='27',
+      language_version_tag='39',

Review Comment:
   Ack.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] chamikaramj commented on pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
chamikaramj commented on PR #24114:
URL: https://github.com/apache/beam/pull/24114#issuecomment-1312099510

   Run Python Dataflow ValidatesRunner


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on pull request #24114: Update staging of Python wheels

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on PR #24114:
URL: https://github.com/apache/beam/pull/24114#issuecomment-1312106994

   this test should not affect postcommit / vr suite since the said suite use beam from sources


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org